mbox series

[net-next,v3,0/2] net: phy: Support master-slave config via device tree

Message ID 20240913084022.3343903-1-o.rempel@pengutronix.de
Headers show
Series net: phy: Support master-slave config via device tree | expand

Message

Oleksij Rempel Sept. 13, 2024, 8:40 a.m. UTC
This patch series adds support for configuring the master/slave role of
PHYs via the device tree. A new `master-slave` property is introduced in
the device tree bindings, allowing PHYs to be forced into either master
or slave mode. This is particularly necessary for Single Pair Ethernet
(SPE) PHYs (1000/100/10Base-T1), where hardware strap pins may not be
available or correctly configured, but it is applicable to all PHY
types.

changes v3:
- rename  master-slave to timing-role
- add prefer-master/slave support

Oleksij Rempel (2):
  dt-bindings: net: ethernet-phy: Add timing-role role property for
    ethernet PHYs
  net: phy: Add support for PHY timing-role configuration via device
    tree

 .../devicetree/bindings/net/ethernet-phy.yaml | 21 ++++++++++++
 drivers/net/phy/phy-core.c                    | 33 +++++++++++++++++++
 drivers/net/phy/phy_device.c                  |  3 ++
 include/linux/phy.h                           |  1 +
 4 files changed, 58 insertions(+)

--
2.39.2

Comments

Jakub Kicinski Sept. 15, 2024, 4:06 p.m. UTC | #1
On Fri, 13 Sep 2024 10:40:20 +0200 Oleksij Rempel wrote:
> This patch series adds support for configuring the master/slave role of
> PHYs via the device tree. A new `master-slave` property is introduced in
> the device tree bindings, allowing PHYs to be forced into either master
> or slave mode. This is particularly necessary for Single Pair Ethernet
> (SPE) PHYs (1000/100/10Base-T1), where hardware strap pins may not be
> available or correctly configured, but it is applicable to all PHY
> types.

I was hoping we'd see some acks here in time, but now Linus cut the 6.11
final so the 6.12 game is over now:
pw-bot: defer
Andrew Lunn Sept. 15, 2024, 6:41 p.m. UTC | #2
On Sun, Sep 15, 2024 at 06:06:30PM +0200, Jakub Kicinski wrote:
> On Fri, 13 Sep 2024 10:40:20 +0200 Oleksij Rempel wrote:
> > This patch series adds support for configuring the master/slave role of
> > PHYs via the device tree. A new `master-slave` property is introduced in
> > the device tree bindings, allowing PHYs to be forced into either master
> > or slave mode. This is particularly necessary for Single Pair Ethernet
> > (SPE) PHYs (1000/100/10Base-T1), where hardware strap pins may not be
> > available or correctly configured, but it is applicable to all PHY
> > types.
> 
> I was hoping we'd see some acks here in time, but now Linus cut the 6.11
> final so the 6.12 game is over now:

The device tree binding is not decided on yet. So deferred is correct.

    Andrew
Oleksij Rempel Sept. 16, 2024, 5:30 a.m. UTC | #3
On Sun, Sep 15, 2024 at 08:41:42PM +0200, Andrew Lunn wrote:
> On Sun, Sep 15, 2024 at 06:06:30PM +0200, Jakub Kicinski wrote:
> > On Fri, 13 Sep 2024 10:40:20 +0200 Oleksij Rempel wrote:
> > > This patch series adds support for configuring the master/slave role of
> > > PHYs via the device tree. A new `master-slave` property is introduced in
> > > the device tree bindings, allowing PHYs to be forced into either master
> > > or slave mode. This is particularly necessary for Single Pair Ethernet
> > > (SPE) PHYs (1000/100/10Base-T1), where hardware strap pins may not be
> > > available or correctly configured, but it is applicable to all PHY
> > > types.
> > 
> > I was hoping we'd see some acks here in time, but now Linus cut the 6.11
> > final so the 6.12 game is over now:
> 
> The device tree binding is not decided on yet. So deferred is correct.

No problem. See you on LPC, my flight starting right now.

Regards,
Oleksij
Russell King (Oracle) Sept. 17, 2024, 9:17 a.m. UTC | #4
On Fri, Sep 13, 2024 at 10:40:22AM +0200, Oleksij Rempel wrote:
> Introduce support for configuring the master/slave role of PHYs based on
> the `timing-role` property in the device tree. While this functionality
> is necessary for Single Pair Ethernet (SPE) PHYs (1000/100/10Base-T1)
> where hardware strap pins may be unavailable or incorrectly set, it
> works for any PHY type.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!