| Message ID | 20240909082514.262942-1-Parthiban.Veerasooran@microchip.com |
|---|---|
| Headers | show |
| Series | Add support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface | expand |
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 9 Sep 2024 13:55:00 +0530 you wrote: > This patch series contain the below updates, > - Adds support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface in the > net/ethernet/oa_tc6.c. > Link to the spec: > ----------------- > https://opensig.org/download/document/OPEN_Alliance_10BASET1x_MAC-PHY_Serial_Interface_V1.1.pdf > > [...] Here is the summary with links: - [net-next,v8,01/14] Documentation: networking: add OPEN Alliance 10BASE-T1x MAC-PHY serial interface https://git.kernel.org/netdev/net-next/c/b3e33f2c54c6 - [net-next,v8,02/14] net: ethernet: oa_tc6: implement register write operation https://git.kernel.org/netdev/net-next/c/aa58bec064ab - [net-next,v8,03/14] net: ethernet: oa_tc6: implement register read operation https://git.kernel.org/netdev/net-next/c/375d1e0278cc - [net-next,v8,04/14] net: ethernet: oa_tc6: implement software reset https://git.kernel.org/netdev/net-next/c/1f9c4eed9c11 - [net-next,v8,05/14] net: ethernet: oa_tc6: implement error interrupts unmasking https://git.kernel.org/netdev/net-next/c/86c03a0f07f4 - [net-next,v8,06/14] net: ethernet: oa_tc6: implement internal PHY initialization https://git.kernel.org/netdev/net-next/c/8f9bf857e43b - [net-next,v8,07/14] net: phy: microchip_t1s: add c45 direct access in LAN865x internal PHY https://git.kernel.org/netdev/net-next/c/18a918762fab - [net-next,v8,08/14] net: ethernet: oa_tc6: enable open alliance tc6 data communication https://git.kernel.org/netdev/net-next/c/f845a027de66 - [net-next,v8,09/14] net: ethernet: oa_tc6: implement transmit path to transfer tx ethernet frames https://git.kernel.org/netdev/net-next/c/53fbde8ab21e - [net-next,v8,10/14] net: ethernet: oa_tc6: implement receive path to receive rx ethernet frames https://git.kernel.org/netdev/net-next/c/d70a0d8f2f2d - [net-next,v8,11/14] net: ethernet: oa_tc6: implement mac-phy interrupt https://git.kernel.org/netdev/net-next/c/2c6ce5354453 - [net-next,v8,12/14] net: ethernet: oa_tc6: add helper function to enable zero align rx frame https://git.kernel.org/netdev/net-next/c/afd42170c8a6 - [net-next,v8,13/14] microchip: lan865x: add driver support for Microchip's LAN865X MAC-PHY https://git.kernel.org/netdev/net-next/c/5cd2340cb6a3 - [net-next,v8,14/14] dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY https://git.kernel.org/netdev/net-next/c/ac49b950bea9 You are awesome, thank you!
This patch series contain the below updates, - Adds support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface in the net/ethernet/oa_tc6.c. Link to the spec: ----------------- https://opensig.org/download/document/OPEN_Alliance_10BASET1x_MAC-PHY_Serial_Interface_V1.1.pdf - Adds driver support for Microchip LAN8650/1 Rev.B1 10BASE-T1S MACPHY Ethernet driver in the net/ethernet/microchip/lan865x/lan865x.c. Link to the product: -------------------- https://www.microchip.com/en-us/product/lan8650 Testing Details: ---------------- The driver performance was tested using iperf3 in the below two setups separately. Setup 1: -------- Node 0 - Raspberry Pi 4 with LAN8650 MAC-PHY Node 1 - Raspberry Pi 4 with EVB-LAN8670-USB USB Stick Setup 2: -------- Node 0 - SAMA7G54-EK with LAN8650 MAC-PHY Node 1 - Raspberry Pi 4 with EVB-LAN8670-USB USB Stick Achieved maximum of 9.4 Mbps. Some systems like Raspberry Pi 4 need performance mode enabled to get the proper clock speed for SPI. Refer below link for more details. https://github.com/raspberrypi/linux/issues/3381#issuecomment-1144723750 Changes: v2: - Removed RFC tag. - OA TC6 framework configured in the Kconfig and Makefile to compile as a module. - Kerneldoc headers added for all the API methods exposed to MAC driver. - Odd parity calculation logic updated from the below link, https://elixir.bootlin.com/linux/latest/source/lib/bch.c#L348 - Control buffer memory allocation moved to the initial function. - struct oa_tc6 implemented as an obaque structure. - Removed kthread for handling mac-phy interrupt instead threaded irq is used. - Removed interrupt implementation for soft reset handling instead of that polling has been implemented. - Registers name in the defines changed according to the specification document. - Registers defines are arranged in the order of offset and followed by register fields. - oa_tc6_write_register() implemented for writing a single register and oa_tc6_write_registers() implemented for writing multiple registers. - oa_tc6_read_register() implemented for reading a single register and oa_tc6_read_registers() implemented for reading multiple registers. - Removed DRV_VERSION macro as git hash provided by ethtool. - Moved MDIO bus registration and PHY initialization to the OA TC6 lib. - Replaced lan865x_set/get_link_ksettings() functions with phy_ethtool_ksettings_set/get() functions. - MAC-PHY's standard capability register values checked against the user configured values. - Removed unnecessary parameters validity check in various places. - Removed MAC address configuration in the lan865x_net_open() function as it is done in the lan865x_probe() function already. - Moved standard registers and proprietary vendor registers to the respective files. - Added proper subject prefixes for the DT bindings. - Moved OA specific properties to a separate DT bindings and corrected the types & mistakes in the DT bindings. - Inherited OA specific DT bindings to the LAN865x specific DT bindings. - Removed sparse warnings in all the places. - Used net_err_ratelimited() for printing the error messages. - oa_tc6_process_rx_chunks() function and the content of oa_tc6_handler() function are split into small functions. - Used proper macros provided by network layer for calculating the MAX_ETH_LEN. - Return value of netif_rx() function handled properly. - Removed unnecessary NULL initialization of skb in the oa_tc6_rx_eth_ready() function removed. - Local variables declaration ordered in reverse xmas tree notation. v3: - Completely redesigned all the patches. - Control and data interface patches are divided into multiple small patches. - Device driver APIs added in the oa-tc6-framework.rst file. - Code readability improved in all the patches. - Defined macros wherever is possible. - Changed RESETC to STATUS0_RESETC for improving the readability. - Removed OA specific DT bindings. - Used default configurations defined in the OA spec. - All variables are named properly as per OA spec for more redability. - Bigger functions are split into multiple smaller functions. - DT binding check is done. - Phy mask is removed in phy scanning. - Used NET_RX_DROP to compare the rx packet submission status. - Indentation in the Kconfig file corrected. - Removed CONFIG_OF and CONFIG_ACPI ifdefs. - Removed MODULE_ALIAS(). v4: - Fixed indentation in oa-tc6-framework.rst file. - Replaced ENODEV error code with EPROTO in the oa_tc6_check_ctrl_write_reply and oa_tc6_check_ctrl_read_reply() functions. - Renamed oa_tc6_read_sw_reset_status() function as oa_tc6_read_status0(). - Changed software reset polling delay as 1ms and polling timeout as 1s. - Implemented clause 45 registers direct access. - Replaced ENODEV error code with ENOMEM in the oa_tc6_mdiobus_register() function. - Changed transmit skbs queue size as 2. - Added skb_linearize() function to convert contiguous packet data. - Checked kthread_should_stop() in the oa_tc6_spi_thread_handler() function before proceeding for the oa_tc6_try_spi_transfer(). - Removed netdev_err() print in the oa_tc6_allocate_rx_skb() function. - Added spi-peripheral-props reference in the dt-bindings. - Changed the fallback order in the dt-bindings. - Replaced netif_start_queue() with netif_wake_queue(). - Empty data transfer performed in the oa_tc6_init() function to clear the reset complete interrupt. - ZARFE bit in the CONFIG0 register is set to 1 to avoid lan865x halt based on the recommendation in the lan865x errata. v5: - Added base commit info in the cover letter. - Fixed all the warnings reported in the oa-tc6-framework.rst file. - Fixed kernel-doc reported warnings. - Fixed reverse christmas tree notation. - Printed error code in case STATUS0 register read is failed. - Removed C29 support in the PHY initialization. - Returned the same error code from the function instead of replacing with another error code. - Used netdev_alloc_skb_ip_align() to allocate receive skb buffer. - Enabling zero align receive frame feature moved to OA TC6 framework as a helper function for vendor specific drivers. - Replaced eth_hw_addr_set() with eth_commit_mac_addr_change() as it is a better pair for eth_prepare_mac_addr_change(). - Fixed device tree binding issues in the driver and documentation. - Fixed multicast addresses hash value calculation. v6: - Replaced "depends on" with "select" for selecting OA_TC6 library in the lan865x Kconfig file. - Fixed multicast address configuration. v7: - Removed tx skb queue handling and introduced two skb pointers to point waiting and ongoing tx skb's. - Removed netif_rx() return value check and rx drop statistics update as it is already handled in the dev_core_stats_rx_dropped_inc(skb->dev) function. - Removed lan865x_get_drvinfo() function as the core fills this basic info automatically. v8: - Removed unused #address-cells and #size-cells parameters description from microchip,lan8650.yaml file. Parthiban Veerasooran (14): Documentation: networking: add OPEN Alliance 10BASE-T1x MAC-PHY serial interface net: ethernet: oa_tc6: implement register write operation net: ethernet: oa_tc6: implement register read operation net: ethernet: oa_tc6: implement software reset net: ethernet: oa_tc6: implement error interrupts unmasking net: ethernet: oa_tc6: implement internal PHY initialization net: phy: microchip_t1s: add c45 direct access in LAN865x internal PHY net: ethernet: oa_tc6: enable open alliance tc6 data communication net: ethernet: oa_tc6: implement transmit path to transfer tx ethernet frames net: ethernet: oa_tc6: implement receive path to receive rx ethernet frames net: ethernet: oa_tc6: implement mac-phy interrupt net: ethernet: oa_tc6: add helper function to enable zero align rx frame microchip: lan865x: add driver support for Microchip's LAN865X MAC-PHY dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY .../bindings/net/microchip,lan8650.yaml | 74 + Documentation/networking/index.rst | 1 + Documentation/networking/oa-tc6-framework.rst | 497 ++++++ MAINTAINERS | 15 + drivers/net/ethernet/Kconfig | 11 + drivers/net/ethernet/Makefile | 1 + drivers/net/ethernet/microchip/Kconfig | 1 + drivers/net/ethernet/microchip/Makefile | 1 + .../net/ethernet/microchip/lan865x/Kconfig | 19 + .../net/ethernet/microchip/lan865x/Makefile | 6 + .../net/ethernet/microchip/lan865x/lan865x.c | 429 ++++++ drivers/net/ethernet/oa_tc6.c | 1361 +++++++++++++++++ drivers/net/phy/microchip_t1s.c | 30 + include/linux/oa_tc6.h | 24 + include/uapi/linux/mdio.h | 1 + 15 files changed, 2471 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/microchip,lan8650.yaml create mode 100644 Documentation/networking/oa-tc6-framework.rst create mode 100644 drivers/net/ethernet/microchip/lan865x/Kconfig create mode 100644 drivers/net/ethernet/microchip/lan865x/Makefile create mode 100644 drivers/net/ethernet/microchip/lan865x/lan865x.c create mode 100644 drivers/net/ethernet/oa_tc6.c create mode 100644 include/linux/oa_tc6.h base-commit: c259acab839e57eab0318f32da4ae803a8d59397