mbox series

[0/2] arm64: dts: rockchip: Add Hardkernel ODROID-M2

Message ID 20240901112020.3224704-1-jonas@kwiboo.se
Headers show
Series arm64: dts: rockchip: Add Hardkernel ODROID-M2 | expand

Message

Jonas Karlman Sept. 1, 2024, 11:20 a.m. UTC
This series add initial support for the Hardkernel ODROID-M2 board.

The Hardkernel ODROID-M2 is a single-board computer based on Rockchip
RK3588S2 SoC. It features e.g. 8/16 GB LPDDR5 RAM, 64 GB eMMC, SD-card,
GbE LAN, HDMI 2.0, M.2 NVMe and USB 2.0/3.0/Type-C.

Schematics for ODROID-M2 can be found at:
https://wiki.odroid.com/_media/odroid-m2/hardware/m2_main_rev1.0_240611.pdf

The device tree was created based on the schematics with regulator
voltage values adjusted to closer match vendor downstream device tree.

Testing was done booting into Linux using mainline U-Boot from [1],
a test build of mainline U-Boot for ODROID-M2 can be found at [2].

U-Boot patches will be sent once DT reach the devicetree-rebasing tree.

[1] https://github.com/Kwiboo/u-boot-rockchip/commits/rk3xxx-2024.10/
[2] https://github.com/Kwiboo/u-boot-build/actions/runs/10653436524

Jonas Karlman (2):
  dt-bindings: arm: rockchip: Add Hardkernel ODROID-M2
  arm64: dts: rockchip: Add Hardkernel ODROID-M2

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3588s-odroid-m2.dts   | 903 ++++++++++++++++++
 3 files changed, 909 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-odroid-m2.dts

Comments

Rob Herring Sept. 3, 2024, 2:26 p.m. UTC | #1
On Sun, 01 Sep 2024 11:20:13 +0000, Jonas Karlman wrote:
> This series add initial support for the Hardkernel ODROID-M2 board.
> 
> The Hardkernel ODROID-M2 is a single-board computer based on Rockchip
> RK3588S2 SoC. It features e.g. 8/16 GB LPDDR5 RAM, 64 GB eMMC, SD-card,
> GbE LAN, HDMI 2.0, M.2 NVMe and USB 2.0/3.0/Type-C.
> 
> Schematics for ODROID-M2 can be found at:
> https://wiki.odroid.com/_media/odroid-m2/hardware/m2_main_rev1.0_240611.pdf
> 
> The device tree was created based on the schematics with regulator
> voltage values adjusted to closer match vendor downstream device tree.
> 
> Testing was done booting into Linux using mainline U-Boot from [1],
> a test build of mainline U-Boot for ODROID-M2 can be found at [2].
> 
> U-Boot patches will be sent once DT reach the devicetree-rebasing tree.
> 
> [1] https://github.com/Kwiboo/u-boot-rockchip/commits/rk3xxx-2024.10/
> [2] https://github.com/Kwiboo/u-boot-build/actions/runs/10653436524
> 
> Jonas Karlman (2):
>   dt-bindings: arm: rockchip: Add Hardkernel ODROID-M2
>   arm64: dts: rockchip: Add Hardkernel ODROID-M2
> 
>  .../devicetree/bindings/arm/rockchip.yaml     |   5 +
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../boot/dts/rockchip/rk3588s-odroid-m2.dts   | 903 ++++++++++++++++++
>  3 files changed, 909 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-odroid-m2.dts
> 
> --
> 2.46.0
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y rockchip/rk3588s-odroid-m2.dtb' for 20240901112020.3224704-1-jonas@kwiboo.se:

arch/arm64/boot/dts/rockchip/rk3588s-odroid-m2.dtb: video-codec@fdb50000: compatible: 'oneOf' conditional failed, one must be fixed:
	['rockchip,rk3588-vpu121', 'rockchip,rk3568-vpu'] is too long
	'rockchip,rk3588-vpu121' is not one of ['rockchip,rk3036-vpu', 'rockchip,rk3066-vpu', 'rockchip,rk3288-vpu', 'rockchip,rk3328-vpu', 'rockchip,rk3399-vpu', 'rockchip,px30-vpu', 'rockchip,rk3568-vpu', 'rockchip,rk3588-av1-vpu']
	'rockchip,rk3188-vpu' was expected
	'rockchip,rk3228-vpu' was expected
	'rockchip,rk3066-vpu' was expected
	'rockchip,rk3399-vpu' was expected
	from schema $id: http://devicetree.org/schemas/media/rockchip-vpu.yaml#
arch/arm64/boot/dts/rockchip/rk3588s-odroid-m2.dtb: /video-codec@fdb50000: failed to match any schema with compatible: ['rockchip,rk3588-vpu121', 'rockchip,rk3568-vpu']
arch/arm64/boot/dts/rockchip/rk3588s-odroid-m2.dtb: /video-codec@fdba0000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
arch/arm64/boot/dts/rockchip/rk3588s-odroid-m2.dtb: /video-codec@fdba4000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
arch/arm64/boot/dts/rockchip/rk3588s-odroid-m2.dtb: /video-codec@fdba8000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
arch/arm64/boot/dts/rockchip/rk3588s-odroid-m2.dtb: /video-codec@fdbac000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
Heiko Stübner Sept. 4, 2024, 7:07 p.m. UTC | #2
On Sun, 1 Sep 2024 11:20:13 +0000, Jonas Karlman wrote:
> This series add initial support for the Hardkernel ODROID-M2 board.
> 
> The Hardkernel ODROID-M2 is a single-board computer based on Rockchip
> RK3588S2 SoC. It features e.g. 8/16 GB LPDDR5 RAM, 64 GB eMMC, SD-card,
> GbE LAN, HDMI 2.0, M.2 NVMe and USB 2.0/3.0/Type-C.
> 
> Schematics for ODROID-M2 can be found at:
> https://wiki.odroid.com/_media/odroid-m2/hardware/m2_main_rev1.0_240611.pdf
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: arm: rockchip: Add Hardkernel ODROID-M2
      commit: f1f348158813f64cd772d6ff4a3df0704285c14c
[2/2] arm64: dts: rockchip: Add Hardkernel ODROID-M2
      commit: ce48b8c976ce439c336def6e06bf8224a8ff9125

Best regards,