| Message ID | 20240826044530.726458-1-bigfoot@classfun.cn |
|---|---|
| Headers | show |
| Series | Add support for LCKFB Taishan Pi RK3566 | expand |
On Mon, Aug 26, 2024 at 12:44:13PM +0800, Junhao Xie wrote: > Add dts for LCKFB Taishan Pi. > > Working IO: > * UART > * RGB LED > * AP6212 WiFi > * AP6212 Bluetooth > * SD Card > * eMMC > * HDMI > * Mali GPU > * USB Type-C > * USB Type-A > > Signed-off-by: Junhao Xie <bigfoot@classfun.cn> > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../boot/dts/rockchip/rk3566-lckfb-tspi.dts | 743 ++++++++++++++++++ > 2 files changed, 744 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-lckfb-tspi.dts ... > + dc_12v: dc-12v { Use some reasonable prefix or suffix (regulator) for all regulator nodes. Or even: use name for all fixed regulators which matches current format recommendation: 'regulator-[0-9]v[0-9]' https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46 > + compatible = "regulator-fixed"; > + regulator-name = "dc_12v"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <12000000>; > + regulator-max-microvolt = <12000000>; > + }; > + > + vcc3v3_sys: vcc3v3-sys { > + compatible = "regulator-fixed"; > + regulator-name = "vcc3v3_sys"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vcc5v0_sys>; > + }; > + > + vcc5v0_sys: vcc5v0-sys { > + compatible = "regulator-fixed"; > + regulator-name = "vcc5v0_sys"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + vin-supply = <&dc_12v>; > + }; > + > + vcc5v0_host: vcc5v0-host-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vcc5v0_host"; > + regulator-boot-on; > + regulator-always-on; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + enable-active-high; > + gpio = <&gpio4 RK_PC4 GPIO_ACTIVE_HIGH>; > + vin-supply = <&vcc5v0_sys>; > + pinctrl-names = "default"; > + pinctrl-0 = <&vcc5v0_host_en>; > + }; > + > + vccio_flash: vccio-flash { > + compatible = "regulator-fixed"; > + regulator-name = "vccio_flash"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vcc_1v8>; > + }; > + > + vccio_wl: vccio-wl { > + compatible = "regulator-fixed"; > + regulator-name = "vccio_wl"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vcc_3v3>; > + }; > +}; > + > +&combphy1 { > + status = "okay"; > +}; > + > +&combphy2 { > + status = "okay"; > +}; > + > +&cpu0 { > + cpu-supply = <&vdd_cpu>; > +}; > + > +&cpu1 { > + cpu-supply = <&vdd_cpu>; > +}; > + > +&cpu2 { > + cpu-supply = <&vdd_cpu>; > +}; > + > +&cpu3 { > + cpu-supply = <&vdd_cpu>; > +}; > + > +&gpu { > + mali-supply = <&vdd_gpu>; > + status = "okay"; > +}; > + > +&hdmi { > + avdd-0v9-supply = <&vdda0v9_image>; > + avdd-1v8-supply = <&vcca1v8_image>; > + status = "okay"; > +}; > + > +&hdmi_in { > + hdmi_in_vp0: endpoint { > + remote-endpoint = <&vp0_out_hdmi>; > + }; > +}; > + > +&hdmi_out { > + hdmi_out_con: endpoint { > + remote-endpoint = <&hdmi_con_in>; > + }; > +}; > + > +&hdmi_sound { > + status = "okay"; > +}; > + > +&i2c0 { > + status = "okay"; > + > + vdd_cpu: regulator@1c { > + compatible = "tcs,tcs4525"; > + reg = <0x1c>; > + fcs,suspend-voltage-selector = <1>; > + regulator-name = "vdd_cpu"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <1150000>; > + regulator-ramp-delay = <2300>; > + vin-supply = <&vcc5v0_sys>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + rk809: pmic@20 { > + compatible = "rockchip,rk809"; > + reg = <0x20>; > + > + interrupt-parent = <&gpio0>; > + interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>; > + > + #clock-cells = <1>; > + clock-output-names = "rk808-clkout1", "rk808-clkout2"; > + clock-names = "mclk"; > + clocks = <&cru I2S1_MCLKOUT_TX>; > + assigned-clocks = <&cru I2S1_MCLKOUT_TX>; > + assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>; > + > + #sound-dai-cells = <0>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pmic_int>, <&i2s1m0_mclk>; > + rockchip,system-power-controller; > + wakeup-source; > + > + vcc1-supply = <&vcc3v3_sys>; > + vcc2-supply = <&vcc3v3_sys>; > + vcc3-supply = <&vcc3v3_sys>; > + vcc4-supply = <&vcc3v3_sys>; > + vcc5-supply = <&vcc3v3_sys>; > + vcc6-supply = <&vcc3v3_sys>; > + vcc7-supply = <&vcc3v3_sys>; > + vcc8-supply = <&vcc3v3_sys>; > + vcc9-supply = <&vcc3v3_sys>; > + > + regulators { > + vdd_logic: DCDC_REG1 { > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1350000>; > + regulator-ramp-delay = <6001>; > + regulator-initial-mode = <0x2>; > + regulator-name = "vdd_logic"; > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + vdd_gpu: DCDC_REG2 { > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1350000>; > + regulator-ramp-delay = <6001>; > + regulator-initial-mode = <0x2>; > + regulator-name = "vdd_gpu"; > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + vcc_ddr: DCDC_REG3 { > + regulator-always-on; > + regulator-boot-on; > + regulator-initial-mode = <0x2>; > + regulator-name = "vcc_ddr"; > + regulator-state-mem { > + regulator-on-in-suspend; > + }; > + }; > + > + vdd_npu: DCDC_REG4 { > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1350000>; > + regulator-ramp-delay = <6001>; > + regulator-initial-mode = <0x2>; > + regulator-name = "vdd_npu"; > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + vdda0v9_image: LDO_REG1 { > + regulator-boot-on; > + regulator-always-on; > + regulator-min-microvolt = <900000>; > + regulator-max-microvolt = <900000>; > + regulator-name = "vdda0v9_image"; > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + vdda_0v9: LDO_REG2 { > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <900000>; > + regulator-max-microvolt = <900000>; > + regulator-name = "vdda_0v9"; > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + vdda0v9_pmu: LDO_REG3 { > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <900000>; > + regulator-max-microvolt = <900000>; > + regulator-name = "vdda0v9_pmu"; > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <900000>; > + }; > + }; > + > + vccio_acodec: LDO_REG4 { > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vccio_acodec"; > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + vccio_sd: LDO_REG5 { > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vccio_sd"; > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + vcc3v3_pmu: LDO_REG6 { > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vcc3v3_pmu"; > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <3300000>; > + }; > + }; > + > + vcca_1v8: LDO_REG7 { > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-name = "vcca_1v8"; > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + vcca1v8_pmu: LDO_REG8 { > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-name = "vcca1v8_pmu"; > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-suspend-microvolt = <1800000>; > + }; > + }; > + > + vcca1v8_image: LDO_REG9 { > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-name = "vcca1v8_image"; > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + vcc_1v8: DCDC_REG5 { > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-name = "vcc_1v8"; > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + vcc_3v3: SWITCH_REG1 { > + regulator-always-on; > + regulator-boot-on; > + regulator-name = "vcc_3v3"; > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + vcc3v3_sd: SWITCH_REG2 { > + regulator-always-on; > + regulator-boot-on; > + regulator-name = "vcc3v3_sd"; > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + }; > + > + codec { > + rockchip,mic-in-differential; > + }; > + }; > +}; > + > +&i2c1 { > + status = "okay"; > + /* Touch Screen */ > +}; > + > +&i2c4 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c4m0_xfer>; > + status = "okay"; > + /* Camera */ > +}; > + > +&i2s0_8ch { > + status = "okay"; > + /* HDMI */ > +}; > + > +&i2s1_8ch { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2s1m0_sclktx &i2s1m0_lrcktx &i2s1m0_sdi0 &i2s1m0_sdo0>; > + rockchip,trcm-sync-tx-only; > + status = "okay"; > + /* PMIC */ > +}; > + > +&i2s2_2ch { > + rockchip,trcm-sync-tx-only; > + status = "okay"; > + /* AP6212 Bluetooth */ > +}; > + > +&pinctrl { > + bt { > + bt_enable_h: bt-enable-h { > + rockchip,pins = <2 RK_PB7 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + > + bt_host_wake_l: bt-host-wake-l { > + rockchip,pins = <2 RK_PC0 RK_FUNC_GPIO &pcfg_pull_down>; > + }; > + > + bt_wake_l: bt-wake-l { > + rockchip,pins = <2 RK_PC1 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > + > + sdio-pwrseq { > + wifi_enable_h: wifi-enable-h { > + rockchip,pins = <2 RK_PB1 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + > + wifi_host_wake_h: wifi-host-wake-l { > + rockchip,pins = <2 RK_PB2 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > + > + hp-detect { > + hp_det: hp-det { > + rockchip,pins = <4 RK_PC6 RK_FUNC_GPIO &pcfg_pull_up>; > + }; > + }; > + > + pmic { > + pmic_int: pmic_int { > + rockchip,pins = <0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_up>; > + }; > + > + soc_slppin_gpio: soc_slppin_gpio { > + rockchip,pins = <0 RK_PA2 RK_FUNC_GPIO &pcfg_output_low>; > + }; > + > + soc_slppin_slp: soc_slppin_slp { > + rockchip,pins = <0 RK_PA2 1 &pcfg_pull_up>; > + }; > + > + soc_slppin_rst: soc_slppin_rst { > + rockchip,pins = <0 RK_PA2 2 &pcfg_pull_none>; > + }; > + }; > + > + usb2 { > + vcc5v0_host_en: vcc5v0-host-en { > + rockchip,pins = <4 RK_PC4 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > +}; > + > +&pmu_io_domains { > + pmuio1-supply = <&vcc3v3_pmu>; > + pmuio2-supply = <&vcc3v3_pmu>; > + vccio1-supply = <&vccio_acodec>; > + vccio2-supply = <&vccio_flash>; > + vccio3-supply = <&vccio_sd>; > + vccio4-supply = <&vccio_wl>; > + vccio5-supply = <&vcc_3v3>; > + vccio6-supply = <&vcc_1v8>; > + vccio7-supply = <&vcc_3v3>; > + status = "okay"; > +}; > + > +&pmugrf { > + reboot-mode { > + compatible = "syscon-reboot-mode"; > + offset = <0x200>; > + mode-normal = <BOOT_NORMAL>; > + mode-loader = <BOOT_BL_DOWNLOAD>; > + mode-recovery = <BOOT_RECOVERY>; > + mode-bootloader = <BOOT_FASTBOOT>; > + }; > +}; > + > +&saradc { > + vref-supply = <&vcca_1v8>; > + status = "okay"; > + /* Channel 0: Recovery Button */ > + /* Channel 1: Hardware ID */ > +}; > + > +&sdhci { > + bus-width = <8>; > + max-frequency = <200000000>; > + non-removable; > + pinctrl-names = "default"; > + pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe &emmc_rstnout>; > + status = "okay"; Keep status the last. Best regards, Krzysztof
On 2024/8/26 14:06, Krzysztof Kozlowski wrote: > On Mon, Aug 26, 2024 at 12:44:13PM +0800, Junhao Xie wrote: >> Add dts for LCKFB Taishan Pi. >> [...] > >> + dc_12v: dc-12v { > > Use some reasonable prefix or suffix (regulator) for all regulator > nodes. Or even: use name for all fixed regulators which matches current > format recommendation: 'regulator-[0-9]v[0-9]' > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46 > Thanks, I will rename it to dc-12v-regulator [...] >> + >> +&sdhci { >> + bus-width = <8>; >> + max-frequency = <200000000>; >> + non-removable; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe &emmc_rstnout>; >> + status = "okay"; > > Keep status the last. > > Best regards, > Krzysztof > > Thanks for your review, I will fix all problems and post patch v2!
On 26/08/2024 09:46, Junhao Xie wrote: > On 2024/8/26 14:06, Krzysztof Kozlowski wrote: >> On Mon, Aug 26, 2024 at 12:44:13PM +0800, Junhao Xie wrote: >>> Add dts for LCKFB Taishan Pi. >>> > > [...] > >> >>> + dc_12v: dc-12v { >> >> Use some reasonable prefix or suffix (regulator) for all regulator >> nodes. Or even: use name for all fixed regulators which matches current >> format recommendation: 'regulator-[0-9]v[0-9]' >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46 >> > > Thanks, I will rename it to dc-12v-regulator Well, this makes ordering tricky and is not the proposed policy, but sure... I gave you reference hoping you will read it. Best regards, Krzysztof
On 2024/8/26 16:08, Krzysztof Kozlowski wrote: > On 26/08/2024 09:46, Junhao Xie wrote: >> On 2024/8/26 14:06, Krzysztof Kozlowski wrote: >>> On Mon, Aug 26, 2024 at 12:44:13PM +0800, Junhao Xie wrote: >>>> Add dts for LCKFB Taishan Pi. >>>> >> >> [...] >> >>> >>>> + dc_12v: dc-12v { >>> >>> Use some reasonable prefix or suffix (regulator) for all regulator >>> nodes. Or even: use name for all fixed regulators which matches current >>> format recommendation: 'regulator-[0-9]v[0-9]' >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46 >>> >> >> Thanks, I will rename it to dc-12v-regulator > > Well, this makes ordering tricky and is not the proposed policy, but > sure... I gave you reference hoping you will read it. > > Best regards, > Krzysztof > > Oh, sorry, it should be renamed to 'regulator-12v0-dcin', as this name complies more with the policy. Thank you for the reminder!
On Mon, 26 Aug 2024 12:44:10 +0800, Junhao Xie wrote: > LCKFB Taishan Pi is a SBC based on the RK3566 SoC. > > This series bring support for: > * UART > * RGB LED > * AP6212 WiFi > * AP6212 Bluetooth > * SD Card > * eMMC > * HDMI > * Mali GPU > * USB Type-C > * USB Type-A > > [...] Applied, thanks! [1/3] dt-bindings: vendor-prefixes: Add Shenzhen JLC Technology Group LCKFB commit: d6ec4fefbe9eac0363e9d05c05010686d6790428 [2/3] dt-bindings: arm: rockchip: Add LCKFB Taishan Pi RK3566 commit: 4d4b28ba3a0f84f641febc9de4252ba0bad2238d Patch 3/3 was sent as a v2 separately in https://lore.kernel.org/linux-rockchip/20240826110300.735350-1-bigfoot@classfun.cn/T/#u Best regards,
LCKFB Taishan Pi is a SBC based on the RK3566 SoC. This series bring support for: * UART * RGB LED * AP6212 WiFi * AP6212 Bluetooth * SD Card * eMMC * HDMI * Mali GPU * USB Type-C * USB Type-A Signed-off-by: Junhao Xie <bigfoot@classfun.cn> --- Junhao Xie (3): dt-bindings: vendor-prefixes: Add Shenzhen JLC Technology Group LCKFB dt-bindings: arm: rockchip: Add LCKFB Taishan Pi RK3566 arm64: dts: rockchip: add dts for LCKFB Taishan Pi RK3566 .../devicetree/bindings/arm/rockchip.yaml | 5 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3566-lckfb-tspi.dts | 743 ++++++++++++++++++ 4 files changed, 751 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-lckfb-tspi.dts