| Message ID | 20240820101216.355012-1-arend.vanspriel@broadcom.com |
|---|---|
| Headers | show |
| Series | dt-bindings fixup for brcm,bcm4329-fmac.yaml | expand |
On Tue, Aug 20, 2024 at 12:12:16PM +0200, Arend van Spriel wrote: > Align with the corrected device tree bindings in brcm,bcm4329-fmac.yaml > which imposes a constraint that the compatible should have the string > "brcm,bcm4329-fmac". Additionally, please explain why do you think these devices are compatible and also how this change affects working. Considering that previously these devices were not matched by brcmf_of_probe() and now they will, this is significant change. > > Fixes: e2e37224e8b3 ("dt-bindings: net: bcm4329-fmac: Add Apple properties & chips") No, no bug to fix. Previous code was intentional. If you claim there is a bug, please explain what exactly is being fixed. > Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com> Best regards, Krzysztof
Fix to restore the constraint in the json-schema that was lost when support for the Apple PCIe devices was added in e2e37224e8b3 ("dt-bindings: net: bcm4329-fmac: Add Apple properties & chips"). Not sure if the rule of separate patches is the easiest to get this fixed. If one patch is preferred I can respin. The patches are based on main branch of the wireless-next repository. Regards, Arend Arend van Spriel (2): dt-bindings: wireless: restore constraint for brcm,bcm4329-fmac compatible property arm64: boot: apple: fixup wifi device specification .../net/wireless/brcm,bcm4329-fmac.yaml | 19 ++++++++++--------- arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 2 +- arch/arm64/boot/dts/apple/t8112-j413.dts | 2 +- arch/arm64/boot/dts/apple/t8112-j493.dts | 2 +- 4 files changed, 13 insertions(+), 12 deletions(-) base-commit: daaf0dd0398d5e93b7304f35184ca182ed583681 -- 2.32.0