| Message ID | 20240624050254.2942959-1-quic_varada@quicinc.com |
|---|---|
| Headers | show |
| Series | Enable CPR for IPQ9574 | expand |
On Mon, Jun 24, 2024 at 10:32:50AM GMT, Varadarajan Narayanan wrote: > Add the APC power domain definitions used in IPQ9574. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> Given that Praveenkumar was the original author, why isn't that reflected using the From: header? Please review your process and keep the original authorship properly attributed. > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > v2: Fix Signed-off-by order > --- > drivers/pmdomain/qcom/rpmpd.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) >
On Mon, Jun 24, 2024 at 10:32:52AM GMT, Varadarajan Narayanan wrote: > Add the CPR clock definition needed for enabling access to > CPR register space. > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > v2: Add rbcpr_clk_src to gcc_ipq9574_hws for registration. > --- > drivers/clk/qcom/gcc-ipq9574.c | 39 ++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Mon, Jun 24, 2024 at 10:32:53AM GMT, Varadarajan Narayanan wrote: > Add thread, scaling factor, CPR descriptor defines to enable CPR > on IPQ9574. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > v2: Fix Signed-off-by order > Depends: > [1] https://lore.kernel.org/lkml/20230217-topic-cpr3h-v14-0-9fd23241493d@linaro.org/T/ > [2] https://github.com/quic-varada/cpr/commits/konrad/ This should be a part of the cover letter, not the patch itself. And it looks like From: is missing here too. > --- > drivers/pmdomain/qcom/cpr3.c | 137 +++++++++++++++++++++++++++++++++++ > 1 file changed, 137 insertions(+)
On Mon, Jun 24, 2024 at 10:32:47AM GMT, Varadarajan Narayanan wrote: > This series tries to enable CPR on IPQ9574, that implements > CPRv4. Since [1] is older, faced few minor issues. Those are > addressed in [2]. > > dt_binding_check and dtbs_check passed. > > Depends: > [1] https://lore.kernel.org/lkml/20230217-topic-cpr3h-v14-0-9fd23241493d@linaro.org/T/ > [2] https://github.com/quic-varada/cpr/commits/konrad/ Please include [2] into your patchset. > > v2: Fix Signed-off-by order in 2 patches > Update constraints in qcom,cpr3.yaml > Add rbcpr_clk_src registration > Add Reviewed-by to one of the patches > Not adding Acked-by as the file has changed > > Varadarajan Narayanan (7): > dt-bindings: power: rpmpd: Add IPQ9574 power domains > dt-bindings: soc: qcom: cpr3: Add bindings for IPQ9574 > pmdomain: qcom: rpmpd: Add IPQ9574 power domains > dt-bindings: clock: Add CPR clock defines for IPQ9574 > clk: qcom: gcc-ipq9574: Add CPR clock definition > soc: qcom: cpr3: Add IPQ9574 definitions > dts: arm64: qcom: ipq9574: Enable CPR > > .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 + > .../bindings/soc/qcom/qcom,cpr3.yaml | 35 +++ > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 269 ++++++++++++++++-- > drivers/clk/qcom/gcc-ipq9574.c | 39 +++ > drivers/pmdomain/qcom/cpr3.c | 137 +++++++++ > drivers/pmdomain/qcom/rpmpd.c | 19 ++ > include/dt-bindings/clock/qcom,ipq9574-gcc.h | 2 + > include/dt-bindings/power/qcom-rpmpd.h | 3 + > 8 files changed, 488 insertions(+), 17 deletions(-) > > -- > 2.34.1 >
On Mon, Jun 24, 2024 at 08:39:55AM +0300, Dmitry Baryshkov wrote: > On Mon, Jun 24, 2024 at 10:32:47AM GMT, Varadarajan Narayanan wrote: > > This series tries to enable CPR on IPQ9574, that implements > > CPRv4. Since [1] is older, faced few minor issues. Those are > > addressed in [2]. > > > > dt_binding_check and dtbs_check passed. > > > > Depends: > > [1] https://lore.kernel.org/lkml/20230217-topic-cpr3h-v14-0-9fd23241493d@linaro.org/T/ > > [2] https://github.com/quic-varada/cpr/commits/konrad/ > > Please include [2] into your patchset. Did not include them because Konrad has agreed to post them this week. And, I don't have an MSM8998 target to test those changes. Thanks Varada > > > > v2: Fix Signed-off-by order in 2 patches > > Update constraints in qcom,cpr3.yaml > > Add rbcpr_clk_src registration > > Add Reviewed-by to one of the patches > > Not adding Acked-by as the file has changed > > > > Varadarajan Narayanan (7): > > dt-bindings: power: rpmpd: Add IPQ9574 power domains > > dt-bindings: soc: qcom: cpr3: Add bindings for IPQ9574 > > pmdomain: qcom: rpmpd: Add IPQ9574 power domains > > dt-bindings: clock: Add CPR clock defines for IPQ9574 > > clk: qcom: gcc-ipq9574: Add CPR clock definition > > soc: qcom: cpr3: Add IPQ9574 definitions > > dts: arm64: qcom: ipq9574: Enable CPR > > > > .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 + > > .../bindings/soc/qcom/qcom,cpr3.yaml | 35 +++ > > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 269 ++++++++++++++++-- > > drivers/clk/qcom/gcc-ipq9574.c | 39 +++ > > drivers/pmdomain/qcom/cpr3.c | 137 +++++++++ > > drivers/pmdomain/qcom/rpmpd.c | 19 ++ > > include/dt-bindings/clock/qcom,ipq9574-gcc.h | 2 + > > include/dt-bindings/power/qcom-rpmpd.h | 3 + > > 8 files changed, 488 insertions(+), 17 deletions(-) > > > > -- > > 2.34.1 > > > > -- > With best wishes > Dmitry
On Mon, Jun 24, 2024 at 12:20:13PM GMT, Varadarajan Narayanan wrote: > On Mon, Jun 24, 2024 at 08:39:55AM +0300, Dmitry Baryshkov wrote: > > On Mon, Jun 24, 2024 at 10:32:47AM GMT, Varadarajan Narayanan wrote: > > > This series tries to enable CPR on IPQ9574, that implements > > > CPRv4. Since [1] is older, faced few minor issues. Those are > > > addressed in [2]. > > > > > > dt_binding_check and dtbs_check passed. > > > > > > Depends: > > > [1] https://lore.kernel.org/lkml/20230217-topic-cpr3h-v14-0-9fd23241493d@linaro.org/T/ > > > [2] https://github.com/quic-varada/cpr/commits/konrad/ > > > > Please include [2] into your patchset. > > Did not include them because Konrad has agreed to post them this week. > And, I don't have an MSM8998 target to test those changes. At least CPRh-related patches should have been included, so that we could review and comment them.
On Mon, Jun 24, 2024 at 11:02:35AM +0300, Dmitry Baryshkov wrote: > On Mon, Jun 24, 2024 at 12:20:13PM GMT, Varadarajan Narayanan wrote: > > On Mon, Jun 24, 2024 at 08:39:55AM +0300, Dmitry Baryshkov wrote: > > > On Mon, Jun 24, 2024 at 10:32:47AM GMT, Varadarajan Narayanan wrote: > > > > This series tries to enable CPR on IPQ9574, that implements > > > > CPRv4. Since [1] is older, faced few minor issues. Those are > > > > addressed in [2]. > > > > > > > > dt_binding_check and dtbs_check passed. > > > > > > > > Depends: > > > > [1] https://lore.kernel.org/lkml/20230217-topic-cpr3h-v14-0-9fd23241493d@linaro.org/T/ > > > > [2] https://github.com/quic-varada/cpr/commits/konrad/ > > > > > > Please include [2] into your patchset. > > > > Did not include them because Konrad has agreed to post them this week. > > And, I don't have an MSM8998 target to test those changes. > > At least CPRh-related patches should have been included, so that we > could review and comment them. Have posted v3 including the patches that I had added on top of Konrad's changes (skipped 2 of them as they are rebase of Konrad's patches to top of tree linux-next), and addressed other review comments too. Please review. Thanks Varada
This series tries to enable CPR on IPQ9574, that implements CPRv4. Since [1] is older, faced few minor issues. Those are addressed in [2]. dt_binding_check and dtbs_check passed. Depends: [1] https://lore.kernel.org/lkml/20230217-topic-cpr3h-v14-0-9fd23241493d@linaro.org/T/ [2] https://github.com/quic-varada/cpr/commits/konrad/ v2: Fix Signed-off-by order in 2 patches Update constraints in qcom,cpr3.yaml Add rbcpr_clk_src registration Add Reviewed-by to one of the patches Not adding Acked-by as the file has changed Varadarajan Narayanan (7): dt-bindings: power: rpmpd: Add IPQ9574 power domains dt-bindings: soc: qcom: cpr3: Add bindings for IPQ9574 pmdomain: qcom: rpmpd: Add IPQ9574 power domains dt-bindings: clock: Add CPR clock defines for IPQ9574 clk: qcom: gcc-ipq9574: Add CPR clock definition soc: qcom: cpr3: Add IPQ9574 definitions dts: arm64: qcom: ipq9574: Enable CPR .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 + .../bindings/soc/qcom/qcom,cpr3.yaml | 35 +++ arch/arm64/boot/dts/qcom/ipq9574.dtsi | 269 ++++++++++++++++-- drivers/clk/qcom/gcc-ipq9574.c | 39 +++ drivers/pmdomain/qcom/cpr3.c | 137 +++++++++ drivers/pmdomain/qcom/rpmpd.c | 19 ++ include/dt-bindings/clock/qcom,ipq9574-gcc.h | 2 + include/dt-bindings/power/qcom-rpmpd.h | 3 + 8 files changed, 488 insertions(+), 17 deletions(-)