| Message ID | 20240423-for-soc-asus-rt-ac3200-ac5300-v3-0-23d33cfafe7a@arinc9.com |
|---|---|
| Headers | show |
| Series | Document ASUS RT-AC3200 and ASUS RT-AC5300 and add device trees | expand |
On Tue, Apr 23, 2024 at 11:51 AM Arınç ÜNAL via B4 Relay <devnull+arinc.unal.arinc9.com@kernel.org> wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > Add the device tree for ASUS RT-AC3200 which is an AC3200 router featuring > 5 Ethernet ports over the integrated Broadcom switch. > > Hardware info: > * Processor: Broadcom BCM4709A0 dual-core @ 1.0 GHz > * Switch: BCM53012 in BCM4709A0 > * DDR3 RAM: 256 MB > * Flash: 128 MB > * 2.4GHz: BCM43602 3x3 single chip 802.11b/g/n SoC > * 5GHz: BCM43602 3x3 two chips 802.11a/n/ac SoC > * Ports: 4 LAN Ports, 1 WAN Port > > Co-developed-by: Tom Brautaset <tbrautaset@gmail.com> > Signed-off-by: Tom Brautaset <tbrautaset@gmail.com> > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> Looks similar to others I've seen so: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Tue, Apr 23, 2024 at 11:51 AM Arınç ÜNAL via B4 Relay <devnull+arinc.unal.arinc9.com@kernel.org> wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > Add the device tree for ASUS RT-AC5300 which is an AC5300 router featuring > 5 Ethernet ports over the integrated Broadcom switch. > > Hardware info: > * Processor: Broadcom BCM4709C0 dual-core @ 1.4 GHz > * Switch: BCM53012 in BCM4709C0 > * DDR3 RAM: 512 MB > * Flash: 128 MB > * 2.4GHz: BCM4366 4x4 single chip 802.11b/g/n SoC > * 5GHz: BCM4366 4x4 two chips 802.11a/n/ac SoC > * Ports: 4 LAN Ports, 1 WAN Port > > Co-developed-by: Tom Brautaset <tbrautaset@gmail.com> > Signed-off-by: Tom Brautaset <tbrautaset@gmail.com> > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Tue, Apr 23, 2024 at 11:51 AM Arınç ÜNAL via B4 Relay <devnull+arinc.unal.arinc9.com@kernel.org> wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > Reorder the nodes and properties to conform to the Devicetree Sources (DTS) > Coding Style. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
On Tue, Apr 23, 2024 at 11:51 AM Arınç ÜNAL via B4 Relay <devnull+arinc.unal.arinc9.com@kernel.org> wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > Reorder the nodes and properties to conform to the Devicetree Sources (DTS) > Coding Style. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Tue, 23 Apr 2024 12:50:44 +0300, Arınç ÜNAL wrote: > Hello. > > This patch series documents the compatible strings for ASUS RT-AC3200 and > ASUS RT-AC5300, and adds the device trees for them. The last patch makes > the device tree files for ASUS RT-AC3100 and ASUS RT-AC88U conform to the > Devicetree Sources (DTS) Coding Style. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > Changes in v3: > - Add a new patch to the end. > - Patch 3 > - Reorder the nodes and properties to conform to the Devicetree Sources > (DTS) Coding Style. > - Patch 4 > - Same as above. > - Link to v2: https://lore.kernel.org/r/20240419-for-soc-asus-rt-ac3200-ac5300-v2-0-f95ff50c2a4d@arinc9.com > > Changes in v2: > - Patch 3 > - Remove the chosen node as earlycon is not for mainline use, and the > stdout-path property which should be used instead of bootargs = > "console=" is already described in bcm4708.dtsi with the same value. > - Remove MAC address assignment to switch ports. To explain why shortly, > on the switch with CPU port architecture, the LLC Entity associated > with each port can be accessed without a distinct MAC address assigned > to each port. Therefore, it is unnecessary. > - Patch 4 > - Same as above. > - Link to v1: https://lore.kernel.org/r/20240414-for-soc-asus-rt-ac3200-ac5300-v1-0-118c90bae6e5@arinc9.com > > --- > Arınç ÜNAL (5): > dt-bindings: arm: bcm: add bindings for ASUS RT-AC3200 > dt-bindings: arm: bcm: add bindings for ASUS RT-AC5300 > ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200 > ARM: dts: BCM5301X: Add DT for ASUS RT-AC5300 > ARM: dts: BCM5301X: Conform to DTS Coding Style on ASUS RT-AC3100 & AC88U > > .../devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 2 + > arch/arm/boot/dts/broadcom/Makefile | 2 + > .../boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts | 150 ++++++++++++++++++++ > .../boot/dts/broadcom/bcm47094-asus-rt-ac3100.dtsi | 92 ++++++------ > .../boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts | 156 +++++++++++++++++++++ > .../boot/dts/broadcom/bcm47094-asus-rt-ac88u.dts | 69 +++++---- > 6 files changed, 390 insertions(+), 81 deletions(-) > --- > base-commit: dd5c56cd065e6f7ac5f87b939e8a3c499a62d463 > change-id: 20240408-for-soc-asus-rt-ac3200-ac5300-5d6efc2c497b > > Best regards, > -- > Arınç ÜNAL <arinc.unal@arinc9.com> > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y broadcom/bcm4709-asus-rt-ac3200.dtb broadcom/bcm47094-asus-rt-ac5300.dtb broadcom/bcm47094-asus-rt-ac88u.dtb' for 20240423-for-soc-asus-rt-ac3200-ac5300-v3-0-23d33cfafe7a@arinc9.com: arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: /axi@18000000: failed to match any schema with compatible: ['brcm,bus-axi'] arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: /axi@18000000: failed to match any schema with compatible: ['brcm,bus-axi'] arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: pcie@12000: 'device_type' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: pcie@12000: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: pcie@13000: 'device_type' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: pcie@13000: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: pcie@12000: 'device_type' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: pcie@12000: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: pcie@14000: 'device_type' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: pcie@14000: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: pcie@13000: 'device_type' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: pcie@13000: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: pcie@14000: 'device_type' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: pcie@14000: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: ethernet-switch@18007000: ports:port@5: 'phy-mode' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: ethernet-switch@18007000: ports:port@5: 'oneOf' conditional failed, one must be fixed: 'fixed-link' is a required property 'phy-handle' is a required property 'managed' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: ethernet-switch@18007000: ports:port@7: 'phy-mode' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: ethernet-switch@18007000: ports:port@7: 'oneOf' conditional failed, one must be fixed: 'fixed-link' is a required property 'phy-handle' is a required property 'managed' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: ethernet-switch@18007000: ports:port@8: 'phy-mode' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: ethernet-switch@18007000: Unevaluated properties are not allowed ('ports' was unexpected) from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: ethernet-switch@18007000: ports:port@5: 'phy-mode' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: ethernet-switch@18007000: ports:port@5: 'oneOf' conditional failed, one must be fixed: 'fixed-link' is a required property 'phy-handle' is a required property 'managed' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: ethernet-switch@18007000: ports:port@7: 'phy-mode' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: ethernet-switch@18007000: ports:port@7: 'oneOf' conditional failed, one must be fixed: 'fixed-link' is a required property 'phy-handle' is a required property 'managed' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: ethernet-switch@18007000: ports:port@8: 'phy-mode' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: ethernet-switch@18007000: Unevaluated properties are not allowed ('ports' was unexpected) from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#
From: Florian Fainelli <f.fainelli@gmail.com> On Tue, 23 Apr 2024 12:50:47 +0300, Arınç ÜNAL via B4 Relay <devnull+arinc.unal.arinc9.com@kernel.org> wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > Add the device tree for ASUS RT-AC3200 which is an AC3200 router featuring > 5 Ethernet ports over the integrated Broadcom switch. > > Hardware info: > * Processor: Broadcom BCM4709A0 dual-core @ 1.0 GHz > * Switch: BCM53012 in BCM4709A0 > * DDR3 RAM: 256 MB > * Flash: 128 MB > * 2.4GHz: BCM43602 3x3 single chip 802.11b/g/n SoC > * 5GHz: BCM43602 3x3 two chips 802.11a/n/ac SoC > * Ports: 4 LAN Ports, 1 WAN Port > > Co-developed-by: Tom Brautaset <tbrautaset@gmail.com> > Signed-off-by: Tom Brautaset <tbrautaset@gmail.com> > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! -- Florian
From: Florian Fainelli <f.fainelli@gmail.com> On Tue, 23 Apr 2024 12:50:48 +0300, Arınç ÜNAL via B4 Relay <devnull+arinc.unal.arinc9.com@kernel.org> wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > Add the device tree for ASUS RT-AC5300 which is an AC5300 router featuring > 5 Ethernet ports over the integrated Broadcom switch. > > Hardware info: > * Processor: Broadcom BCM4709C0 dual-core @ 1.4 GHz > * Switch: BCM53012 in BCM4709C0 > * DDR3 RAM: 512 MB > * Flash: 128 MB > * 2.4GHz: BCM4366 4x4 single chip 802.11b/g/n SoC > * 5GHz: BCM4366 4x4 two chips 802.11a/n/ac SoC > * Ports: 4 LAN Ports, 1 WAN Port > > Co-developed-by: Tom Brautaset <tbrautaset@gmail.com> > Signed-off-by: Tom Brautaset <tbrautaset@gmail.com> > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! -- Florian
From: Florian Fainelli <f.fainelli@gmail.com> On Tue, 23 Apr 2024 12:50:49 +0300, Arınç ÜNAL via B4 Relay <devnull+arinc.unal.arinc9.com@kernel.org> wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > Reorder the nodes and properties to conform to the Devicetree Sources (DTS) > Coding Style. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! -- Florian
Hello. This patch series documents the compatible strings for ASUS RT-AC3200 and ASUS RT-AC5300, and adds the device trees for them. The last patch makes the device tree files for ASUS RT-AC3100 and ASUS RT-AC88U conform to the Devicetree Sources (DTS) Coding Style. Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- Changes in v3: - Add a new patch to the end. - Patch 3 - Reorder the nodes and properties to conform to the Devicetree Sources (DTS) Coding Style. - Patch 4 - Same as above. - Link to v2: https://lore.kernel.org/r/20240419-for-soc-asus-rt-ac3200-ac5300-v2-0-f95ff50c2a4d@arinc9.com Changes in v2: - Patch 3 - Remove the chosen node as earlycon is not for mainline use, and the stdout-path property which should be used instead of bootargs = "console=" is already described in bcm4708.dtsi with the same value. - Remove MAC address assignment to switch ports. To explain why shortly, on the switch with CPU port architecture, the LLC Entity associated with each port can be accessed without a distinct MAC address assigned to each port. Therefore, it is unnecessary. - Patch 4 - Same as above. - Link to v1: https://lore.kernel.org/r/20240414-for-soc-asus-rt-ac3200-ac5300-v1-0-118c90bae6e5@arinc9.com --- Arınç ÜNAL (5): dt-bindings: arm: bcm: add bindings for ASUS RT-AC3200 dt-bindings: arm: bcm: add bindings for ASUS RT-AC5300 ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200 ARM: dts: BCM5301X: Add DT for ASUS RT-AC5300 ARM: dts: BCM5301X: Conform to DTS Coding Style on ASUS RT-AC3100 & AC88U .../devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 2 + arch/arm/boot/dts/broadcom/Makefile | 2 + .../boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts | 150 ++++++++++++++++++++ .../boot/dts/broadcom/bcm47094-asus-rt-ac3100.dtsi | 92 ++++++------ .../boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts | 156 +++++++++++++++++++++ .../boot/dts/broadcom/bcm47094-asus-rt-ac88u.dts | 69 +++++---- 6 files changed, 390 insertions(+), 81 deletions(-) --- base-commit: dd5c56cd065e6f7ac5f87b939e8a3c499a62d463 change-id: 20240408-for-soc-asus-rt-ac3200-ac5300-5d6efc2c497b Best regards,