| Message ID | 20240419-for-soc-asus-rt-ac3200-ac5300-v2-0-f95ff50c2a4d@arinc9.com |
|---|---|
| Headers | show |
| Series | Document ASUS RT-AC3200 and ASUS RT-AC5300 and add device trees | expand |
On Fri, 19 Apr 2024 10:22:47 +0300, Arınç ÜNAL wrote: > Hello. > > This patch series documents the compatible strings for ASUS RT-AC3200 and > ASUS RT-AC5300, and adds the device trees for them. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > Changes in v2: > - Patch 3 > - Remove the chosen node as earlycon is not for mainline use, and the > stdout-path property which should be used instead of bootargs = > "console=" is already described in bcm4708.dtsi with the same value. > - Remove MAC address assignment to switch ports. To explain why shortly, > on the switch with CPU port architecture, the LLC Entity associated > with each port can be accessed without a distinct MAC address assigned > to each port. Therefore, it is unnecessary. > - Patch 4 > - Same as above. > - Link to v1: https://lore.kernel.org/r/20240414-for-soc-asus-rt-ac3200-ac5300-v1-0-118c90bae6e5@arinc9.com > > --- > Arınç ÜNAL (4): > dt-bindings: arm: bcm: add bindings for ASUS RT-AC3200 > dt-bindings: arm: bcm: add bindings for ASUS RT-AC5300 > ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200 > ARM: dts: BCM5301X: Add DT for ASUS RT-AC5300 > > .../devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 2 + > arch/arm/boot/dts/broadcom/Makefile | 2 + > .../boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts | 150 ++++++++++++++++++++ > .../boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts | 156 +++++++++++++++++++++ > 4 files changed, 310 insertions(+) > --- > base-commit: 011d79ef1cfad701c2d8e7e80d8c77523af9c771 > change-id: 20240408-for-soc-asus-rt-ac3200-ac5300-5d6efc2c497b > > Best regards, > -- > Arınç ÜNAL <arinc.unal@arinc9.com> > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y broadcom/bcm4709-asus-rt-ac3200.dtb broadcom/bcm47094-asus-rt-ac5300.dtb' for 20240419-for-soc-asus-rt-ac3200-ac5300-v2-0-f95ff50c2a4d@arinc9.com: arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: /axi@18000000: failed to match any schema with compatible: ['brcm,bus-axi'] arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: pcie@12000: 'device_type' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: pcie@12000: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: pcie@13000: 'device_type' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: pcie@13000: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: pcie@14000: 'device_type' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: pcie@14000: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: /axi@18000000: failed to match any schema with compatible: ['brcm,bus-axi'] arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: pcie@12000: 'device_type' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: pcie@12000: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: pcie@13000: 'device_type' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: pcie@13000: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: pcie@14000: 'device_type' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: pcie@14000: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: ethernet-switch@18007000: ports:port@5: 'phy-mode' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: ethernet-switch@18007000: ports:port@5: 'oneOf' conditional failed, one must be fixed: 'fixed-link' is a required property 'phy-handle' is a required property 'managed' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: ethernet-switch@18007000: ports:port@7: 'phy-mode' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: ethernet-switch@18007000: ports:port@7: 'oneOf' conditional failed, one must be fixed: 'fixed-link' is a required property 'phy-handle' is a required property 'managed' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: ethernet-switch@18007000: ports:port@8: 'phy-mode' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac3200.dtb: ethernet-switch@18007000: Unevaluated properties are not allowed ('ports' was unexpected) from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: ethernet-switch@18007000: ports:port@5: 'phy-mode' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: ethernet-switch@18007000: ports:port@5: 'oneOf' conditional failed, one must be fixed: 'fixed-link' is a required property 'phy-handle' is a required property 'managed' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: ethernet-switch@18007000: ports:port@7: 'phy-mode' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: ethernet-switch@18007000: ports:port@7: 'oneOf' conditional failed, one must be fixed: 'fixed-link' is a required property 'phy-handle' is a required property 'managed' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: ethernet-switch@18007000: ports:port@8: 'phy-mode' is a required property from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml# arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dtb: ethernet-switch@18007000: Unevaluated properties are not allowed ('ports' was unexpected) from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml#
Hi, On 19.04.2024 09:22, Arınç ÜNAL via B4 Relay wrote: > This patch series documents the compatible strings for ASUS RT-AC3200 and > ASUS RT-AC5300, and adds the device trees for them. I was on holidays and couldn't reply earlier. This patchset looks good to me, thanks for your work! Bot warnings come from .dtsi so they are not directly caused by your changes. Nitpicking: Try to put "reg" before "device_type" in future. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst?h=v6.8#n112 > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > Changes in v2: > - Patch 3 > - Remove the chosen node as earlycon is not for mainline use, and the > stdout-path property which should be used instead of bootargs = > "console=" is already described in bcm4708.dtsi with the same value. > - Remove MAC address assignment to switch ports. To explain why shortly, > on the switch with CPU port architecture, the LLC Entity associated > with each port can be accessed without a distinct MAC address assigned > to each port. Therefore, it is unnecessary. > - Patch 4 > - Same as above. > - Link to v1: https://lore.kernel.org/r/20240414-for-soc-asus-rt-ac3200-ac5300-v1-0-118c90bae6e5@arinc9.com > > --- > Arınç ÜNAL (4): > dt-bindings: arm: bcm: add bindings for ASUS RT-AC3200 > dt-bindings: arm: bcm: add bindings for ASUS RT-AC5300 > ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200 > ARM: dts: BCM5301X: Add DT for ASUS RT-AC5300 > > .../devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 2 + > arch/arm/boot/dts/broadcom/Makefile | 2 + > .../boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts | 150 ++++++++++++++++++++ > .../boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts | 156 +++++++++++++++++++++ > 4 files changed, 310 insertions(+) > --- > base-commit: 011d79ef1cfad701c2d8e7e80d8c77523af9c771 > change-id: 20240408-for-soc-asus-rt-ac3200-ac5300-5d6efc2c497b > > Best regards,
On 23/04/2024 09:24, Rafał Miłecki wrote: > Hi, > > On 19.04.2024 09:22, Arınç ÜNAL via B4 Relay wrote: >> This patch series documents the compatible strings for ASUS RT-AC3200 and >> ASUS RT-AC5300, and adds the device trees for them. > > I was on holidays and couldn't reply earlier. > > This patchset looks good to me, thanks for your work! > > Bot warnings come from .dtsi so they are not directly caused by your changes. > > Nitpicking: > Try to put "reg" before "device_type" in future. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst?h=v6.8#n112 I'll address this in v3, thank you. Arınç
Hello. This patch series documents the compatible strings for ASUS RT-AC3200 and ASUS RT-AC5300, and adds the device trees for them. Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- Changes in v2: - Patch 3 - Remove the chosen node as earlycon is not for mainline use, and the stdout-path property which should be used instead of bootargs = "console=" is already described in bcm4708.dtsi with the same value. - Remove MAC address assignment to switch ports. To explain why shortly, on the switch with CPU port architecture, the LLC Entity associated with each port can be accessed without a distinct MAC address assigned to each port. Therefore, it is unnecessary. - Patch 4 - Same as above. - Link to v1: https://lore.kernel.org/r/20240414-for-soc-asus-rt-ac3200-ac5300-v1-0-118c90bae6e5@arinc9.com --- Arınç ÜNAL (4): dt-bindings: arm: bcm: add bindings for ASUS RT-AC3200 dt-bindings: arm: bcm: add bindings for ASUS RT-AC5300 ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200 ARM: dts: BCM5301X: Add DT for ASUS RT-AC5300 .../devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 2 + arch/arm/boot/dts/broadcom/Makefile | 2 + .../boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts | 150 ++++++++++++++++++++ .../boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts | 156 +++++++++++++++++++++ 4 files changed, 310 insertions(+) --- base-commit: 011d79ef1cfad701c2d8e7e80d8c77523af9c771 change-id: 20240408-for-soc-asus-rt-ac3200-ac5300-5d6efc2c497b Best regards,