mbox series

[0/7] Enable eQEP DT support for Sitara K3 platforms

Message ID 20240418221417.1592787-1-jm@ti.com
Headers show
Series Enable eQEP DT support for Sitara K3 platforms | expand

Message

Judith Mendez April 18, 2024, 10:14 p.m. UTC
This patch series adds eQEP DT nodes for K3 Sitara devices:
- AM62x
- AM62ax
- AM62px
- AM64x

Also enable eQEP to be built as a module for ARCH_k3.

Judith Mendez (7):
  arm64: dts: ti: k3-am62-main: Add eQEP nodes
  arm64: dts: ti: k3-am62a-main: Add eQEP nodes
  arm64: dts: ti: k3-am62p-main: Add eQEP nodes
  arm64: dts: ti: k3-am64-main: Add eQEP nodes
  dt-bindings: counter: Update TI eQEP binding
  counter: ti-eqep: Allow eQEP driver to be built for K3 devices
  arm64: defconfig: Enable TI eQEP Driver

 .../devicetree/bindings/counter/ti-eqep.yaml  | 10 +++++--
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi      | 30 +++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi     | 30 +++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-am62p-main.dtsi     | 30 +++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-am64-main.dtsi      | 30 +++++++++++++++++++
 arch/arm64/configs/defconfig                  |  1 +
 drivers/counter/Kconfig                       |  2 +-
 7 files changed, 129 insertions(+), 4 deletions(-)


base-commit: 534ad093bb80f19c20b251a89f09ce1a0e3d4f2d

Comments

Krzysztof Kozlowski April 19, 2024, 1:56 p.m. UTC | #1
On 19/04/2024 00:14, Judith Mendez wrote:
> Add eQEP DT nodes 0-2 for AM625 SoC.
> 
> Since external hardware was needed to test eQEP, the DT nodes
> for eQEP were not included in the introductory commit. Now that
> eQEP has been validated, add nodes to k3-am62-main.dtsi.
> 
> Fixes: f1d17330a5be ("arm64: dts: ti: Introduce base support for AM62x SoC")
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 30 ++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index e9cffca073efc..0877899b90667 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -844,6 +844,36 @@ ecap2: pwm@23120000 {
>  		status = "disabled";
>  	};
>  
> +	eqep0: counter@23200000 {
> +		compatible = "ti,am3352-eqep";

That's k3-am62, not am3352. See writing-bindings (and numerous
presentations telling you how to do it, e.g. from two previous EOSS/ELCE).

Best regards,
Krzysztof
Judith Mendez April 22, 2024, 10:07 p.m. UTC | #2
Hi,

On 4/19/24 8:56 AM, Krzysztof Kozlowski wrote:
> On 19/04/2024 00:14, Judith Mendez wrote:
>> Add eQEP DT nodes 0-2 for AM625 SoC.
>>
>> Since external hardware was needed to test eQEP, the DT nodes
>> for eQEP were not included in the introductory commit. Now that
>> eQEP has been validated, add nodes to k3-am62-main.dtsi.
>>
>> Fixes: f1d17330a5be ("arm64: dts: ti: Introduce base support for AM62x SoC")
>> Signed-off-by: Judith Mendez <jm@ti.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 30 ++++++++++++++++++++++++
>>   1 file changed, 30 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> index e9cffca073efc..0877899b90667 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> @@ -844,6 +844,36 @@ ecap2: pwm@23120000 {
>>   		status = "disabled";
>>   	};
>>   
>> +	eqep0: counter@23200000 {
>> +		compatible = "ti,am3352-eqep";
> 
> That's k3-am62, not am3352. See writing-bindings (and numerous
> presentations telling you how to do it, e.g. from two previous EOSS/ELCE).
> 

Thanks, will fix and send v2.

~ Judith

> Best regards,
> Krzysztof
>