mbox series

[0/3] Split sony-castor into shinano-common and add Sony Xperia Z3

Message ID 20240310-shinano-common-v1-0-d64cd322ebca@z3ntu.xyz
Headers show
Series Split sony-castor into shinano-common and add Sony Xperia Z3 | expand

Message

Luca Weiss March 10, 2024, 11:41 a.m. UTC
Prepare for adding sony-leo dts by splitting common parts into a
separate dtsi file.

Then add the dts for Sony Xperia Z3.

Depends on:
https://lore.kernel.org/linux-arm-msm/20240306-castor-changes-v1-0-2286eaf85fff@z3ntu.xyz/T/

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
Luca Weiss (3):
      ARM: dts: qcom: msm8974-sony-castor: Split into shinano-common
      dt-bindings: arm: qcom: Add Sony Xperia Z3
      ARM: dts: qcom: Add Sony Xperia Z3 smartphone

 Documentation/devicetree/bindings/arm/qcom.yaml    |   1 +
 .../qcom-msm8974pro-sony-xperia-shinano-castor.dts | 541 +--------------------
 ...qcom-msm8974pro-sony-xperia-shinano-common.dtsi | 535 ++++++++++++++++++++
 .../qcom-msm8974pro-sony-xperia-shinano-leo.dts    |  44 ++
 4 files changed, 591 insertions(+), 530 deletions(-)
---
base-commit: bee52eeb37d8124a07711657d1650bf3b467e7dd
change-id: 20240310-shinano-common-093fe25fe3a1

Best regards,

Comments

Luca Weiss March 10, 2024, 11:52 a.m. UTC | #1
On Sonntag, 10. März 2024 12:41:09 CET Luca Weiss wrote:
> Add the dts for the Xperia Z3 smartphone which is based on Sony's
> shinano platform, so at the moment there's little device-specific dts to
> add on top of the common parts.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>  .../qcom-msm8974pro-sony-xperia-shinano-leo.dts    | 44 +++++++++++++++++++
+++
>  1 file changed, 44 insertions(+)

Of course I forgot to add the dtb to the Makefile...

Apparently "make qcom/qcom-msm8974pro-sony-xperia-shinano-leo.dtb" doesn't 
care about whether the dtb is in the Makefile so I didn't notice.

Will fix in v2 but I'm going to wait for any comments on this or the other 
patches for at least a day or so.

Regards
Luca

> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-
leo.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-leo.dts
> new file mode 100644
> index 000000000000..1ed6e1cc21d5
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-sony-xperia-shinano-leo.dts
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include "qcom-msm8974pro-sony-xperia-shinano-common.dtsi"
> +
> +/ {
> +	model = "Sony Xperia Z3";
> +	compatible = "sony,xperia-leo", "qcom,msm8974pro", "qcom,msm8974";
> +	chassis-type = "handset";
> +
> +	gpio-keys {
> +		key-camera-snapshot {
> +			label = "camera_snapshot";
> +			gpios = <&pm8941_gpios 3 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_CAMERA>;
> +			debounce-interval = <15>;
> +		};
> +
> +		key-camera-focus {
> +			label = "camera_focus";
> +			gpios = <&pm8941_gpios 4 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_CAMERA_FOCUS>;
> +			debounce-interval = <15>;
> +		};
> +	};
> +};
> +
> +&gpio_keys_pin_a {
> +	pins = "gpio2", "gpio3", "gpio4", "gpio5";
> +};
> +
> +&smbb {
> +	usb-charge-current-limit = <1500000>;
> +	qcom,fast-charge-safe-current = <3000000>;
> +	qcom,fast-charge-current-limit = <2150000>;
> +	qcom,fast-charge-safe-voltage = <4400000>;
> +	qcom,fast-charge-high-threshold-voltage = <4350000>;
> +	qcom,auto-recharge-threshold-voltage = <4280000>;
> +	qcom,minimum-input-voltage = <4200000>;
> +
> +	status = "okay";
> +};
> +
> +&synaptics_touchscreen {
> +	vio-supply = <&pm8941_s3>;
> +};
> 
>
Konrad Dybcio March 12, 2024, 2:53 p.m. UTC | #2
On 3/10/24 12:41, Luca Weiss wrote:
> Add the dts for the Xperia Z3 smartphone which is based on Sony's
> shinano platform, so at the moment there's little device-specific dts to
> add on top of the common parts.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---

modulo missing makfile, this looks good
Konrad Dybcio March 12, 2024, 6:45 p.m. UTC | #3
On 3/10/24 12:41, Luca Weiss wrote:
> In preparation for adding the Sony Xperia Z3 smartphone, split the
> common parts into shinano-common.dtsi.
> 
> No functional change intended.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---

I give you the green light to also add newlines between subsequent
subnodes (e.g. under blsp2_i2c5) while at it ;)

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad