Message ID | 20240210-msm8974-rpmpd-v1-0-de9355e6842a@z3ntu.xyz |
---|---|
Headers | show |
Series | Add RPMPD support for MSM8974 | expand |
On 2/10/24 15:12, Luca Weiss wrote: > Add the power domains CX & GFX found on devices with MSM8974 and PM8841. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- [...] > +static struct rpmpd gfx_s4b_corner_ao; > +static struct rpmpd gfx_s4b_corner = { > + .pd = { .name = "gfx", }, > + .peer = &gfx_s4b_corner_ao, > + .res_type = RPMPD_SMPB, > + .res_id = 4, > + .key = KEY_CORNER, > +}; > + > +static struct rpmpd gfx_s4b_corner_ao = { > + .pd = { .name = "gfx_ao", }, > + .peer = &gfx_s4b_corner, > + .active_only = true, > + .res_type = RPMPD_SMPB, > + .res_id = 4, > + .key = KEY_CORNER, > +}; I don't see a s4b_ao downstream.. Though it's very unfortunate we didn't choose to add power-domain-cells or sth and set the bucket through that.. Konrad
On 2/10/24 15:12, Luca Weiss wrote: > Add the power domains CX & GFX found on MSM8974 devices that use PMA8084 > instead of the standard PM8841+PM8941 combo. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- Same comment as p2, gfx_ao may not make much sense on this platform Konrad
On Samstag, 10. Februar 2024 15:19:54 CET Konrad Dybcio wrote: > On 2/10/24 15:12, Luca Weiss wrote: > > Add the power domains CX & GFX found on devices with MSM8974 and PM8841. > > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > --- > > [...] > > > +static struct rpmpd gfx_s4b_corner_ao; > > +static struct rpmpd gfx_s4b_corner = { > > + .pd = { .name = "gfx", }, > > + .peer = &gfx_s4b_corner_ao, > > + .res_type = RPMPD_SMPB, > > + .res_id = 4, > > + .key = KEY_CORNER, > > +}; > > + > > +static struct rpmpd gfx_s4b_corner_ao = { > > + .pd = { .name = "gfx_ao", }, > > + .peer = &gfx_s4b_corner, > > + .active_only = true, > > + .res_type = RPMPD_SMPB, > > + .res_id = 4, > > + .key = KEY_CORNER, > > +}; > > I don't see a s4b_ao downstream.. Though it's very unfortunate we > didn't choose to add power-domain-cells or sth and set the bucket > through that.. Right, overlooked that. Will drop gfx_ao for both this and the other patch. Regards Luca > > Konrad
Add driver support for the RPM power domains found on the different MSM8974 devices. Devicetree integration will come at a later point since also some mostly remoteproc drivers need to be adjusted. Also the MX power domains on this SoC seems to work quite a bit differently, we'd need to send raw voltages to it, so these are ignored in this series. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- Luca Weiss (3): dt-bindings: power: rpmpd: Add MSM8974 power domains pmdomain: qcom: rpmpd: Add MSM8974+PM8841 power domains pmdomain: qcom: rpmpd: Add MSM8974PRO+PMA8084 power domains .../devicetree/bindings/power/qcom,rpmpd.yaml | 2 + drivers/pmdomain/qcom/rpmpd.c | 107 +++++++++++++++++++++ include/dt-bindings/power/qcom-rpmpd.h | 8 ++ 3 files changed, 117 insertions(+) --- base-commit: 6e3fa474051f3d276ea708bdb8e8e1f66d1d3ee5 change-id: 20240210-msm8974-rpmpd-6e48fe374275 Best regards,