mbox series

[v6,0/8] Convert DA906{1,2} bindings to json-schema

Message ID 20231214080911.23359-1-biju.das.jz@bp.renesas.com
Headers show
Series Convert DA906{1,2} bindings to json-schema | expand

Message

Biju Das Dec. 14, 2023, 8:09 a.m. UTC 
Convert the below bindings to json-schema
1) DA906{1,2} mfd bindings
2) DA906{1,2,3} onkey bindings
3) DA906{1,2,3} thermal bindings

Also add fallback for DA9061 watchdog device and document
DA9063 watchdog device.

Document missing gpio child node for da9062 and update MAINTAINERS entries.

Merge strategy:
Since there is binding dependency between input, thermal, watchdog and MFD
subsystem. it is decided that this series will go through the MFD tree.
So once the respective subsystem maintainers, DT and Renesas are happy
with the patch they can give an ack/rb tag, so that it can be applied to
MFD tree.

Note:

This patch series is same as v3.1 as it allows the tools (PW, b4)
to compare against previous versions.

The review comments/tags received for v4 + (a.k.a v3.1) will be
addressed in the next version(v5).

Link to v3.1: https://lore.kernel.org/all/20231204172510.35041-1-biju.das.jz@bp.renesas.com/

v5->v6:
 * Added Rb tag from Guenter Roeck for watchdog binding patches.
 * Updated commit description related to "gpio-controller" and
   "#gpio-cells" properties defined in parent node.
 * Added Rb tag from Krzysztof Kozlowski for patch#8.
v4->v5:
 * Updated cover letter with merging strategy.
 * Added fixes tag for patch#1
 * Added Rb tags from Geert and Krzysztof for patch#1
 * Added Ack from Conor for patch#1
 * Added Rb tag from Geert and Ack from Conor for patch#2
 * Drop items and just use enum as it is easier to read for compatibles.
 * Retained the tags for patch#2 as it is trivial change.
 * Added Rb tag from Geert for patch#3
 * Updated commit header and description by replacing
   'watchdog property'->'watchdog child node'
 * Added Rb tag from Geert for patch#4.
 * Added Rb tag from Krzysztof and Conor for patch#5
 * Dropped Items, Just enum as it is easier to read compatibles.
 * Retained tags for patch#5 as the changes are trivial.
 * Updated commit description for patch#8
 * Dropped unnecessary ref from gpio child node.
 * Added gpio-hog pattern property
 * Moved gpio-controller,gpio-cells above child nodes
 * Sorted compatible in rtc child node.
 * Dropped status from example.
 * Updated the example.
v3->v4:
 * Patch#1 is merge of patch#1 from v2 + patch#8 from v2.
 * Dropped comment for d9061 watchdog fallback
 * Replaced enum->const for dlg,da9061-watchdog and its fallback.
 * Restored patch#4 in series 1 and dropped the thermal example
 * Added Ack from Conor Dooley for da9063 watchdog binding support.
 * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063.
 * Retained Rb tag since the changes are trivial.
 * Added Ack from Conor for updating watchdog property
 * Dropped link to product information.
 * Patch#5(onkey) is squashed with patch#6 and patch#9 from v2.
 * Replaced enum->const for dlg,da9061-onkey and its fallback.
 * Dropped example
 * Restored the thermal binding patch from v2.
 * Dropped example
 * Replaced enum->const for compatible property.
 * Added Rb tag from Rob and retained Rb tag as changes are trivial.
 * Added Ack from Conor Dooley for patch#7.
 * Split the thermal binding patch separate
 * Updated the description
v2->v3:
 * Updated Maintainer entries for watchdog,onkey and thermal bindings
 * Fixed bot errors related to MAINTAINERS entry, invalid doc
   references and thermal examples by merging patch#4. 

v1->v2:
 Link: https://lore.kernel.org/all/20231201110840.37408-5-biju.das.jz@bp.renesas.com/
 * DA9062 and DA9061 merged with DA9063
 * Sorted the child devices
 * mfd,onkey and thermal are pointing to child bindings

Biju Das (8):
  dt-bindings: mfd: da9062: Update watchdog description
  dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061
    watchdog
  dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog
  dt-bindings: mfd: dlg,da9063: Update watchdog child node
  dt-bindings: input: Convert da906{1,2,3} onkey to json-schema
  dt-bindings: thermal: Convert da906{1,2} thermal to json-schema
  dt-bindings: mfd: dlg,da9063: Sort child devices
  dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema

 .../bindings/input/da9062-onkey.txt           |  47 ----
 .../bindings/input/dlg,da9062-onkey.yaml      |  38 +++
 .../devicetree/bindings/mfd/da9062.txt        | 124 ---------
 .../devicetree/bindings/mfd/dlg,da9063.yaml   | 248 +++++++++++++++---
 .../bindings/thermal/da9062-thermal.txt       |  36 ---
 .../bindings/thermal/dlg,da9062-thermal.yaml  |  35 +++
 .../watchdog/dlg,da9062-watchdog.yaml         |  12 +-
 MAINTAINERS                                   |   6 +-
 8 files changed, 298 insertions(+), 248 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/input/da9062-onkey.txt
 create mode 100644 Documentation/devicetree/bindings/input/dlg,da9062-onkey.yaml
 delete mode 100644 Documentation/devicetree/bindings/mfd/da9062.txt
 delete mode 100644 Documentation/devicetree/bindings/thermal/da9062-thermal.txt
 create mode 100644 Documentation/devicetree/bindings/thermal/dlg,da9062-thermal.yaml

Comments

Lee Jones Dec. 21, 2023, 2:15 p.m. UTC | #1 
On Thu, 14 Dec 2023 08:09:03 +0000, Biju Das wrote:
> Convert the below bindings to json-schema
> 1) DA906{1,2} mfd bindings
> 2) DA906{1,2,3} onkey bindings
> 3) DA906{1,2,3} thermal bindings
> 
> Also add fallback for DA9061 watchdog device and document
> DA9063 watchdog device.
> 
> [...]

Applied, thanks!

[1/8] dt-bindings: mfd: da9062: Update watchdog description
      commit: 9e7b13b805bcbe5335c2936d4c7ea0323ac69a81
[2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog
      commit: 28d34db7772f18490b52328f04a3bf69ed5390d2
[3/8] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog
      commit: d2a7dbb808870c17cffa2749ea877f61f298d098
[4/8] dt-bindings: mfd: dlg,da9063: Update watchdog child node
      commit: d4018547a15a94c7e865b2cef82bff1cd43a32b3
[5/8] dt-bindings: input: Convert da906{1,2,3} onkey to json-schema
      commit: db459d3da7bb9c37cb86897c7b321a49f8e40968
[6/8] dt-bindings: thermal: Convert da906{1,2} thermal to json-schema
      commit: 998f499c843e360bcd9ee1fe9addc3b5d32f1234
[7/8] dt-bindings: mfd: dlg,da9063: Sort child devices
      commit: 2bbf9d2a8e3bc933703dfda87cac953bed458496
[8/8] dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema
      commit: 522225161830f6a93f2aaabda99226c1ffddc8c4

--
Lee Jones [李琼斯]
Lee Jones Dec. 21, 2023, 2:33 p.m. UTC | #2 
On Thu, 21 Dec 2023, Lee Jones wrote:

> On Thu, 14 Dec 2023 08:09:03 +0000, Biju Das wrote:
> > Convert the below bindings to json-schema
> > 1) DA906{1,2} mfd bindings
> > 2) DA906{1,2,3} onkey bindings
> > 3) DA906{1,2,3} thermal bindings
> > 
> > Also add fallback for DA9061 watchdog device and document
> > DA9063 watchdog device.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/8] dt-bindings: mfd: da9062: Update watchdog description
>       commit: 9e7b13b805bcbe5335c2936d4c7ea0323ac69a81
> [2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog
>       commit: 28d34db7772f18490b52328f04a3bf69ed5390d2
> [3/8] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog
>       commit: d2a7dbb808870c17cffa2749ea877f61f298d098
> [4/8] dt-bindings: mfd: dlg,da9063: Update watchdog child node
>       commit: d4018547a15a94c7e865b2cef82bff1cd43a32b3
> [5/8] dt-bindings: input: Convert da906{1,2,3} onkey to json-schema
>       commit: db459d3da7bb9c37cb86897c7b321a49f8e40968
> [6/8] dt-bindings: thermal: Convert da906{1,2} thermal to json-schema
>       commit: 998f499c843e360bcd9ee1fe9addc3b5d32f1234
> [7/8] dt-bindings: mfd: dlg,da9063: Sort child devices
>       commit: 2bbf9d2a8e3bc933703dfda87cac953bed458496
> [8/8] dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema
>       commit: 522225161830f6a93f2aaabda99226c1ffddc8c4

Submitted for testing.  Pull-request to follow.
Biju Das Jan. 29, 2024, 8:29 a.m. UTC | #3 
Hi Lee Jones,

> -----Original Message-----
> From: Lee Jones <lee@kernel.org>
> Sent: Thursday, December 21, 2023 2:33 PM
> Subject: Re: [PATCH v6 0/8] Convert DA906{1,2} bindings to json-schema
> 
> On Thu, 21 Dec 2023, Lee Jones wrote:
> 
> > On Thu, 14 Dec 2023 08:09:03 +0000, Biju Das wrote:
> > > Convert the below bindings to json-schema
> > > 1) DA906{1,2} mfd bindings
> > > 2) DA906{1,2,3} onkey bindings
> > > 3) DA906{1,2,3} thermal bindings
> > >
> > > Also add fallback for DA9061 watchdog device and document
> > > DA9063 watchdog device.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/8] dt-bindings: mfd: da9062: Update watchdog description
> >       commit: 9e7b13b805bcbe5335c2936d4c7ea0323ac69a81
> > [2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for
> DA9061 watchdog
> >       commit: 28d34db7772f18490b52328f04a3bf69ed5390d2
> > [3/8] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063
> watchdog
> >       commit: d2a7dbb808870c17cffa2749ea877f61f298d098
> > [4/8] dt-bindings: mfd: dlg,da9063: Update watchdog child node
> >       commit: d4018547a15a94c7e865b2cef82bff1cd43a32b3
> > [5/8] dt-bindings: input: Convert da906{1,2,3} onkey to json-schema
> >       commit: db459d3da7bb9c37cb86897c7b321a49f8e40968
> > [6/8] dt-bindings: thermal: Convert da906{1,2} thermal to json-schema
> >       commit: 998f499c843e360bcd9ee1fe9addc3b5d32f1234
> > [7/8] dt-bindings: mfd: dlg,da9063: Sort child devices
> >       commit: 2bbf9d2a8e3bc933703dfda87cac953bed458496
> > [8/8] dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema
> >       commit: 522225161830f6a93f2aaabda99226c1ffddc8c4
> 
> Submitted for testing.  Pull-request to follow.

The commit dc805ea058c0e ("MAINTAINERS: rectify entry for DIALOG SEMICONDUCTOR DRIVERS")
in mainline will give a conflict for patch#1.

Patch#2 and patch#3 are already in mainline.


Please let me know if you want me to rebase and resend the patch series

Or 

you will take care the MAINTAINERS conflict while applying.

Cheers,
Biju
Lee Jones Jan. 31, 2024, 8:49 a.m. UTC | #4 
On Mon, 29 Jan 2024, Biju Das wrote:

> Hi Lee Jones,
> 
> > -----Original Message-----
> > From: Lee Jones <lee@kernel.org>
> > Sent: Thursday, December 21, 2023 2:33 PM
> > Subject: Re: [PATCH v6 0/8] Convert DA906{1,2} bindings to json-schema
> > 
> > On Thu, 21 Dec 2023, Lee Jones wrote:
> > 
> > > On Thu, 14 Dec 2023 08:09:03 +0000, Biju Das wrote:
> > > > Convert the below bindings to json-schema
> > > > 1) DA906{1,2} mfd bindings
> > > > 2) DA906{1,2,3} onkey bindings
> > > > 3) DA906{1,2,3} thermal bindings
> > > >
> > > > Also add fallback for DA9061 watchdog device and document
> > > > DA9063 watchdog device.
> > > >
> > > > [...]
> > >
> > > Applied, thanks!
> > >
> > > [1/8] dt-bindings: mfd: da9062: Update watchdog description
> > >       commit: 9e7b13b805bcbe5335c2936d4c7ea0323ac69a81
> > > [2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for
> > DA9061 watchdog
> > >       commit: 28d34db7772f18490b52328f04a3bf69ed5390d2
> > > [3/8] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063
> > watchdog
> > >       commit: d2a7dbb808870c17cffa2749ea877f61f298d098
> > > [4/8] dt-bindings: mfd: dlg,da9063: Update watchdog child node
> > >       commit: d4018547a15a94c7e865b2cef82bff1cd43a32b3
> > > [5/8] dt-bindings: input: Convert da906{1,2,3} onkey to json-schema
> > >       commit: db459d3da7bb9c37cb86897c7b321a49f8e40968
> > > [6/8] dt-bindings: thermal: Convert da906{1,2} thermal to json-schema
> > >       commit: 998f499c843e360bcd9ee1fe9addc3b5d32f1234
> > > [7/8] dt-bindings: mfd: dlg,da9063: Sort child devices
> > >       commit: 2bbf9d2a8e3bc933703dfda87cac953bed458496
> > > [8/8] dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema
> > >       commit: 522225161830f6a93f2aaabda99226c1ffddc8c4
> > 
> > Submitted for testing.  Pull-request to follow.
> 
> The commit dc805ea058c0e ("MAINTAINERS: rectify entry for DIALOG SEMICONDUCTOR DRIVERS")
> in mainline will give a conflict for patch#1.
> 
> Patch#2 and patch#3 are already in mainline.
> 
> 
> Please let me know if you want me to rebase and resend the patch series

That would be helpful, thanks.

Please ensure all of the patches have my:

Acked-by: Lee Jones <lee@kernel.org>

... applied, then I'll know to just apply them again.
Biju Das Jan. 31, 2024, 10:47 a.m. UTC | #5 
Hi Lee Jones,

Thanks for the feedback.

> -----Original Message-----
> From: Lee Jones <lee@kernel.org>
> Sent: Wednesday, January 31, 2024 8:49 AM
> Subject: Re: [PATCH v6 0/8] Convert DA906{1,2} bindings to json-schema
> 
> On Mon, 29 Jan 2024, Biju Das wrote:
> 
> > Hi Lee Jones,
> >
> > > -----Original Message-----
> > > From: Lee Jones <lee@kernel.org>
> > > Sent: Thursday, December 21, 2023 2:33 PM
> > > Subject: Re: [PATCH v6 0/8] Convert DA906{1,2} bindings to
> > > json-schema
> > >
> > > On Thu, 21 Dec 2023, Lee Jones wrote:
> > >
> > > > On Thu, 14 Dec 2023 08:09:03 +0000, Biju Das wrote:
> > > > > Convert the below bindings to json-schema
> > > > > 1) DA906{1,2} mfd bindings
> > > > > 2) DA906{1,2,3} onkey bindings
> > > > > 3) DA906{1,2,3} thermal bindings
> > > > >
> > > > > Also add fallback for DA9061 watchdog device and document
> > > > > DA9063 watchdog device.
> > > > >
> > > > > [...]
> > > >
> > > > Applied, thanks!
> > > >
> > > > [1/8] dt-bindings: mfd: da9062: Update watchdog description
> > > >       commit: 9e7b13b805bcbe5335c2936d4c7ea0323ac69a81
> > > > [2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for
> > > DA9061 watchdog
> > > >       commit: 28d34db7772f18490b52328f04a3bf69ed5390d2
> > > > [3/8] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063
> > > watchdog
> > > >       commit: d2a7dbb808870c17cffa2749ea877f61f298d098
> > > > [4/8] dt-bindings: mfd: dlg,da9063: Update watchdog child node
> > > >       commit: d4018547a15a94c7e865b2cef82bff1cd43a32b3
> > > > [5/8] dt-bindings: input: Convert da906{1,2,3} onkey to json-schema
> > > >       commit: db459d3da7bb9c37cb86897c7b321a49f8e40968
> > > > [6/8] dt-bindings: thermal: Convert da906{1,2} thermal to json-
> schema
> > > >       commit: 998f499c843e360bcd9ee1fe9addc3b5d32f1234
> > > > [7/8] dt-bindings: mfd: dlg,da9063: Sort child devices
> > > >       commit: 2bbf9d2a8e3bc933703dfda87cac953bed458496
> > > > [8/8] dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema
> > > >       commit: 522225161830f6a93f2aaabda99226c1ffddc8c4
> > >
> > > Submitted for testing.  Pull-request to follow.
> >
> > The commit dc805ea058c0e ("MAINTAINERS: rectify entry for DIALOG
> > SEMICONDUCTOR DRIVERS") in mainline will give a conflict for patch#1.
> >
> > Patch#2 and patch#3 are already in mainline.
> >
> >
> > Please let me know if you want me to rebase and resend the patch
> > series
> 
> That would be helpful, thanks.
> 
> Please ensure all of the patches have my:
> 
> Acked-by: Lee Jones <lee@kernel.org>
> 
> ... applied, then I'll know to just apply them again.

OK, Resend the series[1] with Ack tag and Rb tag from Conor for patch#6

[1]
https://lore.kernel.org/all/20240131102656.3379-1-biju.das.jz@bp.renesas.com/

Cheers,
Biju