| Message ID | 20231206155316.4181813-1-peteryin.openbmc@gmail.com |
|---|---|
| Headers | show |
| Series | Add Facebook Harma (AST2600) BMC | expand |
On Thu, 7 Dec 2023 at 02:25, Peter Yin <peteryin.openbmc@gmail.com> wrote: > > Add linux device tree entry related to > Harma specific devices connected to BMC SoC. This isn't a very helpful commit message. Convention is to mention what the system is to give context; eg "The SuperCorp Machine1 multi-node server system uses an AST2600 BMC". > +&mac3 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rmii4_default>; > + no-hw-checksum; > + use-ncsi; > + ncsi-ctrl,start-redo-probe; > + ncsi-ctrl,no-channel-monitor; > + mlx,multi-host; > + ncsi-package = <1>; > + ncsi-channel = <1>; > + ncsi-rexmit = <1>; > + ncsi-timeout = <2>; These properties are not supported by the kernel. It seems Facebook uses them in their machines, it would be great if you contributed support for them to mainline. If not, please drop the properties. > + > +&gpio0 { > + pinctrl-names = "default"; > + gpio-line-names = > + /*A0-A7*/ "","","","","","","","", > + /*B0-B7*/ "","","","", > + "FM_BMC_MUX_CS_SPI_SEL_0","FM_ID_LED_N","","", > + /*C0-C7*/ "","","","","","","","", > + /*D0-D7*/ "","","SOL_UART_SET","","","","","", > + /*E0-E7*/ "","","","","","","","", > + /*F0-F7*/ "","","","","","","","", > + /*G0-G7*/ "","","","","","","","", > + /*H0-H7*/ "","","","","","","","", > + /*I0-I7*/ "","","","","","","","", > + /*J0-J7*/ "","","","","","","","", > + /*K0-K7*/ "","","","","","","","", > + /*L0-L7*/ "","","","","","","","", > + /*M0-M7*/ "","","","","","","","", > + /*N0-N7*/ "LED_POSTCODE_0","LED_POSTCODE_1", > + "LED_POSTCODE_2","LED_POSTCODE_3", > + "LED_POSTCODE_4","LED_POSTCODE_5", > + "LED_POSTCODE_6","LED_POSTCODE_7", > + /*O0-O7*/ "","","","","","","","", > + /*P0-P7*/ "FP_SYS_PWRBTN_IN_N","BMC_SYS_PWRBTN_OUT_N", Is this machine going to run openbmc? We have a set of documented properties for GPIOs such as the power button: https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md If you intentionally do not want to follow this scheme, please mention why in your commit message. Cheers, Joel
On 06/12/2023 16:53, Peter Yin wrote: > Add linux device tree entry related to > Harma specific devices connected to BMC SoC. > > Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> > --- ... > +&mac3 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rmii4_default>; > + no-hw-checksum; > + use-ncsi; > + ncsi-ctrl,start-redo-probe; > + ncsi-ctrl,no-channel-monitor; > + mlx,multi-host; There is no such property. Please stop copying downstream code into upstream. Best regards, Krzysztof
Summary: Add linux device tree entry related to Harma specific devices connected to BMC SoC. v5:https://lore.kernel.org/all/20231204081029.2272626-3-peteryin.openbmc@gmail.com/ v4:https://lore.kernel.org/all/20231204054131.1845775-3-peter.yin@quantatw.com/ v3:https://lore.kernel.org/all/20231123050415.3441429-3-peteryin.openbmc@gmail.com/ v2:https://lore.kernel.org/all/cdbc75b9-3be1-4017-9bee-c8f161b6843c@linaro.org/ v1:https://lore.kernel.org/all/20231024082404.735843-3-peteryin.openbmc@gmail.com/ Change log v5 -> v6 - Add Retimer eeprom - Add Power Led - Add GPIO/SGPIO Line Name v4 -> v5 - Rename document and file from minerva-harma to harma. - remove Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> v3 -> v4 - Add SGPIO line name. v2 -> v3: - Fixed led schema. - Fixed i2c mux schema. - Add BMC_READY and SGPIO_READY. v1 -> v2: - Add Power sensors. - Modify ehci number. - Add Led. - Modify SGPIO line-name. v1: - Create minerva harma dts file. Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> --- Peter Yin (2): dt-bindings: arm: aspeed: add Meta Harma board ARM: dts: aspeed: Harma: Add Facebook Harma (AST2600) BMC .../bindings/arm/aspeed/aspeed.yaml | 1 + arch/arm/boot/dts/aspeed/Makefile | 1 + .../dts/aspeed/aspeed-bmc-facebook-harma.dts | 607 ++++++++++++++++++ 3 files changed, 609 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts