| Message ID | 20231110013817.2378507-1-danielwa@cisco.com |
|---|---|
| Headers | show |
| Series | generic command line v6 | expand |
On Thu, 9 Nov 2023 17:38:04 -0800 Daniel Walker <danielwa@cisco.com> wrote: > This release is an up-rev of the v5 patches. No additional features have > been added. Some changes were mode to function names and some changes to > Kconfig dependencies. Also updated the config conversion for mips. > > There are a number of people who have expressed interest in these > patches either by asking for them to be merge or testing them. If > people are so inclined please continue to request them to be merge > or to ask the status of the next release. It's helpful to motivate me to > release them again and for the maintainers to see the interest > generated. > > These patches have been used by Cisco Systems, Inc. on millions of > released products to great effect. Hopefully they can be used by the > entire Linux eco system. > fyi, none of the above is suitable for a [0/N] changelog - it's all transitory stuff which tells readers nothing much about what the patchset does. And that info is sorely missed. I can see that it's a code cleanup, but I'm sure Cisco wouldn't expend resources to maintain such a thing. There's something else here. In [1/8] I see "Even with mips and powerpc enhancement the needs of Cisco are not met on these platforms" and "This unified implementation offers the same functionality needed by Cisco on all platform which we enable it on". Well OK, what are these needs? What functionality changes does this patchset offer which Cisco finds useful? IOW, what were the requirements? What's wrong with the old code and how does this patchset fix/enhance that? I see the patchset updates nothing under Documentation/. Should it do so? Could it do so? I don't know what is the expected merge patch for this work. I can grab them if no other maintainer is in the firing line.
On Thu, Nov 09, 2023 at 05:51:42PM -0800, Andrew Morton wrote: > On Thu, 9 Nov 2023 17:38:04 -0800 Daniel Walker <danielwa@cisco.com> wrote: > > > This release is an up-rev of the v5 patches. No additional features have > > been added. Some changes were mode to function names and some changes to > > Kconfig dependencies. Also updated the config conversion for mips. > > > > There are a number of people who have expressed interest in these > > patches either by asking for them to be merge or testing them. If > > people are so inclined please continue to request them to be merge > > or to ask the status of the next release. It's helpful to motivate me to > > release them again and for the maintainers to see the interest > > generated. > > > > These patches have been used by Cisco Systems, Inc. on millions of > > released products to great effect. Hopefully they can be used by the > > entire Linux eco system. > > > > fyi, none of the above is suitable for a [0/N] changelog - it's all > transitory stuff which tells readers nothing much about what the > patchset does. I did not think about it this way. It's because I've submitted this so many times. I guess I assume everyone knows what it is. > And that info is sorely missed. I can see that it's a code cleanup, > but I'm sure Cisco wouldn't expend resources to maintain such a thing. > There's something else here. I think the prior submissions there was no cover letter, maybe I should just achoo that entirely. > In [1/8] I see "Even with mips and powerpc enhancement the needs of > Cisco are not met on these platforms" and "This unified implementation > offers the same functionality needed by Cisco on all platform which we > enable it on". > > Well OK, what are these needs? What functionality changes does this > patchset offer which Cisco finds useful? IOW, what were the > requirements? What's wrong with the old code and how does this > patchset fix/enhance that? The limitation is that you can't append and prepend to the command line at the same time in any of the architectures. Having access to both allows OEMs to deal with broken bootloaders which can't easily be upgraded. Others have responded that they also use these patches for this same reason. In 2/8 and 3/8 I modify the insert-sys-cert tool to allow modification of the command line append and prepend after the build. This allow for an SDK provided with a binary kernel and for the command line append/prepend to still be modified identically to how that's done with certificates. Making all this generic means each platform has a unified set of command line services. Cisco uses x86/arm32/arm64/mips/powerpc , and it's nice to have all the same features across platforms. > > I see the patchset updates nothing under Documentation/. Should it do > so? Could it do so? The only documentation is Kconfig descriptions and commit messages. I suppose it could have something under Documentation/. The only part which could use more documentation are the changes in 2/8 and 3/8. That feature is maybe confusing and has limitations which are maybe not clear. Although the same limitation exist for inserting certificates. > > I don't know what is the expected merge patch for this work. I can > grab them if no other maintainer is in the firing line. merge patch ? Do you mean merge description ? I think your the maintainer in the firing line for this one. Daniel
On Fri, 10 Nov 2023 02:22:27 +0000 "Daniel Walker (danielwa)" <danielwa@cisco.com> wrote: > On Thu, Nov 09, 2023 at 05:51:42PM -0800, Andrew Morton wrote: > > On Thu, 9 Nov 2023 17:38:04 -0800 Daniel Walker <danielwa@cisco.com> wrote: > > > > > This release is an up-rev of the v5 patches. No additional features have > > > been added. Some changes were mode to function names and some changes to > > > Kconfig dependencies. Also updated the config conversion for mips. > > > > > > There are a number of people who have expressed interest in these > > > patches either by asking for them to be merge or testing them. If > > > people are so inclined please continue to request them to be merge > > > or to ask the status of the next release. It's helpful to motivate me to > > > release them again and for the maintainers to see the interest > > > generated. > > > > > > These patches have been used by Cisco Systems, Inc. on millions of > > > released products to great effect. Hopefully they can be used by the > > > entire Linux eco system. > > > > > > > fyi, none of the above is suitable for a [0/N] changelog - it's all > > transitory stuff which tells readers nothing much about what the > > patchset does. > > I did not think about it this way. It's because I've submitted this so many > times. I guess I assume everyone knows what it is. This is all on the path to the mainline git history. Think about how we want it presented to future readers. 10 years from now nobody will remember the v5 series email spray. > > > In [1/8] I see "Even with mips and powerpc enhancement the needs of > > Cisco are not met on these platforms" and "This unified implementation > > offers the same functionality needed by Cisco on all platform which we > > enable it on". > > > > Well OK, what are these needs? What functionality changes does this > > patchset offer which Cisco finds useful? IOW, what were the > > requirements? What's wrong with the old code and how does this > > patchset fix/enhance that? > > The limitation is that you can't append and prepend to the command line at the > same time in any of the architectures. Having access to both allows OEMs to deal > with broken bootloaders which can't easily be upgraded. I would never ever have guessed that from the emails I received! > Others have responded > that they also use these patches for this same reason. Citing this info in the [0/N] would be useful. > In 2/8 and 3/8 I modify the insert-sys-cert tool to allow modification of the > command line append and prepend after the build. This allow for an SDK > provided with a binary kernel and for the command line append/prepend to still > be modified identically to how that's done with certificates. And this. > Making all this generic means each platform has a unified set of command line > services. Cisco uses x86/arm32/arm64/mips/powerpc , and it's nice to have all > the same features across platforms. Sounds good. > > > > I see the patchset updates nothing under Documentation/. Should it do > > so? Could it do so? > > The only documentation is Kconfig descriptions and commit messages. I suppose it > could have something under Documentation/. The only part which could use more > documentation are the changes in 2/8 and 3/8. That feature is maybe confusing > and has limitations which are maybe not clear. Although the same limitation exist for > inserting certificates. Perhaps the new functionality could be described in Documentation/admin-guide/kernel-parameters.rst > > > > I don't know what is the expected merge patch for this work. I can > > grab them if no other maintainer is in the firing line. > > merge patch ? "path", sorry. > Do you mean merge description ? I think your the maintainer in the > firing line for this one. OK.
Le 10/11/2023 à 02:38, Daniel Walker a écrit : > This release is an up-rev of the v5 patches. No additional features have > been added. Some changes were mode to function names and some changes to > Kconfig dependencies. Also updated the config conversion for mips. > > There are a number of people who have expressed interest in these > patches either by asking for them to be merge or testing them. If > people are so inclined please continue to request them to be merge > or to ask the status of the next release. It's helpful to motivate me to > release them again and for the maintainers to see the interest > generated. Good, then lets work all together and get the best of it. Your series has good features like the update of the command line addons without rebuild, including updating of the signature when applicable. However your series still has weaknesses it had in previous versions. I was hopping we could work all together to improve it, but you have been repeatedly telling that my proposal doesn't fit your needs without explaining why. Can we work in a more win-win spirit this time ? By the way, for the record, here is a link to a series I sent out as an exemple of what it could look like. The intention at that time was not to have a concurrent series, but just to show what I meant in my comments, because exemples are often more explicit than words. That series was considered more mature and closer to a mergeable state than yours at that time. Link to the said series: https://patchwork.ozlabs.org/project/linuxppc-dev/list/?state=*&series=237158 Your series only converts a few architectures, and I can't see any demonstration that it will be possible to convert other architectures as a follow-up without too much pain. > > These patches have been used by Cisco Systems, Inc. on millions of > released products to great effect. Hopefully they can be used by the > entire Linux eco system. This is not an argument. Billions of computers are running Micr*s*ft Windows, does it make Windows better ? Do IBM or Google claim about the million equipment they are sending out with special Linux features ? Showing objectively what's the benefit of your features without referring to Cisco would be better. > > My apologies on the length between releases. I will try to release more > often. Christophe > > > Daniel Walker (8): > CMDLINE: add generic builtin command line > scripts: insert-sys-cert: add command line insert capability > scripts: insert-sys-cert: change name to insert-symbol > CMDLINE: mips: convert to generic builtin command line > drivers: firmware: efi: libstub: enable generic commandline > CMDLINE: x86: convert to generic builtin command line > of: replace command line handling > CMDLINE: arm64: convert to generic builtin command line > > arch/arm64/Kconfig | 33 +-- > arch/arm64/include/asm/setup.h | 4 + > arch/arm64/include/uapi/asm/setup.h | 2 + > arch/arm64/kernel/idreg-override.c | 9 +- > arch/arm64/kernel/pi/kaslr_early.c | 14 +- > arch/mips/Kconfig | 4 +- > arch/mips/Kconfig.debug | 44 ---- > arch/mips/configs/ar7_defconfig | 12 +- > arch/mips/configs/bcm47xx_defconfig | 10 +- > arch/mips/configs/bcm63xx_defconfig | 21 +- > arch/mips/configs/bmips_be_defconfig | 17 +- > arch/mips/configs/bmips_stb_defconfig | 139 ++++------ > arch/mips/configs/ci20_defconfig | 8 +- > arch/mips/configs/cu1000-neo_defconfig | 19 +- > arch/mips/configs/cu1830-neo_defconfig | 19 +- > arch/mips/configs/generic_defconfig | 15 +- > arch/mips/configs/gpr_defconfig | 33 +-- > arch/mips/configs/loongson3_defconfig | 29 +-- > arch/mips/include/asm/setup.h | 2 + > arch/mips/kernel/relocate.c | 17 +- > arch/mips/kernel/setup.c | 36 +-- > arch/mips/pic32/pic32mzda/early_console.c | 2 +- > arch/mips/pic32/pic32mzda/init.c | 3 +- > arch/x86/Kconfig | 44 +--- > arch/x86/kernel/setup.c | 18 +- > .../firmware/efi/libstub/efi-stub-helper.c | 29 +++ > drivers/firmware/efi/libstub/efi-stub.c | 9 + > drivers/firmware/efi/libstub/efistub.h | 1 + > drivers/firmware/efi/libstub/x86-stub.c | 14 +- > drivers/of/fdt.c | 22 +- > include/linux/cmdline.h | 137 ++++++++++ > init/Kconfig | 79 ++++++ > lib/Kconfig | 4 + > lib/Makefile | 3 + > lib/generic_cmdline.S | 53 ++++ > lib/test_cmdline1.c | 139 ++++++++++ > scripts/Makefile | 2 +- > .../{insert-sys-cert.c => insert-symbol.c} | 243 ++++++++++++------ > 38 files changed, 807 insertions(+), 482 deletions(-) > create mode 100644 include/linux/cmdline.h > create mode 100644 lib/generic_cmdline.S > create mode 100644 lib/test_cmdline1.c > rename scripts/{insert-sys-cert.c => insert-symbol.c} (72%) >
This release is an up-rev of the v5 patches. No additional features have been added. Some changes were mode to function names and some changes to Kconfig dependencies. Also updated the config conversion for mips. There are a number of people who have expressed interest in these patches either by asking for them to be merge or testing them. If people are so inclined please continue to request them to be merge or to ask the status of the next release. It's helpful to motivate me to release them again and for the maintainers to see the interest generated. These patches have been used by Cisco Systems, Inc. on millions of released products to great effect. Hopefully they can be used by the entire Linux eco system. My apologies on the length between releases. I will try to release more often. Daniel Walker (8): CMDLINE: add generic builtin command line scripts: insert-sys-cert: add command line insert capability scripts: insert-sys-cert: change name to insert-symbol CMDLINE: mips: convert to generic builtin command line drivers: firmware: efi: libstub: enable generic commandline CMDLINE: x86: convert to generic builtin command line of: replace command line handling CMDLINE: arm64: convert to generic builtin command line arch/arm64/Kconfig | 33 +-- arch/arm64/include/asm/setup.h | 4 + arch/arm64/include/uapi/asm/setup.h | 2 + arch/arm64/kernel/idreg-override.c | 9 +- arch/arm64/kernel/pi/kaslr_early.c | 14 +- arch/mips/Kconfig | 4 +- arch/mips/Kconfig.debug | 44 ---- arch/mips/configs/ar7_defconfig | 12 +- arch/mips/configs/bcm47xx_defconfig | 10 +- arch/mips/configs/bcm63xx_defconfig | 21 +- arch/mips/configs/bmips_be_defconfig | 17 +- arch/mips/configs/bmips_stb_defconfig | 139 ++++------ arch/mips/configs/ci20_defconfig | 8 +- arch/mips/configs/cu1000-neo_defconfig | 19 +- arch/mips/configs/cu1830-neo_defconfig | 19 +- arch/mips/configs/generic_defconfig | 15 +- arch/mips/configs/gpr_defconfig | 33 +-- arch/mips/configs/loongson3_defconfig | 29 +-- arch/mips/include/asm/setup.h | 2 + arch/mips/kernel/relocate.c | 17 +- arch/mips/kernel/setup.c | 36 +-- arch/mips/pic32/pic32mzda/early_console.c | 2 +- arch/mips/pic32/pic32mzda/init.c | 3 +- arch/x86/Kconfig | 44 +--- arch/x86/kernel/setup.c | 18 +- .../firmware/efi/libstub/efi-stub-helper.c | 29 +++ drivers/firmware/efi/libstub/efi-stub.c | 9 + drivers/firmware/efi/libstub/efistub.h | 1 + drivers/firmware/efi/libstub/x86-stub.c | 14 +- drivers/of/fdt.c | 22 +- include/linux/cmdline.h | 137 ++++++++++ init/Kconfig | 79 ++++++ lib/Kconfig | 4 + lib/Makefile | 3 + lib/generic_cmdline.S | 53 ++++ lib/test_cmdline1.c | 139 ++++++++++ scripts/Makefile | 2 +- .../{insert-sys-cert.c => insert-symbol.c} | 243 ++++++++++++------ 38 files changed, 807 insertions(+), 482 deletions(-) create mode 100644 include/linux/cmdline.h create mode 100644 lib/generic_cmdline.S create mode 100644 lib/test_cmdline1.c rename scripts/{insert-sys-cert.c => insert-symbol.c} (72%)