| Message ID | 20230831055030.3958798-1-peteryin.openbmc@gmail.com |
|---|---|
| Headers | show |
| Series | *** Add Facebook Minerva (AST2600) BMC *** | expand |
On 31/08/2023 07:50, Peter Yin wrote: > Add linux device tree entry related to > Minerva specific devices connected to BMC SoC. > > Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> > --- > arch/arm/boot/dts/Makefile | 1 + > .../boot/dts/aspeed-bmc-facebook-minerva.dts | 377 ++++++++++++++++++ > 2 files changed, 378 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-minerva.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 9e1d7bf3cff6..edb0b2105333 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1604,6 +1604,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-facebook-wedge400.dtb \ > aspeed-bmc-facebook-yamp.dtb \ > aspeed-bmc-facebook-yosemitev2.dtb \ > + aspeed-bmc-facebook-minerva.dtb \ Third or fourth time: that's not a correct order. This is a nit, but since you keep ignoring it, I don't believe any other feedback was applied. Why you did not respond to my comments but just ignored them? Best regards, Krzysztof
On 8/31/23 14:20, Krzysztof Kozlowski wrote: > On 31/08/2023 07:50, Peter Yin wrote: >> Add linux device tree entry related to >> Minerva specific devices connected to BMC SoC. >> >> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> >> --- >> arch/arm/boot/dts/Makefile | 1 + >> .../boot/dts/aspeed-bmc-facebook-minerva.dts | 377 ++++++++++++++++++ >> 2 files changed, 378 insertions(+) >> create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-minerva.dts >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index 9e1d7bf3cff6..edb0b2105333 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -1604,6 +1604,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ >> aspeed-bmc-facebook-wedge400.dtb \ >> aspeed-bmc-facebook-yamp.dtb \ >> aspeed-bmc-facebook-yosemitev2.dtb \ >> + aspeed-bmc-facebook-minerva.dtb \ > Third or fourth time: that's not a correct order. This is a nit, but > since you keep ignoring it, I don't believe any other feedback was > applied. Why you did not respond to my comments but just ignored them? Sorry, I don't notice this is different file. > > Best regards, > Krzysztof >
On 31/08/2023 08:34, PeterYin wrote: > > On 8/31/23 14:20, Krzysztof Kozlowski wrote: >> On 31/08/2023 07:50, Peter Yin wrote: >>> Add linux device tree entry related to >>> Minerva specific devices connected to BMC SoC. >>> >>> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> >>> --- >>> arch/arm/boot/dts/Makefile | 1 + >>> .../boot/dts/aspeed-bmc-facebook-minerva.dts | 377 ++++++++++++++++++ >>> 2 files changed, 378 insertions(+) >>> create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-minerva.dts >>> >>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >>> index 9e1d7bf3cff6..edb0b2105333 100644 >>> --- a/arch/arm/boot/dts/Makefile >>> +++ b/arch/arm/boot/dts/Makefile >>> @@ -1604,6 +1604,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ >>> aspeed-bmc-facebook-wedge400.dtb \ >>> aspeed-bmc-facebook-yamp.dtb \ >>> aspeed-bmc-facebook-yosemitev2.dtb \ >>> + aspeed-bmc-facebook-minerva.dtb \ >> Third or fourth time: that's not a correct order. This is a nit, but >> since you keep ignoring it, I don't believe any other feedback was >> applied. Why you did not respond to my comments but just ignored them? > Sorry, I don't notice this is different file. You just skipped that comment and did not respond to it in your last private reply... Just like in previous versions. Go through all the comments from previous versions, not few. Best regards, Krzysztof
v1 link : https://lore.kernel.org/all/fb09f5e6-8381-312f-2f1e-f2b471cec68a@linaro.org/ v2 link : https://lore.kernel.org/lkml/9f499fe5-db59-f4c8-6a50-93725b7287fd@linaro.org/ v3 link : https://lore.kernel.org/lkml/20230830025133.3756506-1-peteryin.openbmc@gmail.com/ v4 link : https://lore.kernel.org/all/1d531692-5455-fbfd-0775-50856bf0fbc7@linaro.org/ Change log: v5: 1.remove redundant blank line. 2.Correcting the arrangement order in document. v4: 1.seprate dts document. v3: 1.Fixed commit description. 2.Add sgpio line name to sgpioP. 3.Add ipmb debug card bus. v2: 1.Add facebook,minerva-bmc in aspeed.yaml 2.Use stdout-path 3.Add Makefile v1: 1. Create minerva dts file. *** BLURB HERE *** Peter Yin (2): ARM: dts: aspeed: Minerva: Add Facebook Minerva (AST2600) BMC dt-bindings: arm: aspeed: add Meta Minerva board .../bindings/arm/aspeed/aspeed.yaml | 1 + arch/arm/boot/dts/Makefile | 1 + .../boot/dts/aspeed-bmc-facebook-minerva.dts | 377 ++++++++++++++++++ 3 files changed, 379 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-minerva.dts