| Message ID | 20230519214813.2593271-1-bhupesh.sharma@linaro.org |
|---|---|
| Headers | show |
| Series | arm64: qcom: Enable Crypto Engine for a few Qualcomm SoCs | expand |
On Sat, May 20, 2023 at 03:18:09AM +0530, Bhupesh Sharma wrote: > Add crypto engine (CE) and CE BAM related nodes and definitions to > 'sm6115.dtsi'. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Tested-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Tested-by: Anders Roxell <anders.roxell@linaro.org> > Tested-by: Linux Kernel Functional Testing <lkft@linaro.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm6115.dtsi | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi > index 631ca327e064..27ff42cf6066 100644 > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi > @@ -661,6 +661,31 @@ usb_hsphy: phy@1613000 { > status = "disabled"; > }; > > + cryptobam: dma-controller@1b04000 { > + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > + reg = <0x0 0x01b04000 0x0 0x24000>; > + interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>; > + #dma-cells = <1>; > + qcom,ee = <0>; > + qcom,controlled-remotely; > + num-channels = <8>; > + qcom,num-ees = <2>; I would also add the RPM_SMD_CE1_CLK clock here and then omit "num-channels" and "qcom,num-ees" (with [1]). It's not strictly necessary but will guarantee that the clock is running whenever the BAM is accessed (potentially avoiding crashes). And it seems to be the typical approach so far, see e.g. sdm845. RPMH_CE_CLK is used on both &cryptobam and &crypto there. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git/commit/?id=8975dd41a9dbca3b47f7b8dac5bc4dfb23011000 Thanks, Stephan
On Wed, 24 May 2023 at 23:53, Stephan Gerhold <stephan@gerhold.net> wrote: > > On Sat, May 20, 2023 at 03:18:09AM +0530, Bhupesh Sharma wrote: > > Add crypto engine (CE) and CE BAM related nodes and definitions to > > 'sm6115.dtsi'. > > > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Tested-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Tested-by: Anders Roxell <anders.roxell@linaro.org> > > Tested-by: Linux Kernel Functional Testing <lkft@linaro.org> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/sm6115.dtsi | 25 +++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi > > index 631ca327e064..27ff42cf6066 100644 > > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi > > @@ -661,6 +661,31 @@ usb_hsphy: phy@1613000 { > > status = "disabled"; > > }; > > > > + cryptobam: dma-controller@1b04000 { > > + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > > + reg = <0x0 0x01b04000 0x0 0x24000>; > > + interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>; > > + #dma-cells = <1>; > > + qcom,ee = <0>; > > + qcom,controlled-remotely; > > + num-channels = <8>; > > + qcom,num-ees = <2>; > > I would also add the RPM_SMD_CE1_CLK clock here and then omit > "num-channels" and "qcom,num-ees" (with [1]). It's not strictly > necessary but will guarantee that the clock is running whenever the BAM > is accessed (potentially avoiding crashes). And it seems to be the > typical approach so far, see e.g. sdm845. RPMH_CE_CLK is used on both > &cryptobam and &crypto there. > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git/commit/?id=8975dd41a9dbca3b47f7b8dac5bc4dfb23011000 Sure, I have fixed this in v8 which I will post shortly. Thanks, Bhupesh
Changes since v6: ----------------- - v6 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230405072836.1690248-1-bhupesh.sharma@linaro.org/ - Collected Acks, R-Bs and Tested-by for various patches. - Addressed Konrad's comment about iommu sids for sm8150 and sm8250 crypto node entries. - Addressed Konrad's and Stephan's comments about adding RPM clock for crypto blocks on qcm2290 and sm6115. Changes since v5: ----------------- - v5 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230402100509.1154220-1-bhupesh.sharma@linaro.org/ - Collected Ack from Rob for [PATCH 01/11]. - Addressed Georgi's comment about interconnect cells in [PATCH 10/11]. Changes since v4: ----------------- - v4 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230331164323.729093-1-bhupesh.sharma@linaro.org/ - Collected R-Bs from Konrad for a couple of patches sent in v4. - Fixed incorrect email IDs for a couple of patches sent in v3, which I used for some patches created on a different work machine. - No functional changes since v3. Changes since v3: ----------------- - v3 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230328092815.292665-1-bhupesh.sharma@linaro.org/ - Collected Acks from Krzysztof for a couple of patches sent in v3. - Fixed review comments from Krzysztof regarding DMA binding document and also added a couple of new patches which are required to fix the 'dtbs_check' errors highlighted after this fix. Changes since v2: ----------------- - v2 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230322114519.3412469-1-bhupesh.sharma@linaro.org/ - No functional change since v2. As the sdm845 patch from v1 was accepted in linux-next, dropped it from this version. Changes since v1: ----------------- - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230321190118.3327360-1-bhupesh.sharma@linaro.org/ - Folded the BAM DMA dt-binding change. (sent earlier as: https://lore.kernel.org/linux-arm-msm/20230321184811.3325725-1-bhupesh.sharma@linaro.org/) - Folded the QCE dt-binding change. (sent earlier as: https://lore.kernel.org/linux-arm-msm/20230320073816.3012198-1-bhupesh.sharma@linaro.org/) - Folded Neil's SM8450 dts patch in this series. - Addressed review comments from Rob, Stephan and Konrad. - Collected Konrad's R-B for [PATCH 5/9]. This patchset enables Crypto Engine support for Qualcomm SoCs like SM6115, SM8150, SM8250, SM8350 and SM8450. Note that: - SM8250 crypto engine patch utilizes the work already done by myself and Vladimir. - SM8350 crypto engine patch utilizes the work already done by Robert. - SM8450 crypto engine patch utilizes the work already done by Neil. Also this patchset is rebased on linux-next/master. Bhupesh Sharma (10): dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs dt-bindings: dma: Increase iommu maxItems for BAM DMA arm64: dts: qcom: sdm8550: Fix the BAM DMA engine compatible string arm64: dts: qcom: sdm845: Fix the slimbam DMA engine compatible string dt-bindings: qcom-qce: Fix compatible combinations for SM8150 and IPQ4019 SoCs dt-bindings: qcom-qce: Add compatibles for SM6115 and QCM2290 arm64: dts: qcom: sm6115: Add Crypto Engine support arm64: dts: qcom: sm8150: Add Crypto Engine support arm64: dts: qcom: sm8250: Add Crypto Engine support arm64: dts: qcom: sm8350: Add Crypto Engine support Neil Armstrong (1): arm64: dts: qcom: sm8450: add crypto nodes .../devicetree/bindings/crypto/qcom-qce.yaml | 50 +++++++++++++++---- .../devicetree/bindings/dma/qcom,bam-dma.yaml | 22 +++++--- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm6115.dtsi | 25 ++++++++++ arch/arm64/boot/dts/qcom/sm8150.dtsi | 30 +++++++++++ arch/arm64/boot/dts/qcom/sm8250.dtsi | 32 ++++++++++++ arch/arm64/boot/dts/qcom/sm8350.dtsi | 22 ++++++++ arch/arm64/boot/dts/qcom/sm8450.dtsi | 28 +++++++++++ arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +- 9 files changed, 194 insertions(+), 19 deletions(-)