mbox series

[v2,0/2] ACPI/DT mdiobus module owner fixes

Message ID 20230316233317.2169394-1-f.fainelli@gmail.com
Headers show
Series ACPI/DT mdiobus module owner fixes | expand

Message

Florian Fainelli March 16, 2023, 11:33 p.m. UTC 
This patch series fixes wrong mdiobus module ownership for MDIO buses
registered from DT or ACPI.

Thanks Maxime for providing the first patch and making me see that ACPI
also had the same issue.

Changes in v2:

- fixed missing kdoc in the first patch

Florian Fainelli (1):
  net: mdio: fix owner field for mdio buses registered using ACPI

Maxime Bizon (1):
  net: mdio: fix owner field for mdio buses registered using device-tree

 drivers/net/mdio/acpi_mdio.c  | 10 ++++++----
 drivers/net/mdio/of_mdio.c    | 12 +++++++-----
 drivers/net/phy/mdio_devres.c | 11 ++++++-----
 include/linux/acpi_mdio.h     |  9 ++++++++-
 include/linux/of_mdio.h       | 22 +++++++++++++++++++---
 5 files changed, 46 insertions(+), 18 deletions(-)

Comments

Simon Horman March 18, 2023, 3:19 p.m. UTC | #1 
On Thu, Mar 16, 2023 at 04:33:17PM -0700, Florian Fainelli wrote:
> Bus ownership is wrong when using acpi_mdiobus_register() to register an
> mdio bus. That function is not inline, so when it calls
> mdiobus_register() the wrong THIS_MODULE value is captured.
> 
> CC: Maxime Bizon <mbizon@freebox.fr>
> Fixes: 803ca24d2f92 ("net: mdio: Add ACPI support code for mdio")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
patchwork-bot+netdevbpf@kernel.org March 19, 2023, 10:50 a.m. UTC | #2 
Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 16 Mar 2023 16:33:15 -0700 you wrote:
> This patch series fixes wrong mdiobus module ownership for MDIO buses
> registered from DT or ACPI.
> 
> Thanks Maxime for providing the first patch and making me see that ACPI
> also had the same issue.
> 
> Changes in v2:
> 
> [...]

Here is the summary with links:
  - [v2,1/2] net: mdio: fix owner field for mdio buses registered using device-tree
    https://git.kernel.org/netdev/net/c/99669259f336
  - [v2,2/2] net: mdio: fix owner field for mdio buses registered using ACPI
    https://git.kernel.org/netdev/net/c/30b605b8501e

You are awesome, thank you!