From patchwork Tue Jan 3 06:46:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aradhya Bhatia X-Patchwork-Id: 1720902 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256 header.s=ti-com-17Q1 header.b=MlEsJlQW; dkim-atps=neutral Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4NmNb169vSz23dV for ; Tue, 3 Jan 2023 17:47:41 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236807AbjACGri (ORCPT ); Tue, 3 Jan 2023 01:47:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236634AbjACGrH (ORCPT ); Tue, 3 Jan 2023 01:47:07 -0500 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E45963BD; Mon, 2 Jan 2023 22:47:03 -0800 (PST) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3036kHrS036766; Tue, 3 Jan 2023 00:46:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1672728377; bh=GjviG7byUxJQO3JTq97W9RSWN/t+Ue/18g//GetxcNs=; h=From:To:CC:Subject:Date; b=MlEsJlQW28ncTKGiacYeRQHBUGi5M7vNIJIo/32shZD8qHL2gnNgsUA+sZpw9HbJu Wm45kD9SgsBzcxpMF+zL/cmYcIVArF+n+LbSAYQWNW0whH0tTehWT30G85MJMB/h4t Q81CtfSC3AQFmcg0jtl86ihlyeh2W7h+Xlk5LuXU= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3036kG9g042359 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 3 Jan 2023 00:46:16 -0600 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Tue, 3 Jan 2023 00:46:16 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Tue, 3 Jan 2023 00:46:16 -0600 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3036kFhp075217; Tue, 3 Jan 2023 00:46:16 -0600 From: Aradhya Bhatia To: Rob Herring , Krzysztof Kozlowski , Tomi Valkeinen , Jyri Sarha , David Airlie , Daniel Vetter , Laurent Pinchart , Thierry Reding , Sam Ravnborg , Maxime Ripard , Liam Girdwood , Mark Brown , Lad Prabhakar , Paul Walmsley , Palmer Dabbelt , Albert Ou , Matthias Brugger , Guo Ren CC: DRI Development List , Devicetree List , Linux Kernel List , Linux RISC-V List , Linux ARM Kernel List , Linux Mediatek List , Linux C-SKY Arch List , Nishanth Menon , Vignesh Raghavendra , Rahul T R , Devarsh Thakkar , Jai Luthra , Jayesh Choudhary , Aradhya Bhatia Subject: [RFC PATCH 0/4] dt-bindings: Introduce dual-link panels & panel-vendors Date: Tue, 3 Jan 2023 12:16:11 +0530 Message-ID: <20230103064615.5311-1-a-bhatia1@ti.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi all, Microtips Technology Solutions USA, and Lincoln Technology Solutions are 2 display panel vendors, and the first 2 patches add their vendor prefixes. The fourth patch, simply introduces the new compatible for the generic dual-link panels in the panel-lvds driver. This new compatible is based from a new DT binding added in the third patch explained below. The third patch introduces a dt-binding for generic dual-link LVDS panels. These panels do not have any documented constraints, except for their timing characteristics. Further, these panels have 2 pixel-sinks. In a dual-link connection between an LVDS encoder and the panel, one sink accepts the odd set of LVDS pixels and the other, the even set. A lot of this has been based from the Advantech,idk-2121wr dual-link panel[1] and Maxime's patches for generic LVDS panels[2] (which are single-link by default.) and the discussions that happened before they were finally merged. Below are some notes and points that I want to bring forward. - The advantech,idk-2121wr panel binding uses 2 boolean properties dual-link-odd/even-pixels, to signify which port sink is being used for which set of LVDS pixels. I too have added similar support and introduced constraints around those properties, so as to not break the ABI... but I believe there is a better way to achieve this. A "pixel-type" enum property could be introduced in their stead, which can accept one of the 2 options or . This method, in my opinion, is more accurate and cleaner to implement in the bindings as well. If this does sound a better I can push out a new revision where the driver supports both these methods (to not break the ABI) and the advantech,2121wr panel can remain as an exception. - As an alternative to the previous point, if that method is not preferred for some reason, the advantech,2121wtr panel binding could then be merged in the panel-dual-lvds binding as part of future work. - Another tweak, I am looking forward to do as part of future work and would like all your comments is to introduce driver-based implementation of the panel timing parameters, like it is with "panel-simple". The driver can then support both the panel-timing sources (DT node or hard-coded driver structure) and the binding can remove this from the "required" section. Thank you! [1]: https://patchwork.freedesktop.org/patch/357122/ [2]: https://patchwork.freedesktop.org/patch/471228/ Aradhya Bhatia (4): dt-bindings: vendor-prefixes: Add microtips dt-bindings: vendor-prefixes: Add lincolntech dt-bindings: panel: Introduce dual-link LVDS panel drm: panel-lvds: Introduce dual-link panels .../display/panel/panel-dual-lvds.yaml | 157 ++++++++++++++++++ .../devicetree/bindings/vendor-prefixes.yaml | 4 + MAINTAINERS | 1 + drivers/gpu/drm/panel/panel-lvds.c | 1 + 4 files changed, 163 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-dual-lvds.yaml