mbox series

[0/2] Add SM6115 interconnect support

Message ID 20221130103841.2266464-1-bhupesh.sharma@linaro.org
Headers show
Series Add SM6115 interconnect support | expand

Message

Bhupesh Sharma Nov. 30, 2022, 10:38 a.m. UTC 
This patchset adds the support for interconnect provider found
on Qualcomm SM6115 and SM4250 SoCs.

The topology consists of several NoCs that are controlled by
a remote processor that collects the aggregated bandwidth for each
master-slave pairs.
 
Bhupesh Sharma (2):
  interconnect: qcom: Add SM6115 interconnect provider driver
  dt-bindings: interconnect: Add SM6115 DT bindings

 .../bindings/interconnect/qcom,sm6115.yaml    |  137 ++
 drivers/interconnect/qcom/Kconfig             |    9 +
 drivers/interconnect/qcom/Makefile            |    2 +
 drivers/interconnect/qcom/sm6115.c            | 1371 +++++++++++++++++
 .../dt-bindings/interconnect/qcom,sm6115.h    |  115 ++
 5 files changed, 1634 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml
 create mode 100644 drivers/interconnect/qcom/sm6115.c
 create mode 100644 include/dt-bindings/interconnect/qcom,sm6115.h

Comments

Konrad Dybcio Nov. 30, 2022, 11:07 a.m. UTC | #1 
On 30.11.2022 11:38, Bhupesh Sharma wrote:
> Add driver for the Qualcomm interconnect buses found in SM6115 based
> platforms. The topology consists of several NoCs that are controlled by
> a remote processor that collects the aggregated bandwidth for each
> master-slave pairs.
> 
> Cc: Bjorn Andersson <andersson@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---

[...]

> +MODULE_DEVICE_TABLE(of, sm6115_qnoc_of_match);
> +
> +static struct platform_driver sm6115_qnoc_driver = {
> +	.probe = qnoc_probe,
> +	.remove = qnoc_remove,
> +	.driver = {
> +		.name = "qnoc-sm6115",
> +		.of_match_table = sm6115_qnoc_of_match,
No .sync_state?

> +	},
> +};
> +module_platform_driver(sm6115_qnoc_driver);
> +
> +MODULE_DESCRIPTION("Qualcomm SM6115 NoC driver");
> +MODULE_LICENSE("GPL v2");
"GPL", checkpatch should have pointed that out.

Otherwise lgtm

Konrad
Bhupesh Sharma Nov. 30, 2022, 11:40 a.m. UTC | #2 
Hi Konrad,

On Wed, 30 Nov 2022 at 16:37, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 30.11.2022 11:38, Bhupesh Sharma wrote:
> > Add driver for the Qualcomm interconnect buses found in SM6115 based
> > platforms. The topology consists of several NoCs that are controlled by
> > a remote processor that collects the aggregated bandwidth for each
> > master-slave pairs.
> >
> > Cc: Bjorn Andersson <andersson@kernel.org>
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> > ---
>
> [...]
>
> > +MODULE_DEVICE_TABLE(of, sm6115_qnoc_of_match);
> > +
> > +static struct platform_driver sm6115_qnoc_driver = {
> > +     .probe = qnoc_probe,
> > +     .remove = qnoc_remove,
> > +     .driver = {
> > +             .name = "qnoc-sm6115",
> > +             .of_match_table = sm6115_qnoc_of_match,
> No .sync_state?

Oops. Will add it in v2,

> > +     },
> > +};
> > +module_platform_driver(sm6115_qnoc_driver);
> > +
> > +MODULE_DESCRIPTION("Qualcomm SM6115 NoC driver");
> > +MODULE_LICENSE("GPL v2");
> "GPL", checkpatch should have pointed that out.

Sure, I will fix this in v2.

Thanks,
Bhupesh