| Message ID | 20220825013258.3459714-1-andrew@lunn.ch |
|---|---|
| Headers | show |
| Series | Start converting MVEBU bindings to DT Schema | expand |
On Thu, Aug 25, 2022 at 03:32:46AM +0200, Andrew Lunn wrote: > This is the first batch of patches converting the Marvell MVEBU driver > bindings from .txt to .yaml. So far, kirkwood has been used for > testing, but these drivers apply to a range of Marvell SoCs. > > In order to reduce the number of warnings from the DT schema checking > tools, a few minor changes have been made to a few DT files. No actual > errors have been found, the changes just make the checker quiet. > > I propose these patches are merged via mvebu to arm-soc. No conflicts > are expected with these patches. Why? I strongly prefer the bindings go via subsystem trees. That is the documented way. As pointed out in v1, you again have not Cc'ed the subsystem maintainers. Please resend. Rob
On Tue, Aug 30, 2022 at 01:43:34PM -0500, Rob Herring wrote: > On Thu, Aug 25, 2022 at 03:32:46AM +0200, Andrew Lunn wrote: > > This is the first batch of patches converting the Marvell MVEBU driver > > bindings from .txt to .yaml. So far, kirkwood has been used for > > testing, but these drivers apply to a range of Marvell SoCs. > > > > In order to reduce the number of warnings from the DT schema checking > > tools, a few minor changes have been made to a few DT files. No actual > > errors have been found, the changes just make the checker quiet. > > > > I propose these patches are merged via mvebu to arm-soc. No conflicts > > are expected with these patches. > > Why? I strongly prefer the bindings go via subsystem trees. That is the > documented way. I have 50 patches to convert kirkwood from .txt to .yaml. probably around 30 subsystems. 1) Complete nightmare to keep track of so many different patchsets going in 30 different directions. 2) None of these patches change any driver code. This is pure 'Documentation'. The subsystem probably reviewed the .txt file 10 years ago when I and other mvebu maintainers submitted them. Nothing is changing in the kernel code base, except now we gain some degree of validation for this 'Documentation'. 3) Pretty much all of these were merged via arm-soc 10 years ago. Why do it different now? What is gained by not going via arm-soc? Andrew
On Tue, Aug 30, 2022 at 2:22 PM Andrew Lunn <andrew@lunn.ch> wrote: > > On Tue, Aug 30, 2022 at 01:43:34PM -0500, Rob Herring wrote: > > On Thu, Aug 25, 2022 at 03:32:46AM +0200, Andrew Lunn wrote: > > > This is the first batch of patches converting the Marvell MVEBU driver > > > bindings from .txt to .yaml. So far, kirkwood has been used for > > > testing, but these drivers apply to a range of Marvell SoCs. > > > > > > In order to reduce the number of warnings from the DT schema checking > > > tools, a few minor changes have been made to a few DT files. No actual > > > errors have been found, the changes just make the checker quiet. > > > > > > I propose these patches are merged via mvebu to arm-soc. No conflicts > > > are expected with these patches. > > > > Why? I strongly prefer the bindings go via subsystem trees. That is the > > documented way. > > I have 50 patches to convert kirkwood from .txt to .yaml. probably > around 30 subsystems. > > 1) Complete nightmare to keep track of so many different patchsets > going in 30 different directions. That's what everyone else does. Send them out and let the maintainers pick them up. Anything left can go via the DT tree or arm-soc. That is going to happen anyways once you Cc the correct maintainers unless you state in each patch not to apply. > 2) None of these patches change any driver code. This is pure > 'Documentation'. The subsystem probably reviewed the .txt file 10 > years ago when I and other mvebu maintainers submitted > them. Nothing is changing in the kernel code base, except now we > gain some degree of validation for this 'Documentation'. > > 3) Pretty much all of these were merged via arm-soc 10 years ago. Why > do it different now? What is gained by not going via arm-soc? 10 years ago it was hit or miss whether bindings even got reviewed. Shall we go back to that? Probably my biggest complaint is when anything breaks in next, fixes going into arm-soc are slow because there are 2 levels of maintainers. Rob
This is the first batch of patches converting the Marvell MVEBU driver bindings from .txt to .yaml. So far, kirkwood has been used for testing, but these drivers apply to a range of Marvell SoCs. In order to reduce the number of warnings from the DT schema checking tools, a few minor changes have been made to a few DT files. No actual errors have been found, the changes just make the checker quiet. I propose these patches are merged via mvebu to arm-soc. No conflicts are expected with these patches. v2: s/^DT/dt-bindings/ s/YAML/DT schema/ Drop 'Device Tree Bindings' from title: pinctrl: Add additionalProperties: false requires for marvell,function & marvell,pins regex for mpp values Split pinctrl/marvell,ac5-pinctrl.yaml cleanup into its own patch Add interrupts-extended to marvell,orion-wdt.yaml Replace compatible 'bar' with 'arm,pl353-nand-r2p1' to avoid unknown warning Fix some of the USB controller warnings. It is unclear if the kirkwood warnings are valid usage of the core USB binding or not. Andrew Lunn (12): dt-bindings: RTC: orion-rtc: Convert to DT schema dt-bindings: thermal: marvell,kirkwood-thermal: Convert to DT schema dt-bindings: pinctrl: Convert marvell,kirkwood-pintctrl to DT schema dt-bindings: marvell,ac5-pinctrl: Refactor to look like other Marvell pinctrl files dt-bindings: USB: Convert ehci-orion to DT schema dt-bindings: watchdog: Convert marvel.txt to DT schema arm: DT: kirkwood/orion5: Rename watchdog node dt-bindings: nand-controller: Reflect reality of marvell,orion-nand dt-bindings: mtd: Convert orion-nand to DT schema arm: DT: kirkwood.dtsi: Rename nand to nand-controller dt-bindings: timer: Convert marvell,orion-timer.txt to DT schema dt-bindings: clock: Convert mvebu-gated-clock.txt to DT schema .../clock/marvell,kirkwood-gating-clock.yaml | 229 +++++++++++ .../bindings/clock/mvebu-gated-clock.txt | 205 ---------- .../bindings/mtd/marvell,orion-nand.yaml | 98 +++++ .../bindings/mtd/nand-controller.yaml | 17 +- .../devicetree/bindings/mtd/orion-nand.txt | 50 --- .../pinctrl/marvell,88f6180-pinctrl.yaml | 73 ++++ .../pinctrl/marvell,88f6190-pinctrl.yaml | 73 ++++ .../pinctrl/marvell,88f6192-pinctrl.yaml | 73 ++++ .../pinctrl/marvell,88f6281-pinctrl.yaml | 74 ++++ .../pinctrl/marvell,88f6282-pinctrl.yaml | 74 ++++ .../pinctrl/marvell,98dx1135-pinctrl.yaml | 72 ++++ .../pinctrl/marvell,98dx4122-pinctrl.yaml | 72 ++++ .../bindings/pinctrl/marvell,ac5-pinctrl.yaml | 23 +- .../pinctrl/marvell,kirkwood-pinctrl.txt | 359 ------------------ .../bindings/rtc/marvell,orion-rtc.yaml | 48 +++ .../devicetree/bindings/rtc/orion-rtc.txt | 18 - .../bindings/thermal/kirkwood-thermal.txt | 15 - .../thermal/marvell,kirkwood-thermal.yaml | 32 ++ .../bindings/timer/marvell,orion-timer.txt | 16 - .../bindings/timer/marvell,orion-timer.yaml | 51 +++ .../devicetree/bindings/usb/ehci-orion.txt | 22 -- .../bindings/usb/marvell,orion-ehci.yaml | 48 +++ .../devicetree/bindings/watchdog/marvel.txt | 45 --- .../bindings/watchdog/marvell,orion-wdt.yaml | 101 +++++ arch/arm/boot/dts/kirkwood.dtsi | 4 +- arch/arm/boot/dts/orion5x.dtsi | 2 +- 26 files changed, 1150 insertions(+), 744 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/marvell,kirkwood-gating-clock.yaml delete mode 100644 Documentation/devicetree/bindings/clock/mvebu-gated-clock.txt create mode 100644 Documentation/devicetree/bindings/mtd/marvell,orion-nand.yaml delete mode 100644 Documentation/devicetree/bindings/mtd/orion-nand.txt create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6180-pinctrl.yaml create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6190-pinctrl.yaml create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6192-pinctrl.yaml create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6281-pinctrl.yaml create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6282-pinctrl.yaml create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,98dx1135-pinctrl.yaml create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,98dx4122-pinctrl.yaml delete mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,kirkwood-pinctrl.txt create mode 100644 Documentation/devicetree/bindings/rtc/marvell,orion-rtc.yaml delete mode 100644 Documentation/devicetree/bindings/rtc/orion-rtc.txt delete mode 100644 Documentation/devicetree/bindings/thermal/kirkwood-thermal.txt create mode 100644 Documentation/devicetree/bindings/thermal/marvell,kirkwood-thermal.yaml delete mode 100644 Documentation/devicetree/bindings/timer/marvell,orion-timer.txt create mode 100644 Documentation/devicetree/bindings/timer/marvell,orion-timer.yaml delete mode 100644 Documentation/devicetree/bindings/usb/ehci-orion.txt create mode 100644 Documentation/devicetree/bindings/usb/marvell,orion-ehci.yaml delete mode 100644 Documentation/devicetree/bindings/watchdog/marvel.txt create mode 100644 Documentation/devicetree/bindings/watchdog/marvell,orion-wdt.yaml