| Message ID | 20220710164442.2958979-1-LinoSanfilippo@gmx.de |
|---|---|
| Headers | show |
| Series | Fixes and cleanup for RS485 | expand |
On Sun, Jul 10, 2022 at 06:44:34PM +0200, Lino Sanfilippo wrote: > From: Lino Sanfilippo <l.sanfilippo@kunbus.com> > > The following series includes cleanup and fixes around RS485 in the serial > core and uart drivers: > > Patch 1: ar933x: Fix check for RS485 support > Patch 2: Remove superfluous code in ar933x. > Patch 3: Set the rs485 termination GPIO in the serial core. This is needed > since if the gpio is only accessible in sleepable context. It also > is a further step to make the RS485 handling more generic. > Patch 4: Move sanitizing of RS485 delays into an own function. This is in > preparation of patch 4. > Patch 5: Sanitize RS485 delays read from device tree. > Patch 6: Correct RS485 delays in binding documentation. > Patch 7: Remove redundant code in 8250_dwlib. > Patch 8: Remove redundant code in 8250-lpc18xx. > Changes in v4: > - fixed logical error found by > - capitalize "uart" and "gpio" in commit messages Please, avoid sending sequential version of the series more often than once per a few days, recommended interval is one week.
Hi, On 10.07.22 20:43, Andy Shevchenko wrote: > On Sun, Jul 10, 2022 at 06:44:34PM +0200, Lino Sanfilippo wrote: >> From: Lino Sanfilippo <l.sanfilippo@kunbus.com> >> >> The following series includes cleanup and fixes around RS485 in the serial >> core and uart drivers: >> >> Patch 1: ar933x: Fix check for RS485 support >> Patch 2: Remove superfluous code in ar933x. >> Patch 3: Set the rs485 termination GPIO in the serial core. This is needed >> since if the gpio is only accessible in sleepable context. It also >> is a further step to make the RS485 handling more generic. >> Patch 4: Move sanitizing of RS485 delays into an own function. This is in >> preparation of patch 4. >> Patch 5: Sanitize RS485 delays read from device tree. >> Patch 6: Correct RS485 delays in binding documentation. >> Patch 7: Remove redundant code in 8250_dwlib. >> Patch 8: Remove redundant code in 8250-lpc18xx. > >> Changes in v4: >> - fixed logical error found by >> - capitalize "uart" and "gpio" in commit messages > > Please, avoid sending sequential version of the series more often than once per > a few days, recommended interval is one week. > sorry, this was due to the error found by the kernel test robot. I was not sure if to wait, resend with the same version number or send the next version. I guess waiting a few days would have been the best option. Will do so next time. Regards, Lino
From: Lino Sanfilippo <l.sanfilippo@kunbus.com> The following series includes cleanup and fixes around RS485 in the serial core and uart drivers: Patch 1: ar933x: Fix check for RS485 support Patch 2: Remove superfluous code in ar933x. Patch 3: Set the rs485 termination GPIO in the serial core. This is needed since if the gpio is only accessible in sleepable context. It also is a further step to make the RS485 handling more generic. Patch 4: Move sanitizing of RS485 delays into an own function. This is in preparation of patch 4. Patch 5: Sanitize RS485 delays read from device tree. Patch 6: Correct RS485 delays in binding documentation. Patch 7: Remove redundant code in 8250_dwlib. Patch 8: Remove redundant code in 8250-lpc18xx. Changes in v4: - fixed logical error found by - capitalize "uart" and "gpio" in commit messages Changes in v3: - remove obsolete patch (due to changes by Ilpo) - corrected and rephrase commit messages (pointed out by Andy) - remove superfluous check (pointed out by Andy) - separate ar933x UART bugfix and cleanup into different patches (as suggested by Ilpo) - put the ar933x fix at the beginning of the series (as suggested by Andy) Changes in v2: - print a warning if termination GPIO is specified in DT/ACPI but is not supported by driver - fixed commit message for devtree documentation (as suggested by Andy) - fixed code comment - added patch 7 Lino Sanfilippo (8): serial: ar933x: Fix check for RS485 support serial: ar933x: Remove superfluous code in ar933x_config_rs485() serial: core, 8250: set RS485 termination GPIO in serial core serial: core: move sanitizing of RS485 delays into own function serial: core: sanitize RS485 delays read from device tree dt_bindings: rs485: Correct delay values serial: 8250_dwlib: remove redundant sanity check for RS485 flags serial: 8250: lpc18xx: Remove redundant sanity check for RS485 flags .../devicetree/bindings/serial/rs485.yaml | 4 +- drivers/tty/serial/8250/8250_dwlib.c | 10 +--- drivers/tty/serial/8250/8250_lpc18xx.c | 6 +- drivers/tty/serial/8250/8250_port.c | 3 - drivers/tty/serial/ar933x_uart.c | 18 ++---- drivers/tty/serial/serial_core.c | 60 ++++++++++++------- 6 files changed, 50 insertions(+), 51 deletions(-) base-commit: 7e5b4322cde067e1d0f1bf8f490e93f664a7c843