From patchwork Wed Apr 27 16:21:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauri Sandberg X-Patchwork-Id: 1623156 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=ext.kapsi.fi header.i=@ext.kapsi.fi header.a=rsa-sha256 header.s=20161220 header.b=TFPJs0il; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4KpPcW1CQ7z9s5V for ; Thu, 28 Apr 2022 02:40:10 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243248AbiD0QnS (ORCPT ); Wed, 27 Apr 2022 12:43:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243255AbiD0QnR (ORCPT ); Wed, 27 Apr 2022 12:43:17 -0400 X-Greylist: delayed 1008 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 27 Apr 2022 09:40:03 PDT Received: from mailserv1.kapsi.fi (mailserv1.kapsi.fi [IPv6:2001:67c:1be8::25:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44FA3674E7 for ; Wed, 27 Apr 2022 09:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ext.kapsi.fi; s=20161220; h=Subject:Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=s0tSZBlfyGxMTtB3lAr2Q1sYcP0+uGwRUvp3hPCyHzU=; b=TFPJs0il2zNVxAi8U1shUAyTRM 20CDsMFiQPGr+uatPGDKZUUZ3j3igMoeq66QfETt/VEkjxS0yY1n2bJfI9Y0P98JRfRj6MRyWwVip v0AtDGfXEVDSfdqkWDDcXYww1VJdGROcpOy/vwS3qM1sBcg+H2nBwP6uk6ntqibxUY0IFXKv7QjQz JBqDiVBo+fKrNMtTiLvq1AZJirhw71UD1C/CgunTu0MigRPqLvuQxIet1uxFDMcUpWitbuSIY2bSk lxhduu8fc43lpM4W0nRpn5jnjv2Vr91PX3fT/KfzpxHHyDicHhJkYxHvUukCb4+5yrvQqGX+OijWG la7YIE/A==; Received: from 82-71-190-90.dyn.estpak.ee ([90.190.71.82]:62336 helo=localhost) by mailserv1.kapsi.fi with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1njkRY-00047C-N0; Wed, 27 Apr 2022 19:23:10 +0300 Received: by localhost (sSMTP sendmail emulation); Wed, 27 Apr 2022 19:23:07 +0300 From: Mauri Sandberg To: soc@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Cc: arnd@arndb.de, olof@lixom.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, Mauri Sandberg Date: Wed, 27 Apr 2022 19:21:22 +0300 Message-Id: <20220427162123.110458-1-maukka@ext.kapsi.fi> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 90.190.71.82 X-SA-Exim-Mail-From: maukka@ext.kapsi.fi X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Subject: [RFC RFT PATCH v1 0/1] ARM: orion5x: convert D-Link DNS-323 to the Device Tree X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on mailserv1.kapsi.fi) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello all, I am making an attempt to create a device tree for D-Link DNS-323 devices but I am falling short on a few specific details. I am requesting a general review of the device tree files. I have access to DNS-323 rev A1 only and the B1 and C1 need to be tested separately, so I am reaching out to people who might have them. The questions that I have at the moment are below. - some of resulting IRQs are different from what was requested in device tree - logs say NR_IRQS is different from mach file one - sata_mv fails to initialise with -22 (-EINVAL) - there is no concensus on how to get ascii formatted MAC address from mtd partitions so eth is not fully functional without setting the MAC from userspace - revs B1 and C1 need testing - how to configure RTC to wake system from sleep? What currently works in rev A1 - leds - keys - fan - temperature sensor - shutdown - reboot - mtd partitions - ethernet (mac address must be set manually) I have included relevant parts from boot log to better illustrate what seems to be off target -------------------------------- DT log --------------------------------------- ... NR_IRQS: 16, nr_irqs: 16, preallocated irqs: 16 ... sata_mv 0000:00:01.0: Gen-IIE 32 slots 4 ports SCSI mode IRQ via INTx sata_mv: probe of 0000:00:01.0 failed with error -22 ... mv64xxx_i2c mv64xxx_i2c.0: can't get pinctrl, bus recovery not supported ... ------------------------------------------------------------------------------- Best regards, Mauri Mauri Sandberg (1): ARM: orion5x: convert D-Link DNS-323 to the Device Tree arch/arm/boot/dts/Makefile | 3 + arch/arm/boot/dts/orion5x-dlink-dns323.dtsi | 217 ++++++ arch/arm/boot/dts/orion5x-dlink-dns323a1.dts | 59 ++ arch/arm/boot/dts/orion5x-dlink-dns323b1.dts | 38 + arch/arm/boot/dts/orion5x-dlink-dns323c1.dts | 80 ++ arch/arm/mach-orion5x/Kconfig | 6 +- arch/arm/mach-orion5x/Makefile | 2 +- arch/arm/mach-orion5x/board-dns323.c | 118 +++ arch/arm/mach-orion5x/board-dt.c | 3 + arch/arm/mach-orion5x/common.h | 6 + arch/arm/mach-orion5x/dns323-setup.c | 724 ------------------- 11 files changed, 528 insertions(+), 728 deletions(-) create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323.dtsi create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323a1.dts create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323b1.dts create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323c1.dts create mode 100644 arch/arm/mach-orion5x/board-dns323.c delete mode 100644 arch/arm/mach-orion5x/dns323-setup.c base-commit: 46cf2c613f4b10eb12f749207b0fd2c1bfae3088 Reviewed-by: Andrew Lunn --- 2.25.1