| Message ID | 20220118185746.299832-1-henrik@grimler.se |
|---|---|
| Headers | show |
| Series | Add initial support for exynos5420-chagall-wifi | expand |
Hi Henrik, >-----Original Message----- >From: Henrik Grimler [mailto:henrik@grimler.se] >Sent: Wednesday, January 19, 2022 12:28 AM >To: semen.protsenko@linaro.org; virag.david003@gmail.com; >martin.juecker@gmail.com; cw00.choi@samsung.com; >m.szyprowski@samsung.com; alim.akhtar@samsung.com; >krzysztof.kozlowski@canonical.com; robh+dt@kernel.org; >devicetree@vger.kernel.org; linux-samsung-soc@vger.kernel.org; linux-arm- >kernel@lists.infradead.org; linux-kernel@vger.kernel.org; >~postmarketos/upstreaming@lists.sr.ht >Cc: Henrik Grimler <henrik@grimler.se> >Subject: [PATCH v4 3/3] ARM: dts: Add support for Samsung Chagall WiFi > >Chagall WiFi, with product name Samsung Galaxy Tab S 10.5", is based on >Exynos 5420. This device is one of several tablet models released in 2014 >based on Exynos 5420. > >The device tree added here contains support for: > >- UART >- eMMC >- SD card >- USB > >CCI has been disabled in the hardware, enabling it would require (de- >)soldering a resistor on the board. Trying to boot with it enabled in kernel >makes the device hang when CCI is probed. >Exynos5420-arndale-octa also has had CCI disabled due to issues, see commit >25217fef3551 ("ARM: dts: disable CCI on exynos5420 based arndale-octa"). > >Signed-off-by: Henrik Grimler <henrik@grimler.se> >--- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/exynos5420-chagall-wifi.dts | 75 ++ > .../dts/exynos5420-galaxy-tab-common.dtsi | 692 ++++++++++++++++++ > 3 files changed, 768 insertions(+) > create mode 100644 arch/arm/boot/dts/exynos5420-chagall-wifi.dts > create mode 100644 arch/arm/boot/dts/exynos5420-galaxy-tab-common.dtsi > >diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index >0de64f237cd8..088fcedb3212 100644 >--- a/arch/arm/boot/dts/Makefile >+++ b/arch/arm/boot/dts/Makefile >@@ -220,6 +220,7 @@ dtb-$(CONFIG_ARCH_EXYNOS5) += \ > exynos5420-arndale-octa.dtb \ > exynos5420-peach-pit.dtb \ > exynos5420-smdk5420.dtb \ >+ exynos5420-chagall-wifi.dtb \ > exynos5422-odroidhc1.dtb \ > exynos5422-odroidxu3.dtb \ > exynos5422-odroidxu3-lite.dtb \ >diff --git a/arch/arm/boot/dts/exynos5420-chagall-wifi.dts >b/arch/arm/boot/dts/exynos5420-chagall-wifi.dts >new file mode 100644 >index 000000000000..1319344a2c74 >--- /dev/null >+++ b/arch/arm/boot/dts/exynos5420-chagall-wifi.dts >@@ -0,0 +1,75 @@ >+// SPDX-License-Identifier: GPL-2.0 >+/* >+ * Samsung's Exynos5420 Chagall WiFi board device tree source >+ * >+ * Copyright (c) 2012-2013 Samsung Electronics Co., Ltd. >+ * http://www.samsung.com >+ * Copyright (c) 2022 Henrik Grimler >+ */ >+ >+/dts-v1/; >+#include "exynos5420-galaxy-tab-common.dtsi" >+ >+/ { >+ model = "Samsung Chagall WiFi based on Exynos5420"; >+ compatible = "samsung,chagall-wifi", "samsung,exynos5420", \ >+ "samsung,exynos5"; >+}; >+ >+&ldo15_reg { >+ /* Unused */ >+ regulator-name = "VDD_LDO15"; >+ regulator-min-microvolt = <3300000>; >+ regulator-max-microvolt = <3300000>; >+}; >+ >+&ldo17_reg { >+ regulator-name = "VDD_IRLED_3V3"; >+ regulator-min-microvolt = <3300000>; >+ regulator-max-microvolt = <3350000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+}; >+ >+&ldo28_reg { >+ /* Unused */ >+ regulator-name = "VDD_LDO28"; >+ regulator-min-microvolt = <3300000>; >+ regulator-max-microvolt = <3300000>; >+}; >+ >+&ldo29_reg { >+ regulator-name = "VDD_TCON_1V8"; >+ regulator-min-microvolt = <1900000>; >+ regulator-max-microvolt = <1900000>; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+}; >+ >+&ldo31_reg { >+ regulator-name = "VDD_GRIP_1V8"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+}; >+ >+&ldo32_reg { >+ regulator-name = "VDD_TSP_1V8"; >+ regulator-min-microvolt = <1900000>; >+ regulator-max-microvolt = <1900000>; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+}; >diff --git a/arch/arm/boot/dts/exynos5420-galaxy-tab-common.dtsi >b/arch/arm/boot/dts/exynos5420-galaxy-tab-common.dtsi >new file mode 100644 >index 000000000000..e4ed0fd153f4 >--- /dev/null >+++ b/arch/arm/boot/dts/exynos5420-galaxy-tab-common.dtsi >@@ -0,0 +1,692 @@ >+// SPDX-License-Identifier: GPL-2.0 >+/* >+ * Base DT for Samsung's family of tablets based on Exynos5420. >+ * >+ * Copyright (c) 2012-2013 Samsung Electronics Co., Ltd. >+ * http://www.samsung.com >+ * Copyright (c) 2022 Henrik Grimler >+ */ >+ >+/dts-v1/; >+#include "exynos5420.dtsi" >+#include "exynos5420-cpus.dtsi" >+#include <dt-bindings/input/input.h> >+#include <dt-bindings/gpio/gpio.h> >+#include <dt-bindings/clock/samsung,s2mps11.h> >+ >+/ { >+ chassis-type = "tablet"; >+ >+ /* >+ * To successfully boot the mainline kernel with the stock >+ * bootloader (SBOOT), the tlb needs to be flushed after the >+ * page table pointer has been updated in >__common_mmu_cache_on. >+ * The same hack is also needed to boot exynos4412-i9300 with >+ * stock bootloader, and probably other Samsung devices of >+ * similar age. See >+ * https://lore.kernel.org/all/1355276466-18295-1-git-send-email- >arve@android.com >+ * for more details. >+ */ >+ >+ chosen { >+ stdout-path = "serial2:115200n8"; >+ }; >+ >+ memory@20000000 { >+ device_type = "memory"; >+ reg = <0x20000000 0xc0000000>; >+ }; >+ >+ firmware@2073000 { >+ compatible = "samsung,secure-firmware"; >+ reg = <0x02073000 0x1000>; >+ }; >+ >+ fixed-rate-clocks { >+ oscclk { >+ compatible = "samsung,exynos5420-oscclk"; >+ clock-frequency = <24000000>; >+ }; >+ }; >+ >+ gpio-keys { >+ compatible = "gpio-keys"; >+ pinctrl-names = "default"; >+ >+ key-power { >+ debounce-interval = <10>; >+ gpios = <&gpx2 2 GPIO_ACTIVE_LOW>; >+ label = "Power"; >+ linux,code = <KEY_POWER>; >+ wakeup-source; >+ }; >+ >+ key-home { >+ debounce-interval = <10>; >+ gpios = <&gpx0 5 GPIO_ACTIVE_LOW>; >+ label = "Home"; >+ linux,code = <KEY_HOME>; >+ wakeup-source; >+ }; >+ >+ key-volume-up { >+ debounce-interval = <10>; >+ gpios = <&gpx0 2 GPIO_ACTIVE_LOW>; >+ label = "Volume Up"; >+ linux,code = <KEY_VOLUMEUP>; >+ }; >+ >+ key-volume-down { >+ debounce-interval = <10>; >+ gpios = <&gpx0 3 GPIO_ACTIVE_LOW>; >+ label = "Volume Down"; >+ linux,code = <KEY_VOLUMEDOWN>; >+ }; >+ }; >+}; >+ >+&cci { >+ /* CCI is disabled in hardware */ >+ status = "disabled"; >+}; >+ >+&cpu0 { >+ cpu-supply = <&buck2_reg>; >+}; >+ >+&cpu4 { >+ cpu-supply = <&buck6_reg>; >+}; >+ >+&gpu { >+ status = "okay"; >+ mali-supply = <&buck4_reg>; >+}; >+ >+&hsi2c_7 { >+ status = "okay"; >+ >+ pmic@66 { >+ compatible = "samsung,s2mps11-pmic"; >+ reg = <0x66>; >+ >+ interrupt-parent = <&gpx3>; >+ interrupts = <2 IRQ_TYPE_LEVEL_LOW>; >+ pinctrl-names = "default"; >+ pinctrl-0 = <&s2mps11_irq>; >+ >+ s2mps11_osc: clocks { >+ compatible = "samsung,s2mps11-clk"; >+ #clock-cells = <1>; >+ clock-output-names = "s2mps11_ap", "s2mps11_cp", >+ "s2mps11_bt"; >+ }; >+ >+ regulators { >+ buck1_reg: BUCK1 { >+ regulator-name = "VDD_MIF_1V1"; >+ regulator-min-microvolt = <700000>; >+ regulator-max-microvolt = <1300000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ buck2_reg: BUCK2 { >+ regulator-name = "VDD_ARM_1V0"; >+ regulator-min-microvolt = <800000>; >+ regulator-max-microvolt = <1500000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ buck3_reg: BUCK3 { >+ regulator-name = "VDD_INT_1V0"; >+ regulator-min-microvolt = <800000>; >+ regulator-max-microvolt = <1400000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ buck4_reg: BUCK4 { >+ regulator-name = "VDD_G3D_1V0"; >+ regulator-min-microvolt = <700000>; >+ regulator-max-microvolt = <1400000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ buck5_reg: BUCK5 { >+ regulator-name = "VDD_MEM_1V2"; >+ regulator-min-microvolt = <1200000>; >+ regulator-max-microvolt = <1200000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ >+ }; >+ >+ buck6_reg: BUCK6 { >+ regulator-name = "VDD_KFC_1V0"; >+ regulator-min-microvolt = <800000>; >+ regulator-max-microvolt = <1500000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ buck7_reg: BUCK7 { >+ regulator-name = "VIN_LLDO_1V4"; >+ regulator-min-microvolt = <1200000>; >+ regulator-max-microvolt = <1500000>; >+ regulator-always-on; >+ }; >+ >+ buck8_reg: BUCK8 { >+ regulator-name = "VIN_MLDO_2V0"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <2100000>; >+ regulator-always-on; >+ }; >+ >+ buck9_reg: BUCK9 { >+ regulator-name = "VIN_HLDO_3V5"; >+ regulator-min-microvolt = <3000000>; >+ regulator-max-microvolt = <3500000>; >+ regulator-always-on; >+ }; >+ >+ buck10_reg: BUCK10 { >+ regulator-name = "VDD_CAM_ISP_1V0"; >+ regulator-min-microvolt = <750000>; >+ regulator-max-microvolt = <3550000>; >+ }; >+ >+ ldo1_reg: LDO1 { >+ regulator-name = "VDD_ALIVE_1.0V"; >+ regulator-min-microvolt = <1000000>; >+ regulator-max-microvolt = <1000000>; >+ regulator-always-on; >+ }; >+ >+ ldo2_reg: LDO2 { >+ regulator-name = "VDD_APIO_1V8"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-on-in-suspend; >+ }; >+ }; >+ >+ ldo3_reg: LDO3 { >+ regulator-name = "VDD_APIO_MMC01_1V8"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; >+ regulator-always-on; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo4_reg: LDO4 { >+ regulator-name = "VDD_ADC_1V8"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-on-in-suspend; >+ }; >+ }; >+ >+ ldo5_reg: LDO5 { >+ /* Unused */ >+ regulator-name = "VDD_LDO5"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; >+ }; >+ >+ ldo6_reg: LDO6 { >+ regulator-name = "VDD_MIPI_1V0"; >+ regulator-min-microvolt = <1000000>; >+ regulator-max-microvolt = <1000000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo7_reg: LDO7 { >+ regulator-name = >"VDD_MIPI_PLL_ABB1_18V"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo8_reg: LDO8 { >+ /* Unused */ >+ regulator-name = "VDD_LDO8"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; >+ }; >+ >+ ldo9_reg: LDO9 { >+ regulator-name = "VDD_UOTG_3V0"; >+ regulator-min-microvolt = <3000000>; >+ regulator-max-microvolt = <3000000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-on-in-suspend; >+ }; >+ }; >+ >+ ldo10_reg: LDO10 { >+ regulator-name = "VDDQ_PRE_1V8"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-on-in-suspend; >+ }; >+ }; >+ >+ ldo11_reg: LDO11 { >+ regulator-name = "VDD_HSIC_1V0"; >+ regulator-min-microvolt = <1000000>; >+ regulator-max-microvolt = <1000000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-on-in-suspend; >+ }; >+ }; >+ >+ ldo12_reg: LDO12 { >+ regulator-name = "VDD_HSIC_1V8"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-on-in-suspend; >+ }; >+ }; >+ >+ ldo13_reg: LDO13 { >+ regulator-name = "VDD_APIO_MMC2_2V8"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <2800000>; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo14_reg: LDO14 { >+ regulator-name = "VDD_MOTOR_3V0"; >+ regulator-min-microvolt = <3000000>; >+ regulator-max-microvolt = <3000000>; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo15_reg: LDO15 { >+ regulator-name = "VDD_LDO15"; >+ /* >+ * LDO15 varies between devices and is >+ * specified in the device dts >+ */ >+ }; >+ >+ ldo16_reg: LDO16 { >+ regulator-name = "VDD_AP_2V8"; >+ regulator-min-microvolt = <2800000>; >+ regulator-max-microvolt = <2800000>; >+ regulator-always-on; >+ regulator-boot-on; >+ >+ regulator-state-mem { >+ regulator-on-in-suspend; >+ }; >+ }; >+ >+ ldo17_reg: LDO17 { >+ regulator-name = "VDD_LDO17"; >+ /* >+ * LDO17 varies between devices and is >+ * specified in the device dts >+ */ >+ }; >+ >+ ldo18_reg: LDO18 { >+ /* Unused */ >+ regulator-name = "VDD_LDO18"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; >+ }; >+ >+ Nit: remove extra line here Not sure if you need to re-spin the patch or may be Krzysztof will fix this will applying Rest looks fine. Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> >+ ldo19_reg: LDO19 { >+ regulator-name = "VDD_VTF_2V8"; >+ regulator-min-microvolt = <2800000>; >+ regulator-max-microvolt = <2800000>; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo20_reg: LDO20 { >+ regulator-name = "VDD_CAM1_CAM_1V8"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo21_reg: LDO21 { >+ regulator-name = "VDD_CAM_IO_1V8"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo22_reg: LDO22 { >+ regulator-name = >"VDD_CAM0_S_CORE_1V1"; >+ regulator-min-microvolt = <1050000>; >+ regulator-max-microvolt = <1200000>; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo23_reg: LDO23 { >+ regulator-name = "VDD_MIFS_1V1"; >+ regulator-min-microvolt = <800000>; >+ regulator-max-microvolt = <1100000>; >+ regulator-always-on; >+ >+ regulator-state-mem { >+ regulator-on-in-suspend; >+ }; >+ }; >+ >+ ldo24_reg: LDO24 { >+ regulator-name = "VDD_TSP_3V3"; >+ regulator-min-microvolt = <3300000>; >+ regulator-max-microvolt = <3300000>; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo25_reg: LDO25 { >+ /* Unused */ >+ regulator-name = "VDD_LDO25"; >+ regulator-min-microvolt = <800000>; >+ regulator-max-microvolt = <3950000>; >+ }; >+ >+ ldo26_reg: LDO26 { >+ regulator-name = "VDD_CAM0_AF_2V8"; >+ regulator-min-microvolt = <2800000>; >+ regulator-max-microvolt = <2800000>; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo27_reg: LDO27 { >+ regulator-name = "VDD_G3DS_1V0"; >+ regulator-min-microvolt = <800000>; >+ regulator-max-microvolt = <1000000>; >+ regulator-always-on; >+ >+ regulator-state-mem { >+ regulator-on-in-suspend; >+ }; >+ }; >+ >+ ldo28_reg: LDO28 { >+ regulator-name = "VDD_LDO28"; >+ /* >+ * LDO28 varies between devices and is >+ * specified in the device dts >+ */ >+ }; >+ >+ ldo29_reg: LDO29 { >+ regulator-name = "VDD_LDO29"; >+ /* >+ * LDO29 varies between devices and is >+ * specified in the device dts >+ */ >+ }; >+ >+ ldo30_reg: LDO30 { >+ regulator-name = "VDD_TOUCH_1V8"; >+ regulator-min-microvolt = <1900000>; >+ regulator-max-microvolt = <1900000>; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo31_reg: LDO31 { >+ regulator-name = "VDD_LDO31"; >+ /* >+ * LDO31 varies between devices and is >+ * specified in the device dts >+ */ >+ }; >+ >+ ldo32_reg: LDO32 { >+ regulator-name = "VDD_LDO32"; >+ /* >+ * LDO32 varies between devices and is >+ * specified in the device dts >+ */ >+ }; >+ >+ ldo33_reg: LDO33 { >+ regulator-name = "VDD_MHL_1V8"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo34_reg: LDO34 { >+ regulator-name = "VDD_MHL_3V3"; >+ regulator-min-microvolt = <3300000>; >+ regulator-max-microvolt = <3300000>; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo35_reg: LDO35 { >+ regulator-name = "VDD_SIL_1V2"; >+ regulator-min-microvolt = <1200000>; >+ regulator-max-microvolt = <1200000>; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ >+ ldo36_reg: LDO36 { >+ /* Unused */ >+ regulator-name = "VDD_LDO36"; >+ regulator-min-microvolt = <800000>; >+ regulator-max-microvolt = <3950000>; >+ }; >+ >+ ldo37_reg: LDO37 { >+ /* Unused */ >+ regulator-name = "VDD_LDO37"; >+ regulator-min-microvolt = <800000>; >+ regulator-max-microvolt = <3950000>; >+ }; >+ >+ ldo38_reg: LDO38 { >+ regulator-name = "VDD_KEY_LED_3V3"; >+ regulator-min-microvolt = <2500000>; >+ regulator-max-microvolt = <3300000>; >+ >+ regulator-state-mem { >+ regulator-off-in-suspend; >+ }; >+ }; >+ }; >+ }; >+}; >+ >+&mixer { >+ status = "okay"; >+}; >+ >+/* Internal storage */ >+&mmc_0 { >+ status = "okay"; >+ bus-width = <8>; >+ cap-mmc-highspeed; >+ card-detect-delay = <200>; >+ mmc-hs200-1_8v; >+ non-removable; >+ pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8>; >+ pinctrl-names = "default"; >+ samsung,dw-mshc-ciu-div = <3>; >+ samsung,dw-mshc-ddr-timing = <0 2>; >+ samsung,dw-mshc-sdr-timing = <0 4>; >+ vqmmc-supply = <&ldo3_reg>; >+}; >+ >+/* External sdcard */ >+&mmc_2 { >+ status = "okay"; >+ bus-width = <4>; >+ cap-sd-highspeed; >+ card-detect-delay = <200>; >+ cd-gpios = <&gpx2 4 GPIO_ACTIVE_LOW>; >+ pinctrl-0 = <&sd2_clk &sd2_cmd &mmc2_cd &sd2_bus1 &sd2_bus4>; >+ pinctrl-names = "default"; >+ samsung,dw-mshc-ciu-div = <3>; >+ samsung,dw-mshc-ddr-timing = <0 2>; >+ samsung,dw-mshc-sdr-timing = <0 4>; >+ sd-uhs-sdr50; >+ vmmc-supply = <&ldo19_reg>; >+ vqmmc-supply = <&ldo13_reg>; >+}; >+ >+&pinctrl_0 { >+ mmc2_cd: mmc2-cd-pins { >+ samsung,pins = "gpx2-4"; >+ samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; >+ }; >+ >+ s2mps11_irq: s2mps11-irq-pins { >+ samsung,pins = "gpx3-0"; >+ samsung,pin-function = <EXYNOS_PIN_FUNC_F>; >+ samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; >+ samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>; >+ }; >+}; >+ >+&rtc { >+ status = "okay"; >+ clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>; >+ clock-names = "rtc", "rtc_src"; >+}; >+ >+&tmu_cpu0 { >+ vtmu-supply = <&ldo10_reg>; >+}; >+ >+&tmu_cpu1 { >+ vtmu-supply = <&ldo10_reg>; >+}; >+ >+&tmu_cpu2 { >+ vtmu-supply = <&ldo10_reg>; >+}; >+ >+&tmu_cpu3 { >+ vtmu-supply = <&ldo10_reg>; >+}; >+ >+&tmu_gpu { >+ vtmu-supply = <&ldo10_reg>; >+}; >+ >+&usbdrd_dwc3_0 { >+ dr_mode = "peripheral"; >+}; >+ >+&usbdrd_dwc3_1 { >+ dr_mode = "peripheral"; >+}; >+ >+&usbdrd3_0 { >+ vdd33-supply = <&ldo9_reg>; >+ vdd10-supply = <&ldo11_reg>; >+}; >+ >+&usbdrd3_1 { >+ vdd33-supply = <&ldo9_reg>; >+ vdd10-supply = <&ldo11_reg>; >+}; >-- >2.34.1
On Tue, 18 Jan 2022 19:57:43 +0100, Henrik Grimler wrote: > Samsung's tablet Galaxy Tab S 10.5" (wifi) has codename Chagall WiFi > and is one of several tablets released in 2014 based on Exynos 5420. > This initial devicetree adds support for accessing device over USB or > UART, and allows using a rootfs in either the internal eMMC or an > external sdcard. 4 out of 8 CPUs are brought up when device boots, > which is the same as on the somewhat similar board > exynos5420-arndale-octa. > > [...] Applied, thanks! [1/3] dt-bindings: arm: samsung: document Chagall WiFi board binding commit: 9998104515d4197d774e5384df750c6384915707 [2/3] ARM: exynos: only do SMC_CMD_CPU1BOOT call on Exynos4 commit: 534aaa1802eae339d0439feafe3c1217f5643b20 [3/3] ARM: dts: Add support for Samsung Chagall WiFi commit: 535f7fffed880312830c72d9c593b59ec741dd8e Best regards,
Samsung's tablet Galaxy Tab S 10.5" (wifi) has codename Chagall WiFi and is one of several tablets released in 2014 based on Exynos 5420. This initial devicetree adds support for accessing device over USB or UART, and allows using a rootfs in either the internal eMMC or an external sdcard. 4 out of 8 CPUs are brought up when device boots, which is the same as on the somewhat similar board exynos5420-arndale-octa. Patch 2 is necessary after a secure-firmware node is added, otherwise device hangs during the CPU1BOOT secure monitor call. Without the secure-firmware node we are not able to bring up any secondary CPUs. Changes since v3: ================= * Rename device specific regulators LDOx -> VDD_LDOx for consistency * Make LDO32 vary with device and add on/off-in-suspend to a couple of more regulators, to match vendor kernel * Fix mmc2 card-detect, with cd-gpios defined and pin config pin-pud=pin_pull_none sdcard insertion is detected and seen in dmesg * Rename sd2-cd-pins -> mmc2-cd-pins Changes since v2 ================ Addressing Krzysztof's feedback: * chagallwifi -> chagall-wifi and Chagall WiFi in messages and comments * Re-write commit message for patch 3, use commit hash and ("subject"), move hint about bootloader issue to galaxy-tab-common.dtsi * Fix s2mps11 regulator nodes, use &ldoXX_reg handle for device customisation * Re-add usbdrd supplies (works after fixing regulator nodes) * Remove unnecessary, duplicate, compatible in galaxy-tab-common.dtsi * Remove extra clocks xxti and xusbxti * Prefix key- to gpio-keys * Add pinctrl pins to mmc_2. card-detect pin is different than for other Exynos 5420 devices, so define and use mmc2_cd node under pinctrl_0 Additional changes: * Add/fix supplies of mmc_0 and mmc_2 (vmmc-supply for mmc0 is unknown) * Sort mmc_X properties alphabetically * Fix IRQ pin for s2mps11, it was wrong (gpx3-2 -> gpx3-0) * Mark LDO31 as varying between devices as well, it differs between WiFi and LTE tablet versions * Fix typo for LDO5 (regulato-name -> regulator-name) * Remove regulator-ramp-delay from buck regulators, based on exynos5420-arndale-octa there should be no need to set it Changes since v1 ================ Fix mmc_0 and usbdrd in patch 3: * Remove extra, non supported, options from mmc_0 node * Do not set usbdrd supplies. Usb networking does not work with them specified, but it works fine with dummy regulators Henrik Grimler (3): dt-bindings: arm: samsung: document Chagall WiFi board binding ARM: exynos: only do SMC_CMD_CPU1BOOT call on Exynos4 ARM: dts: Add support for Samsung Chagall WiFi .../bindings/arm/samsung/samsung-boards.yaml | 1 + arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/exynos5420-chagall-wifi.dts | 75 ++ .../dts/exynos5420-galaxy-tab-common.dtsi | 692 ++++++++++++++++++ arch/arm/mach-exynos/firmware.c | 4 +- 5 files changed, 772 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/exynos5420-chagall-wifi.dts create mode 100644 arch/arm/boot/dts/exynos5420-galaxy-tab-common.dtsi