mbox series

[V2,0/6] nvmem: add "cell-type" property to support mac-address

Message ID 20210923110109.29785-1-qiangqing.zhang@nxp.com
Headers show
Series nvmem: add "cell-type" property to support mac-address | expand

Message

Joakim Zhang Sept. 23, 2021, 11:01 a.m. UTC 
This patch set adds "cell-type" property to parse mac address, take i.MX
as an example, which need reverse byte for mac address.

ChangeLogs:
V1->V2:
	* correct comments: @cell_read_callback -> @cell_post_process
	* s/imx8mm/imx8m/ in commit message title
	* add reviewed-by tags

Joakim Zhang (2):
  arm64: dts: imx8m: add "cell-type" property for mac-address
  arm64: dts: imx8m: remove unused "nvmem_macaddr_swap" property for FEC

Srinivas Kandagatla (4):
  dt-bindings: nvmem: add cell-type to nvmem cells
  nvmem: core: parse nvmem cell-type from device tree
  nvmem: core: add nvmem cell post processing callback
  nvmem: imx-ocotp: add support for post porcessing.

 .../devicetree/bindings/nvmem/nvmem.yaml      | 11 +++++++
 arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  3 +-
 arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  3 +-
 arch/arm64/boot/dts/freescale/imx8mp.dtsi     | 10 ++++++-
 arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  3 +-
 drivers/nvmem/core.c                          | 12 ++++++++
 drivers/nvmem/imx-ocotp.c                     | 30 +++++++++++++++++++
 include/dt-bindings/nvmem/nvmem.h             |  8 +++++
 include/linux/nvmem-provider.h                |  5 ++++
 9 files changed, 81 insertions(+), 4 deletions(-)
 create mode 100644 include/dt-bindings/nvmem/nvmem.h

Comments

Srinivas Kandagatla Sept. 28, 2021, 2:44 p.m. UTC | #1 
Hi Joakim,


I pushed some WIP changes to 
https://git.kernel.org/pub/scm/linux/kernel/git/srini/nvmem.git/log/?h=topic/post-processing
with Rob's feedback,

Do you think you could try it out and see if this works for you?

--srini

On 23/09/2021 12:01, Joakim Zhang wrote:
> This patch set adds "cell-type" property to parse mac address, take i.MX
> as an example, which need reverse byte for mac address.
> 
> ChangeLogs:
> V1->V2:
> 	* correct comments: @cell_read_callback -> @cell_post_process
> 	* s/imx8mm/imx8m/ in commit message title
> 	* add reviewed-by tags
> 
> Joakim Zhang (2):
>    arm64: dts: imx8m: add "cell-type" property for mac-address
>    arm64: dts: imx8m: remove unused "nvmem_macaddr_swap" property for FEC
> 
> Srinivas Kandagatla (4):
>    dt-bindings: nvmem: add cell-type to nvmem cells
>    nvmem: core: parse nvmem cell-type from device tree
>    nvmem: core: add nvmem cell post processing callback
>    nvmem: imx-ocotp: add support for post porcessing.
> 
>   .../devicetree/bindings/nvmem/nvmem.yaml      | 11 +++++++
>   arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  3 +-
>   arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  3 +-
>   arch/arm64/boot/dts/freescale/imx8mp.dtsi     | 10 ++++++-
>   arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  3 +-
>   drivers/nvmem/core.c                          | 12 ++++++++
>   drivers/nvmem/imx-ocotp.c                     | 30 +++++++++++++++++++
>   include/dt-bindings/nvmem/nvmem.h             |  8 +++++
>   include/linux/nvmem-provider.h                |  5 ++++
>   9 files changed, 81 insertions(+), 4 deletions(-)
>   create mode 100644 include/dt-bindings/nvmem/nvmem.h
>
Joakim Zhang Sept. 29, 2021, 8:07 a.m. UTC | #2 
Hi Srinivas,

> -----Original Message-----
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Sent: 2021年9月28日 22:44
> To: Joakim Zhang <qiangqing.zhang@nxp.com>; robh+dt@kernel.org;
> shawnguo@kernel.org; a.fatoum@pengutronix.de
> Cc: kernel@pengutronix.de; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH V2 0/6] nvmem: add "cell-type" property to support
> mac-address
> 
> Hi Joakim,
> 
> 
> I pushed some WIP changes to
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kern
> el.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fsrini%2Fnvmem.git%2Flog%
> 2F%3Fh%3Dtopic%2Fpost-processing&amp;data=04%7C01%7Cqiangqing.zhan
> g%40nxp.com%7Cff93b429bde84a45eedd08d9828e758b%7C686ea1d3bc2b4c
> 6fa92cd99c5c301635%7C0%7C0%7C637684370636358863%7CUnknown%7CT
> WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ
> XVCI6Mn0%3D%7C1000&amp;sdata=h%2BZo3nkJ2QuO86N93o9t3uUPvAoflh
> QOBKfSnfAkLv8%3D&amp;reserved=0
> with Rob's feedback,
> 
> Do you think you could try it out and see if this works for you?

Thank you very much!!

I do a quick test, and the result is as you expected. Feel free to add my test tag: Tested-by: Joakim Zhang <qiangqing.zhang@nxp.com>
Since no extra work needed for i.MX dts, so could you please take care of this patch set?
Any test request later could be delayed, sorry, as I am on vacation starts tomorrow. I will handle it ASAP when I come back on office if you have request.

Best Regards,
Joakim Zhang