mbox series

[v5,0/2] Introduce the BQ256XX family of chargers

Message ID 20201001214034.5925-1-r-rivera-matos@ti.com
Headers show
Series Introduce the BQ256XX family of chargers | expand

Message

Ricardo Rivera-Matos Oct. 1, 2020, 9:40 p.m. UTC 
Hello,

This patchset introduces the bq256xx family of charging ICs. The bq256xx
ICs are highly integrated, buck, switching chargers intended for use in 
smartphones, tablets, and portable electronics.

Ricardo Rivera-Matos (2):
  dt-bindings: power: Add the bq256xx dt bindings
  power: supply: bq256xx: Introduce the BQ256XX charger driver

 .../bindings/power/supply/bq256xx.yaml        |  110 +
 drivers/power/supply/Kconfig                  |   11 +
 drivers/power/supply/Makefile                 |    1 +
 drivers/power/supply/bq256xx_charger.c        | 1785 +++++++++++++++++
 4 files changed, 1907 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/bq256xx.yaml
 create mode 100644 drivers/power/supply/bq256xx_charger.c

Comments

Sebastian Reichel Oct. 3, 2020, 10:54 a.m. UTC | #1 
Hi Ricardo,

On Thu, Oct 01, 2020 at 04:40:34PM -0500, Ricardo Rivera-Matos wrote:
> The BQ256XX family of devices are highly integrated buck chargers
> for single cell batteries.
> 
> Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
> 
> v5 - adds power_supply_put_battery_info() and devm_add_action_or_reset() calls
> ---

changes look good, but you are still missing
usb_unregister_notifier() calls on drival removal.

-- Sebastian
Ricardo Rivera-Matos Oct. 5, 2020, 5:33 p.m. UTC | #2 
Sebastian,

On 10/3/20 5:54 AM, Sebastian Reichel wrote:
> Hi Ricardo,
>
> On Thu, Oct 01, 2020 at 04:40:34PM -0500, Ricardo Rivera-Matos wrote:
>> The BQ256XX family of devices are highly integrated buck chargers
>> for single cell batteries.
>>
>> Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
>>
>> v5 - adds power_supply_put_battery_info() and devm_add_action_or_reset() calls
>> ---
> changes look good, but you are still missing
> usb_unregister_notifier() calls on drival removal.
ACK, I will add a driver removal function and make the appropriate 
usb_unregister_notifier() calls.
>
> -- Sebastian
Ricardo