mbox series

[v33,0/6] LP50xx addition and remainder Multicolor patches

Message ID 20200812195020.13568-1-dmurphy@ti.com
Headers show
Series LP50xx addition and remainder Multicolor patches | expand

Message

Dan Murphy Aug. 12, 2020, 7:50 p.m. UTC 
Hello

These are the final patches from the original multicolor framework patchset.

Changes made were to the LP50xx to rework regmap_defaults to eliminate used
only once #defines.  Also fixed putting the child node in the dt parsing and
changed regmap regcache type to flat.

Dan

Dan Murphy (6):
  dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers
  leds: lp50xx: Add the LP50XX family of the RGB LED driver
  ARM: defconfig: u8500: Add LP55XX_COMMON config flag
  ARM: dts: n900: Add reg property to the LP5523 channel node
  ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node
  ARM: dts: ste-href: Add reg property to the LP5521 channel nodes

 .../devicetree/bindings/leds/leds-lp50xx.yaml | 130 ++++
 arch/arm/boot/dts/imx6dl-yapp4-common.dtsi    |  14 +-
 arch/arm/boot/dts/omap3-n900.dts              |  29 +-
 arch/arm/boot/dts/ste-href.dtsi               |  22 +-
 arch/arm/configs/u8500_defconfig              |   1 +
 drivers/leds/Kconfig                          |  11 +
 drivers/leds/Makefile                         |   1 +
 drivers/leds/leds-lp50xx.c                    | 634 ++++++++++++++++++
 8 files changed, 823 insertions(+), 19 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
 create mode 100644 drivers/leds/leds-lp50xx.c

Comments

Pavel Machek Aug. 17, 2020, 8:35 p.m. UTC | #1 
Hi!

> These are the final patches from the original multicolor framework patchset.
> 
> Changes made were to the LP50xx to rework regmap_defaults to eliminate used
> only once #defines.  Also fixed putting the child node in the dt parsing and
> changed regmap regcache type to flat.

Thanks. I applied 1 and 2 of the series to the for-next branch.

Best regards,
								Pavel
Dan Murphy Aug. 17, 2020, 8:59 p.m. UTC | #2 
Pavel

On 8/17/20 3:35 PM, Pavel Machek wrote:
> Hi!
>
>> These are the final patches from the original multicolor framework patchset.
>>
>> Changes made were to the LP50xx to rework regmap_defaults to eliminate used
>> only once #defines.  Also fixed putting the child node in the dt parsing and
>> changed regmap regcache type to flat.
> Thanks. I applied 1 and 2 of the series to the for-next branch.

Thanks.  The DT files are not really a major issue.  But the defconfig 
is not sure who to ping to have them pull it.

Maybe Linus W?

Dan

> Best regards,
> 								Pavel
Shawn Guo Aug. 23, 2020, 12:52 a.m. UTC | #3 
On Wed, Aug 12, 2020 at 02:50:19PM -0500, Dan Murphy wrote:
> Add the reg property to each channel node.  This update is
> to accommodate the multicolor framework.  In addition to the
> accommodation this allows the LEDs to be placed on any channel
> and allow designs to skip channels as opposed to requiring
> sequential order.
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> CC: Shawn Guo <shawnguo@kernel.org>
> CC: Sascha Hauer <s.hauer@pengutronix.de>
> CC: Pengutronix Kernel Team <kernel@pengutronix.de>
> CC: Fabio Estevam <festevam@gmail.com>
> CC: NXP Linux Team <linux-imx@nxp.com>

Applied, thanks.
Linus Walleij Aug. 27, 2020, 10:58 p.m. UTC | #4 
On Wed, Aug 12, 2020 at 9:50 PM Dan Murphy <dmurphy@ti.com> wrote:

> Add the reg property to each channel node.  This update is
> to accommodate the multicolor framework.  In addition to the
> accommodation this allows the LEDs to be placed on any channel
> and allow designs to skip channels as opposed to requiring
> sequential order.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> CC: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Pavel Machek <pavel@ucw.cz>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

I don't knof if I should just apply these two patches or if there are
dependencies that need to go in first. I guess yes?

Yours,
Linus Walleij
Dan Murphy Aug. 28, 2020, 6:39 p.m. UTC | #5 
Linus

On 8/27/20 5:58 PM, Linus Walleij wrote:
> On Wed, Aug 12, 2020 at 9:50 PM Dan Murphy <dmurphy@ti.com> wrote:
>
>> Add the reg property to each channel node.  This update is
>> to accommodate the multicolor framework.  In addition to the
>> accommodation this allows the LEDs to be placed on any channel
>> and allow designs to skip channels as opposed to requiring
>> sequential order.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> CC: Linus Walleij <linus.walleij@linaro.org>
>> Acked-by: Pavel Machek <pavel@ucw.cz>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> I don't knof if I should just apply these two patches or if there are
> dependencies that need to go in first. I guess yes?

I believe all dependencies have been met for these

Dan

> Yours,
> Linus Walleij
Linus Walleij Sept. 7, 2020, 11:50 a.m. UTC | #6 
On Fri, Aug 28, 2020 at 8:39 PM Dan Murphy <dmurphy@ti.com> wrote:

> > I don't knof if I should just apply these two patches or if there are
> > dependencies that need to go in first. I guess yes?
>
> I believe all dependencies have been met for these

OK I applied this patch to the Ux500 tree!

Yours,
Linus Walleij