Message ID | 20200624161459.19248-1-dmurphy@ti.com |
---|---|
Headers | show |
Series | TAS2562 issue fixes and slot programming | expand |
On Wed, Jun 24, 2020 at 11:14:55AM -0500, Dan Murphy wrote: > Fix the issue found that there is an extra space before a comma in the > volume control. > > Fixes: bf726b1c86f2c ("ASoC: tas2562: Add support for digital volume control") > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > arch/arm/boot/compressed/fdt.h | 66 + > arch/arm/boot/compressed/libfdt.h | 2072 ++++++++++++++++++++ > arch/arm/boot/compressed/libfdt_internal.h | 173 ++ > sound/soc/codecs/tas2562.c | 2 +- I'm guessing those libfdt changes weren't supposed to be here?
Mark On 6/24/20 11:29 AM, Mark Brown wrote: > On Wed, Jun 24, 2020 at 11:14:55AM -0500, Dan Murphy wrote: >> Fix the issue found that there is an extra space before a comma in the >> volume control. >> >> Fixes: bf726b1c86f2c ("ASoC: tas2562: Add support for digital volume control") >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> arch/arm/boot/compressed/fdt.h | 66 + >> arch/arm/boot/compressed/libfdt.h | 2072 ++++++++++++++++++++ >> arch/arm/boot/compressed/libfdt_internal.h | 173 ++ >> sound/soc/codecs/tas2562.c | 2 +- > I'm guessing those libfdt changes weren't supposed to be here? No they were not those must have been added when I verified the build. Dan
Mark On 6/24/20 11:58 AM, Dan Murphy wrote: > Mark > > On 6/24/20 11:29 AM, Mark Brown wrote: >> On Wed, Jun 24, 2020 at 11:14:55AM -0500, Dan Murphy wrote: >>> Fix the issue found that there is an extra space before a comma in the >>> volume control. >>> >>> Fixes: bf726b1c86f2c ("ASoC: tas2562: Add support for digital volume >>> control") >>> Signed-off-by: Dan Murphy <dmurphy@ti.com> >>> --- >>> arch/arm/boot/compressed/fdt.h | 66 + >>> arch/arm/boot/compressed/libfdt.h | 2072 >>> ++++++++++++++++++++ >>> arch/arm/boot/compressed/libfdt_internal.h | 173 ++ >>> sound/soc/codecs/tas2562.c | 2 +- >> I'm guessing those libfdt changes weren't supposed to be here? > > No they were not those must have been added when I verified the build. > Can this patchset get a review as well so I can fix before I post v6? Not sure what the current work load is for review or merge. Dan > Dan >
On Wed, Jun 24, 2020 at 12:36:02PM -0500, Dan Murphy wrote: > Can this patchset get a review as well so I can fix before I post v6? > Not sure what the current work load is for review or merge. Well, it's less work to review if it's been fixed...
Mark On 6/24/20 12:48 PM, Mark Brown wrote: > On Wed, Jun 24, 2020 at 12:36:02PM -0500, Dan Murphy wrote: > >> Can this patchset get a review as well so I can fix before I post v6? >> Not sure what the current work load is for review or merge. > Well, it's less work to review if it's been fixed... Ok fixed and sent v6