From patchwork Wed May 6 21:15:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 1284778 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=LJ17gtKZ; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49HTsR3bwpz9sT0 for ; Thu, 7 May 2020 07:15:55 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729887AbgEFVPu (ORCPT ); Wed, 6 May 2020 17:15:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729804AbgEFVPd (ORCPT ); Wed, 6 May 2020 17:15:33 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6634AC03C1A6 for ; Wed, 6 May 2020 14:15:33 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id x2so1758556pfx.7 for ; Wed, 06 May 2020 14:15:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=u/XCL1fsewz1wv+0YN1B6q5DwndvHtJ46IG2XGKxKkc=; b=LJ17gtKZ5RCiSk4FFPSrLts9kY+6gVoaJHhHAK4elrJ5HYs7Re8PekuMrTMDTbowO/ SSluTHjRjYjytzyAq6hHqEC1n5fB2I22oH2gq4YFrhQCpZnhRo1qDJK3q5787DBLZiUz R62JQc4JS07Vmp2QpY7YmwMyVoRd5SXQcqqIU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=u/XCL1fsewz1wv+0YN1B6q5DwndvHtJ46IG2XGKxKkc=; b=E1Ne92i3LWJVdEGjk2i6gc0OR7y0NRNJjL4eYF+GpYXOY8w1WlbSEsBPj4ksRKAXyb qyEvnUiTxg3i0QsObf5zzQKXD9dJOhQhu1Oc+yPHWgcfCj1vcDndxo/Ls6lxx5XsHAt+ Jv9PSwY7qLuthaJKSCrwLKl4C7x3q1DeR6l6a0Twx4+ncUIGRwN6pUG7x1g69OK9ejM7 InIOlVSp4cSj+2D5ZIb64Jv0PXoS8i1eqE6kMTNMBM3w9XTWTmueVEP11SrLFCNFEkDX 6S+6wGDvn4g0wVSbmGM1mja0MLs54GU5Aoml7xjpNW6BUpIeO0WpoENbO5a4P9jLlwdB NwTw== X-Gm-Message-State: AGi0PuYp3H5f9glj3mpiXnvRUYgnUHgl6RS85FY3A/ZsoeBX8D1CgG3r sIOArOqgJAWmzDAqcjeU9/NUfw== X-Google-Smtp-Source: APiQypI/pTh6kOO0ohxDbY5vssPPtVaFSIZETH0t6dPMEwVl4GH4h+EMDj98Y0NsEBc9c6g4zYaF4w== X-Received: by 2002:a62:a11c:: with SMTP id b28mr2765864pff.180.1588799732927; Wed, 06 May 2020 14:15:32 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d2sm2752547pfc.7.2020.05.06.14.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2020 14:15:29 -0700 (PDT) From: Kees Cook To: Pavel Tatashin Cc: Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Rob Herring , Benson Leung , Enric Balletbo i Serra , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , jmorris@namei.org, sashal@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v3 0/6] allow ramoops to collect all kmesg_dump events Date: Wed, 6 May 2020 14:15:17 -0700 Message-Id: <20200506211523.15077-1-keescook@chromium.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi! This is my stab at rearranging a few things based on Pavel's series. Most things remain the same; I just tweaked how defaults are arranged and detected and expanded the wording in a few places. Pavel, how does this v3 look to you? Pavel's original cover letter: pstore /mnt/console-ramoops-0 outputs only messages below the console loglevel, and our console loglevel is set to 3 due to slowness of serial console. Which means only errors and worse types of messages are recorded. There is no way to have different log levels for different consoles. This patch series adds a new option to ramoops: max_reason that enables it to collect kmdesg dumps for other reasons beside oops and panics. How to quickly test: virtme-run --mods=auto --kdir --mods=auto --kdir . \ -a memmap=1G$8G -a ramoops.mem_address=0x200000000 \ -a ramoops.mem_size=0x100000 -a ramoops.record_size=32768 \ -a ramoops.max_reason=5 -a quiet --qemu-opts -m 8G .. # reboot -f After VM is back: # mount -t pstore pstore /mnt # head /mnt/dmesg-ramoops-0 Restart#1 Part1 ... Changelog: v3: - expanded several comments and commit logs - move max_reason member earlier in the structure - refactored DT parsing to allow setting defaults - changed how deprecated dump_oops fields are detected and parsed - cleaned up some module param permissions v2: https://lore.kernel.org/lkml/20200505154510.93506-1-pasha.tatashin@soleen.com v1: https://lore.kernel.org/lkml/20200502143555.543636-1-pasha.tatashin@soleen.com Thanks! -Kees Kees Cook (2): pstore/ram: Refactor DT size parsing pstore/ram: Adjust module param permissions to reflect reality Pavel Tatashin (4): printk: honor the max_reason field in kmsg_dumper pstore/platform: Pass max_reason to kmesg dump pstore/ram: Introduce max_reason and convert dump_oops ramoops: Add max_reason optional field to ramoops DT node Documentation/admin-guide/ramoops.rst | 14 +++- .../bindings/reserved-memory/ramoops.txt | 13 ++- drivers/platform/chrome/chromeos_pstore.c | 2 +- fs/pstore/platform.c | 4 +- fs/pstore/ram.c | 83 ++++++++++++------- include/linux/kmsg_dump.h | 1 + include/linux/pstore.h | 7 ++ include/linux/pstore_ram.h | 2 +- kernel/printk/printk.c | 15 +++- 9 files changed, 97 insertions(+), 44 deletions(-)