| Message ID | 20200110155225.1051749-1-icenowy@aosc.io |
|---|---|
| Headers | show |
| Series | Add support for Pine64 PineTab | expand |
Hi, On Fri, Jan 10, 2020 at 11:52:25PM +0800, Icenowy Zheng wrote: > PineTab is a 10.1" tablet by Pine64 with Allwinner A64 inside. > > It includes the following peripherals: > > USB: > - A microUSB Type-B port connected to the OTG-capable USB PHY of > Allwinner A64. The ID pin is connected to a GPIO of the A64 SoC, and the > Vbus is connected to the Vbus of AXP803 PMIC. These enables OTG > functionality on this port. > - A USB Type-A port is connected to the internal hub attached to the > non-OTG USB PHY of Allwinner A64. > - There are reserved pins for an external keyboard connected to the > internal hub. > > Power: > - The microUSB port has its Vbus connected to AXP803, mentioned above. > - A DC jack (of a strange size, 2.5mm outer diameter) is connected to > the ACIN of AXP803. > - A Li-Polymer battery is connected to the battery pins of AXP803. > > Storage: > - An tradition Pine64 eMMC slot is on the board, mounted with an eMMC > module by factory. > - An external microSD slot is hidden under a protect case. > > Display: > - A MIPI-DSI LCD panel (800x1280) is connected to the DSI port of A64 SoC. > - A mini HDMI port. > > Input: > - A touch panel attached to a Goodix GT9271 touch controller. > - Volume keys connected to the LRADC of the A64 SoC. > > Camera: > - An OV5640 CMOS camera is at rear, connected to the CSI bus of A64 SoC. > - A GC2145 CMOS camera is at front, shares the same CSI bus with OV5640. > > Audio: > - A headphone jack is conencted to the SoC's internal codec. > - A speaker connected is to the Line Out port of SoC's internal codec, via > an amplifier. > > Misc: > - Debug UART is muxed with the headphone jack, with the switch next to > the microSD slot. > - A bosch BMA223 accelerometer is connected to the I2C bus of A64 SoC. > - Wi-Fi and Bluetooth are available via a RTL8723CS chip, similar to the > one in Pinebook. > > This commit adds a basically usable device tree for it, implementing > most of the features mentioned above. HDMI is not supported now because > bad LCD-HDMI coexistence situation of mainline A64 display driver, and > the front camera currently lacks a driver and a facility to share the > bus with the rear one. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > --- > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../boot/dts/allwinner/sun50i-a64-pinetab.dts | 461 ++++++++++++++++++ > 2 files changed, 462 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > index cf4f78617c3f..6dad63881cd3 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -9,6 +9,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-plus.dtb sun50i-a64-pine64.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinebook.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts > new file mode 100644 > index 000000000000..1dfa3668636e > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts > @@ -0,0 +1,461 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (C) 2019 Icenowy Zheng <icenowy@aosc.xyz> > + * > + */ > + > +/dts-v1/; > + > +#include "sun50i-a64.dtsi" > + > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/input/input.h> > +#include <dt-bindings/pwm/pwm.h> > + > +/ { > + model = "PineTab"; > + compatible = "pine64,pinetab", "allwinner,sun50i-a64"; > + > + aliases { > + serial0 = &uart0; > + ethernet0 = &rtl8723cs; > + }; > + > + backlight: backlight { > + compatible = "pwm-backlight"; > + pwms = <&pwm 0 50000 PWM_POLARITY_INVERTED>; > + brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; Each step should be a perceived step, not a decimal one. So let's say, if you have 10 steps, each step should be seen as a 10% increase in brightness. Usually a quadratic increase works better there. > +&dsi { > + vcc-dsi-supply = <®_dldo1>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "okay"; address-cells and size-cells aren't in the DTSI? They should be. > + > + panel@0 { > + compatible = "feixin,k101-im2ba02"; > + reg = <0>; > + avdd-supply = <®_dc1sw>; > + dvdd-supply = <®_dc1sw>; > + cvdd-supply = <®_ldo_io1>; > + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ > + backlight = <&backlight>; > + }; > +}; > + > +&ehci0 { > + status = "okay"; > +}; > + > +&ehci1 { > + status = "okay"; > +}; > + > +&i2c0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c0_pins>; That should be set in the DTSI already? > + status = "okay"; > + > + touchscreen@5d { > + compatible = "goodix,gt9271"; > + reg = <0x5d>; > + interrupt-parent = <&pio>; > + interrupts = <7 4 IRQ_TYPE_LEVEL_HIGH>; /* PH4 */ > + irq-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */ > + reset-gpios = <&pio 7 8 GPIO_ACTIVE_HIGH>; /* PH8 */ > + AVDD28-supply = <®_ldo_io1>; > + }; > +}; > + > +&i2c0_pins { > + bias-pull-up; > +}; > + > +&i2c1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; Ditto > + status = "okay"; > + > + bma223@18 { > + compatible = "bosch,bma223", "bosch,bma222e"; > + reg = <0x18>; > + interrupt-parent = <&pio>; > + interrupts = <7 5 IRQ_TYPE_LEVEL_HIGH>; /* PH5 */ > + mount-matrix = "0", "-1", "0", > + "-1", "0", "0", > + "0", "0", "-1"; > + }; > +}; > + > +&lradc { > + vref-supply = <®_aldo3>; > + status = "okay"; > + > + button-200 { > + label = "Volume Up"; > + linux,code = <KEY_VOLUMEUP>; > + channel = <0>; > + voltage = <200000>; > + }; > + > + button-400 { > + label = "Volume Down"; > + linux,code = <KEY_VOLUMEDOWN>; > + channel = <0>; > + voltage = <400000>; > + }; > +}; > + > +&mixer1 { > + status = "okay"; > +}; > + > +&mmc0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc0_pins>; Ditto > + vmmc-supply = <®_dcdc1>; > + cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; > + disable-wp; > + bus-width = <4>; > + status = "okay"; > +}; > + > +&mmc1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc1_pins>; Ditto > + vmmc-supply = <®_dldo4>; > + vqmmc-supply = <®_eldo1>; > + mmc-pwrseq = <&wifi_pwrseq>; > + bus-width = <4>; > + non-removable; > + status = "okay"; > + > + rtl8723cs: wifi@1 { > + reg = <1>; > + }; > +}; > + > +&mmc2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc2_pins>; Ditto Looks good otherwise, thanks! Maxime
Hi Icenowy. On Fri, Jan 10, 2020 at 11:52:23PM +0800, Icenowy Zheng wrote: > Feixin K101 IM2BA02 is a 800x1280 4-lane MIPI-DSI LCD panel. > > Add a panel driver for it. Thanks, driver looks really good. Only a few comments/nits below. Sam > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > --- > MAINTAINERS | 6 + > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > .../gpu/drm/panel/panel-feixin-k101-im2ba02.c | 548 ++++++++++++++++++ > 4 files changed, 564 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c > > new file mode 100644 > index 000000000000..45a62bdabb3f > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c > @@ -0,0 +1,548 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2019-2020 Icenowy Zheng <icenowy@aosc.io> > + */ > + > +#include <linux/gpio/consumer.h> > +#include <linux/delay.h> > +#include <linux/mod_devicetable.h> > +#include <linux/module.h> > +#include <linux/of_device.h> > +#include <linux/regulator/consumer.h> > + > +#include <drm/drm_mipi_dsi.h> > +#include <drm/drm_modes.h> > +#include <drm/drm_panel.h> > +#include <drm/drm_print.h> Sorted and in the right order - good. > + > +static int k101_im2ba02_prepare(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + struct mipi_dsi_device *dsi = ctx->dsi; > + unsigned int i; > + int ret; > + > + ret = regulator_enable(ctx->avdd); > + if (ret) > + return ret; > + > + msleep(20); > + > + ret = regulator_enable(ctx->dvdd); > + if (ret) > + return ret; > + > + msleep(20); > + > + ret = regulator_enable(ctx->cvdd); > + if (ret) > + return ret; Unless the msleep() between is regulator_enable() really is needed, this change this to use regulator_bulk_enable(). If the above is kept then please do proper error handling where all enabled regulators are disable in case of errors. > + > + msleep(30); > + > + gpiod_set_value(ctx->reset, 1); > + msleep(50); > + > + gpiod_set_value(ctx->reset, 0); > + msleep(50); > + > + gpiod_set_value(ctx->reset, 1); > + msleep(200); > + > + for (i = 0; i < ARRAY_SIZE(k101_im2ba02_init_cmds); i++) { > + const struct k101_im2ba02_init_cmd *cmd = &k101_im2ba02_init_cmds[i]; > + > + ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, K101_IM2BA02_INIT_CMD_LEN); > + if (ret < 0) > + return ret; > + } > + > + return 0; > +} > + > +static int k101_im2ba02_enable(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + const struct k101_im2ba02_init_cmd *cmd = &timed_cmds[1]; > + int ret; > + > + msleep(150); > + > + ret = mipi_dsi_dcs_set_display_on(ctx->dsi); > + if (ret < 0) > + return ret; > + > + msleep(50); > + > + return mipi_dsi_dcs_write_buffer(ctx->dsi, cmd->data, K101_IM2BA02_INIT_CMD_LEN); > + if (ret < 0) > + return ret; The last two lines can be deleted - they are never reached. > +} > + > +static int k101_im2ba02_disable(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + > + return mipi_dsi_dcs_set_display_off(ctx->dsi); > +} > + > +static int k101_im2ba02_unprepare(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + int ret; > + > + ret = mipi_dsi_dcs_set_display_off(ctx->dsi); > + if (ret < 0) > + DRM_DEV_ERROR(panel->dev, "failed to set display off: %d\n", > + ret); > + > + ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); > + if (ret < 0) > + DRM_DEV_ERROR(panel->dev, "failed to enter sleep mode: %d\n", > + ret); > + > + msleep(200); > + > + gpiod_set_value(ctx->reset, 0); > + > + msleep(20); > + > + regulator_disable(ctx->cvdd); > + > + msleep(20); > + > + regulator_disable(ctx->dvdd); > + > + msleep(20); > + > + regulator_disable(ctx->avdd); Can we get rid of a few empty lines here? If the 20 msecs are not really needed then use regulator_bulk_disable() > + return 0; > +} > + > +static const struct drm_display_mode k101_im2ba02_default_mode = { > + .clock = 70000, > + .vrefresh = 60, > + > + .hdisplay = 800, > + .hsync_start = 800 + 20, > + .hsync_end = 800 + 20 + 20, > + .htotal = 800 + 20 + 20 + 20, > + > + .vdisplay = 1280, > + .vsync_start = 1280 + 16, > + .vsync_end = 1280 + 16 + 4, > + .vtotal = 1280 + 16 + 4 + 4, > + > + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, > + .width_mm = 136, > + .height_mm = 217, > +}; > + > +static int k101_im2ba02_get_modes(struct drm_panel *panel, > + struct drm_connector *connector) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + struct drm_display_mode *mode; > + > + mode = drm_mode_duplicate(connector->dev, &k101_im2ba02_default_mode); > + if (!mode) { > + DRM_DEV_ERROR(&ctx->dsi->dev, "failed to add mode %ux%ux@%u\n", > + k101_im2ba02_default_mode.hdisplay, > + k101_im2ba02_default_mode.vdisplay, > + k101_im2ba02_default_mode.vrefresh); > + return -ENOMEM; > + } > + > + drm_mode_set_name(mode); > + > + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; > + connector->display_info.width_mm = mode->width_mm; > + connector->display_info.height_mm = mode->height_mm; > + drm_mode_probed_add(connector, mode); > + > + return 1; > +} > + > +static const struct drm_panel_funcs k101_im2ba02_funcs = { > + .disable = k101_im2ba02_disable, > + .unprepare = k101_im2ba02_unprepare, > + .prepare = k101_im2ba02_prepare, > + .enable = k101_im2ba02_enable, > + .get_modes = k101_im2ba02_get_modes, > +}; > + > +static int k101_im2ba02_dsi_probe(struct mipi_dsi_device *dsi) > +{ > + struct k101_im2ba02 *ctx; > + int ret; > + > + ctx = devm_kzalloc(&dsi->dev, sizeof(*ctx), GFP_KERNEL); > + if (!ctx) > + return -ENOMEM; > + > + mipi_dsi_set_drvdata(dsi, ctx); > + ctx->dsi = dsi; > + > + ctx->dvdd = devm_regulator_get(&dsi->dev, "dvdd"); > + if (IS_ERR(ctx->dvdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get dvdd regulator\n"); > + return PTR_ERR(ctx->dvdd); > + } > + > + ctx->avdd = devm_regulator_get(&dsi->dev, "avdd"); > + if (IS_ERR(ctx->avdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get avdd regulator\n"); > + return PTR_ERR(ctx->avdd); > + } > + > + ctx->cvdd = devm_regulator_get(&dsi->dev, "cvdd"); > + if (IS_ERR(ctx->cvdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get cvdd regulator\n"); > + return PTR_ERR(ctx->cvdd); > + } > + > + ctx->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW); > + if (IS_ERR(ctx->reset)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get our reset GPIO\n"); > + return PTR_ERR(ctx->reset); > + } > + > + drm_panel_init(&ctx->panel, &dsi->dev, &k101_im2ba02_funcs, > + DRM_MODE_CONNECTOR_DSI); > + > + ret = drm_panel_of_backlight(&ctx->panel); > + if (ret) > + return ret; > + > + ret = drm_panel_add(&ctx->panel); > + if (ret < 0) > + return ret; > + > + dsi->mode_flags = MIPI_DSI_MODE_VIDEO; > + dsi->format = MIPI_DSI_FMT_RGB888; > + dsi->lanes = 4; > + > + ret = mipi_dsi_attach(dsi); > + if (ret < 0) { > + drm_panel_remove(&ctx->panel); > + return ret; > + } > + > + return 0; > +} > + > +static int k101_im2ba02_dsi_remove(struct mipi_dsi_device *dsi) > +{ > + struct k101_im2ba02 *ctx = mipi_dsi_get_drvdata(dsi); > + > + mipi_dsi_detach(dsi); > + drm_panel_remove(&ctx->panel); > + > + return 0; > +} > + > +static const struct of_device_id k101_im2ba02_of_match[] = { > + { .compatible = "feixin,k101-im2ba02", }, > + { } Use { /* sentinel */ }, > +}; > +MODULE_DEVICE_TABLE(of, k101_im2ba02_of_match); > + > +static struct mipi_dsi_driver k101_im2ba02_driver = { > + .probe = k101_im2ba02_dsi_probe, > + .remove = k101_im2ba02_dsi_remove, > + .driver = { > + .name = "feixin-k101-im2ba02", > + .of_match_table = k101_im2ba02_of_match, > + }, > +}; > +module_mipi_dsi_driver(k101_im2ba02_driver); > + > +MODULE_AUTHOR("Icenowy Zheng <icenowy@aosc.io>"); > +MODULE_DESCRIPTION("Feixin K101 IM2BA02 MIPI-DSI LCD panel"); > +MODULE_LICENSE("GPL"); > -- > 2.23.0
Hi Icenowy. checkpatch noticed a small inconsistency in the i2c1 node. > > Misc: > - Debug UART is muxed with the headphone jack, with the switch next to > the microSD slot. > - A bosch BMA223 accelerometer is connected to the I2C bus of A64 SoC. > - Wi-Fi and Bluetooth are available via a RTL8723CS chip, similar to the > one in Pinebook. > > + > +&i2c1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; > + status = "okay"; > + > + bma223@18 { > + compatible = "bosch,bma223", "bosch,bma222e"; These compatible have no binding file?!? > + reg = <0x18>; > + interrupt-parent = <&pio>; > + interrupts = <7 5 IRQ_TYPE_LEVEL_HIGH>; /* PH5 */ > + mount-matrix = "0", "-1", "0", > + "-1", "0", "0", > + "0", "0", "-1"; > + }; > +}; bosch,bma222e is referenced by a driver, whereas this is the first reference of bosch,bma223. Sam
On Fri, Jan 10, 2020 at 7:54 AM Icenowy Zheng <icenowy@aosc.io> wrote: > > PineTab is a 10.1" tablet by Pine64 with Allwinner A64 inside. > > It includes the following peripherals: > > USB: > - A microUSB Type-B port connected to the OTG-capable USB PHY of > Allwinner A64. The ID pin is connected to a GPIO of the A64 SoC, and the > Vbus is connected to the Vbus of AXP803 PMIC. These enables OTG > functionality on this port. > - A USB Type-A port is connected to the internal hub attached to the > non-OTG USB PHY of Allwinner A64. > - There are reserved pins for an external keyboard connected to the > internal hub. > > Power: > - The microUSB port has its Vbus connected to AXP803, mentioned above. > - A DC jack (of a strange size, 2.5mm outer diameter) is connected to > the ACIN of AXP803. > - A Li-Polymer battery is connected to the battery pins of AXP803. > > Storage: > - An tradition Pine64 eMMC slot is on the board, mounted with an eMMC > module by factory. > - An external microSD slot is hidden under a protect case. > > Display: > - A MIPI-DSI LCD panel (800x1280) is connected to the DSI port of A64 SoC. > - A mini HDMI port. > > Input: > - A touch panel attached to a Goodix GT9271 touch controller. > - Volume keys connected to the LRADC of the A64 SoC. > > Camera: > - An OV5640 CMOS camera is at rear, connected to the CSI bus of A64 SoC. > - A GC2145 CMOS camera is at front, shares the same CSI bus with OV5640. > > Audio: > - A headphone jack is conencted to the SoC's internal codec. > - A speaker connected is to the Line Out port of SoC's internal codec, via > an amplifier. > > Misc: > - Debug UART is muxed with the headphone jack, with the switch next to > the microSD slot. > - A bosch BMA223 accelerometer is connected to the I2C bus of A64 SoC. > - Wi-Fi and Bluetooth are available via a RTL8723CS chip, similar to the > one in Pinebook. > > This commit adds a basically usable device tree for it, implementing > most of the features mentioned above. HDMI is not supported now because > bad LCD-HDMI coexistence situation of mainline A64 display driver, and > the front camera currently lacks a driver and a facility to share the > bus with the rear one. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > --- > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../boot/dts/allwinner/sun50i-a64-pinetab.dts | 461 ++++++++++++++++++ > 2 files changed, 462 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > index cf4f78617c3f..6dad63881cd3 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -9,6 +9,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-plus.dtb sun50i-a64-pine64.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinebook.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts > new file mode 100644 > index 000000000000..1dfa3668636e > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts > @@ -0,0 +1,461 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (C) 2019 Icenowy Zheng <icenowy@aosc.xyz> > + * > + */ > + > +/dts-v1/; > + > +#include "sun50i-a64.dtsi" You may want to include dtsi with OPP for A64 here if you want to enable DVFS > + > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/input/input.h> > +#include <dt-bindings/pwm/pwm.h> > + > +/ { > + model = "PineTab"; > + compatible = "pine64,pinetab", "allwinner,sun50i-a64"; > + > + aliases { > + serial0 = &uart0; > + ethernet0 = &rtl8723cs; > + }; > + > + backlight: backlight { > + compatible = "pwm-backlight"; > + pwms = <&pwm 0 50000 PWM_POLARITY_INVERTED>; > + brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>; > + default-brightness-level = <8>; > + enable-gpios = <&pio 3 23 GPIO_ACTIVE_HIGH>; /* PD23 */ > + power-supply = <&vdd_bl>; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + i2c-csi { > + compatible = "i2c-gpio"; > + sda-gpios = <&pio 4 13 GPIO_ACTIVE_HIGH>; /* PE13 */ > + scl-gpios = <&pio 4 12 GPIO_ACTIVE_HIGH>; /* PE12 */ > + i2c-gpio,delay-us = <5>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* Rear camera */ > + ov5640: camera@3c { > + compatible = "ovti,ov5640"; > + reg = <0x3c>; > + pinctrl-names = "default"; > + pinctrl-0 = <&csi_mclk_pin>; > + clocks = <&ccu CLK_CSI_MCLK>; > + clock-names = "xclk"; > + > + AVDD-supply = <®_dldo3>; > + DOVDD-supply = <®_aldo1>; > + DVDD-supply = <®_eldo3>; > + reset-gpios = <&pio 4 14 GPIO_ACTIVE_LOW>; /* PE14 */ > + powerdown-gpios = <&pio 4 15 GPIO_ACTIVE_HIGH>; /* PE15 */ > + > + port { > + ov5640_ep: endpoint { > + remote-endpoint = <&csi_ep>; > + bus-width = <8>; > + hsync-active = <1>; /* Active high */ > + vsync-active = <0>; /* Active low */ > + data-active = <1>; /* Active high */ > + pclk-sample = <1>; /* Rising */ > + }; > + }; > + }; > + }; > + > + speaker_amp: audio-amplifier { > + compatible = "simple-audio-amplifier"; > + enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */ > + sound-name-prefix = "Speaker Amp"; > + }; > + > + vdd_bl: regulator@0 { > + compatible = "regulator-fixed"; > + regulator-name = "bl-3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&pio 7 6 GPIO_ACTIVE_HIGH>; /* PH6 */ > + enable-active-high; > + }; > + > + wifi_pwrseq: wifi_pwrseq { > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */ > + post-power-on-delay-ms = <200>; > + }; > +}; > + > +&codec { > + status = "okay"; > +}; > + > +&codec_analog { > + hpvcc-supply = <®_eldo1>; > + status = "okay"; > +}; > + > +&cpu0 { > + cpu-supply = <®_dcdc2>; > +}; I believe you need CPU regulator for each CPU. I'm aware that we share clock and regulator for all the CPUs but what would happen if you put CPU0 offline? > + > +&csi { > + status = "okay"; > + > + port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + csi_ep: endpoint { > + remote-endpoint = <&ov5640_ep>; > + bus-width = <8>; > + hsync-active = <1>; /* Active high */ > + vsync-active = <0>; /* Active low */ > + data-active = <1>; /* Active high */ > + pclk-sample = <1>; /* Rising */ > + }; > + }; > +}; > + > +&dai { > + status = "okay"; > +}; > + > +&de { > + status = "okay"; > +}; > + > +&dphy { > + status = "okay"; > +}; > + > +&dsi { > + vcc-dsi-supply = <®_dldo1>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "okay"; > + > + panel@0 { > + compatible = "feixin,k101-im2ba02"; > + reg = <0>; > + avdd-supply = <®_dc1sw>; > + dvdd-supply = <®_dc1sw>; > + cvdd-supply = <®_ldo_io1>; > + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ > + backlight = <&backlight>; > + }; > +}; > + > +&ehci0 { > + status = "okay"; > +}; > + > +&ehci1 { > + status = "okay"; > +}; > + > +&i2c0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c0_pins>; > + status = "okay"; > + > + touchscreen@5d { > + compatible = "goodix,gt9271"; > + reg = <0x5d>; > + interrupt-parent = <&pio>; > + interrupts = <7 4 IRQ_TYPE_LEVEL_HIGH>; /* PH4 */ > + irq-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */ > + reset-gpios = <&pio 7 8 GPIO_ACTIVE_HIGH>; /* PH8 */ > + AVDD28-supply = <®_ldo_io1>; > + }; > +}; > + > +&i2c0_pins { > + bias-pull-up; > +}; > + > +&i2c1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; > + status = "okay"; > + > + bma223@18 { > + compatible = "bosch,bma223", "bosch,bma222e"; > + reg = <0x18>; > + interrupt-parent = <&pio>; > + interrupts = <7 5 IRQ_TYPE_LEVEL_HIGH>; /* PH5 */ > + mount-matrix = "0", "-1", "0", > + "-1", "0", "0", > + "0", "0", "-1"; > + }; > +}; > + > +&lradc { > + vref-supply = <®_aldo3>; > + status = "okay"; > + > + button-200 { > + label = "Volume Up"; > + linux,code = <KEY_VOLUMEUP>; > + channel = <0>; > + voltage = <200000>; > + }; > + > + button-400 { > + label = "Volume Down"; > + linux,code = <KEY_VOLUMEDOWN>; > + channel = <0>; > + voltage = <400000>; > + }; > +}; > + > +&mixer1 { > + status = "okay"; > +}; > + > +&mmc0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc0_pins>; > + vmmc-supply = <®_dcdc1>; > + cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; > + disable-wp; > + bus-width = <4>; > + status = "okay"; > +}; > + > +&mmc1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc1_pins>; > + vmmc-supply = <®_dldo4>; > + vqmmc-supply = <®_eldo1>; > + mmc-pwrseq = <&wifi_pwrseq>; > + bus-width = <4>; > + non-removable; > + status = "okay"; > + > + rtl8723cs: wifi@1 { > + reg = <1>; > + }; > +}; > + > +&mmc2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc2_pins>; > + vmmc-supply = <®_dcdc1>; > + vqmmc-supply = <®_dcdc1>; > + bus-width = <8>; > + non-removable; > + cap-mmc-hw-reset; > + status = "okay"; > +}; > + > +&ohci0 { > + status = "okay"; > +}; > + > +&pwm { > + status = "okay"; > +}; > + > +&r_rsb { > + status = "okay"; > + > + axp803: pmic@3a3 { > + compatible = "x-powers,axp803"; > + reg = <0x3a3>; > + interrupt-parent = <&r_intc>; > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > + x-powers,drive-vbus-en; > + }; > +}; > + > +#include "axp803.dtsi" > + > +&ac_power_supply { > + status = "okay"; > +}; > + > +&battery_power_supply { > + status = "okay"; > +}; > + > +®_aldo1 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + regulator-name = "dovdd-csi"; > +}; > + > +®_aldo2 { > + regulator-always-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vcc-pl"; > +}; > + > +®_aldo3 { > + regulator-always-on; > + regulator-min-microvolt = <2700000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vcc-pll-avcc"; > +}; > + > +®_dc1sw { > + regulator-name = "vcc-lcd"; > +}; > + > +®_dcdc1 { > + regulator-always-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vcc-3v3"; > +}; > + > +®_dcdc2 { > + regulator-always-on; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1300000>; > + regulator-name = "vdd-cpux"; > +}; > + > +/* DCDC3 is polyphased with DCDC2 */ > + > +®_dcdc5 { > + regulator-always-on; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-name = "vcc-dram"; > +}; > + > +®_dcdc6 { > + regulator-always-on; > + regulator-min-microvolt = <1100000>; > + regulator-max-microvolt = <1100000>; > + regulator-name = "vdd-sys"; > +}; > + > +®_dldo1 { > + regulator-always-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vcc-hdmi-dsi-sensor"; > +}; > + > +®_dldo3 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + regulator-name = "avdd-csi"; > +}; > + > +®_dldo4 { > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vcc-wifi"; > +}; > + > +®_drivevbus { > + regulator-name = "usb0-vbus"; > + status = "okay"; > +}; > + > +®_eldo1 { > + regulator-always-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-name = "cpvdd"; > +}; > + > +®_eldo2 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-name = "vcca-1v8"; > +}; > + > +®_eldo3 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-name = "dvdd-1v8-csi"; > +}; > + > +®_fldo1 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-name = "vcc-1v2-hsic"; > +}; > + > +®_fldo2 { > + regulator-always-on; > + regulator-min-microvolt = <1100000>; > + regulator-max-microvolt = <1100000>; > + regulator-name = "vdd-cpus"; > +}; > + > +®_ldo_io0 { > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vcc-usb"; > + status = "okay"; > +}; > + > +®_ldo_io1 { > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-enable-ramp-delay = <3500000>; > + regulator-name = "vcc-touchscreen"; > + status = "okay"; > +}; > + > +®_rtc_ldo { > + regulator-name = "vcc-rtc"; > +}; > + > +&sound { > + status = "okay"; > + simple-audio-card,aux-devs = <&codec_analog>, <&speaker_amp>; > + simple-audio-card,widgets = "Microphone", "Internal Microphone Left", > + "Microphone", "Internal Microphone Right", > + "Headphone", "Headphone Jack", > + "Speaker", "Internal Speaker"; > + simple-audio-card,routing = > + "Left DAC", "AIF1 Slot 0 Left", > + "Right DAC", "AIF1 Slot 0 Right", > + "Speaker Amp INL", "LINEOUT", > + "Speaker Amp INR", "LINEOUT", > + "Internal Speaker", "Speaker Amp OUTL", > + "Internal Speaker", "Speaker Amp OUTR", > + "Headphone Jack", "HP", > + "AIF1 Slot 0 Left ADC", "Left ADC", > + "AIF1 Slot 0 Right ADC", "Right ADC", > + "Internal Microphone Left", "MBIAS", > + "MIC1", "Internal Microphone Left", > + "Internal Microphone Right", "HBIAS", > + "MIC2", "Internal Microphone Right"; > +}; > + > +&uart0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart0_pb_pins>; > + status = "okay"; > +}; > + > +&usb_otg { > + dr_mode = "otg"; > + status = "okay"; > +}; > + > +&usb_power_supply { > + status = "okay"; > +}; > + > +&usbphy { > + usb0_id_det-gpios = <&pio 7 9 GPIO_ACTIVE_HIGH>; /* PH9 */ > + usb0_vbus_power-supply = <&usb_power_supply>; > + usb0_vbus-supply = <®_drivevbus>; > + usb1_vbus-supply = <®_ldo_io0>; > + status = "okay"; > +}; > -- > 2.23.0 > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20200110155225.1051749-6-icenowy%40aosc.io.