Message ID | 20191202174831.13638-1-angus@akkea.ca |
---|---|
Headers | show |
Series | Add the broadmobi BM818 | expand |
On Mon, Dec 02, 2019 at 10:48:29AM -0700, Angus Ainslie (Purism) wrote: > sound: codecs: gtm601: add Broadmobi bm818 sound profile > ASoC: gtm601: add the broadmobi interface These subject styles don't even agree with each other :( - please try to be consistent with the style for the subsystem (the latter one matches, the first one doesn't). Please also try to think about your CC lists when sending patches, try to understand why everyone you're sending them to is getting a copy - kernel maintainers get a lot of mail and sending not obviously relevant patches to random people adds to that.
On Mon, Dec 02, 2019 at 10:48:30AM -0700, Angus Ainslie (Purism) wrote: > + if (np && of_device_is_compatible(np, "broadmobi,bm818")) > + dai_driver = &bm818_dai; Rather than having a tree of these it'd be better if... > #if defined(CONFIG_OF) > static const struct of_device_id gtm601_codec_of_match[] = { > { .compatible = "option,gtm601", }, > + { .compatible = "broadmobi,bm818", }, > {}, > }; ...this used the data you can provide along with the of_match as the dai_driver so the probe function doesn't have to know about the individual variants.
Hi Mark, On 2019-12-03 07:27, Mark Brown wrote: > On Mon, Dec 02, 2019 at 10:48:29AM -0700, Angus Ainslie (Purism) wrote: > >> sound: codecs: gtm601: add Broadmobi bm818 sound profile >> ASoC: gtm601: add the broadmobi interface > > These subject styles don't even agree with each other :( - please > try to be consistent with the style for the subsystem (the latter > one matches, the first one doesn't). > Ok I'll fix that. I pulled those out of previous commit messages of those files. > Please also try to think about your CC lists when sending > patches, try to understand why everyone you're sending them to is > getting a copy - kernel maintainers get a lot of mail and sending > not obviously relevant patches to random people adds to that. I used the output of ./scripts/get_maintainer.pl . Is that not the correct way to generate the CC list ? Thanks Angus