Message ID | 20191106060301.17408-1-joel@jms.id.au |
---|---|
Headers | show |
Series | clocksource: Add ast2600 support to fttmr010 | expand |
On Wed, Nov 6, 2019 at 7:03 AM Joel Stanley <joel@jms.id.au> wrote: > In preparation for supporting the ast2600 which uses a different method > to clear bits in the control register, use a callback for performing the > shutdown sequence. > > Signed-off-by: Joel Stanley <joel@jms.id.au> Nice refactoring! Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Wed, Nov 6, 2019 at 7:03 AM Joel Stanley <joel@jms.id.au> wrote: > In preparation for supporting the ast2600, pass the shutdown and > interrupt functions to the common init callback. > > Signed-off-by: Joel Stanley <joel@jms.id.au> Provided the latter patches making use of it are OKed; Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Wed, Nov 6, 2019 at 7:03 AM Joel Stanley <joel@jms.id.au> wrote: > The ast2600 has some minor differences to previous versions. The > interrupt handler must acknowledge the timer interrupt in a status > register. Secondly the control register becomes write to set only, > requiring the use of a separate set to clear register. > > Signed-off-by: Joel Stanley <joel@jms.id.au> > +/* > + Control register set to clear for ast2600 only. > + */ > +#define TIMER_CR_CLR (0x3c) If it is AST2600-specific then please add some AST2600 prefix such as AST2600_TIMER_CR_CLR (0x3c) With that: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Thu, 7 Nov 2019 at 07:47, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Nov 6, 2019 at 7:03 AM Joel Stanley <joel@jms.id.au> wrote: > > > In preparation for supporting the ast2600 which uses a different method > > to clear bits in the control register, use a callback for performing the > > shutdown sequence. > > > > Signed-off-by: Joel Stanley <joel@jms.id.au> > > Nice refactoring! Cheers. Thank you for the prompt review! > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Yours, > Linus Walleij