| Message ID | 20190827163252.4982af95@xhacker.debian |
|---|---|
| Headers | show |
| Series | regulator: support Silergy SY8824C/SY8824E etc. | expand |
On Tue, Aug 27, 2019 at 08:45:33AM +0000, Jisheng Zhang wrote: This looks mostly good and I'll apply it, a couple of small things though: > @@ -0,0 +1,192 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * SY8824C regulator driver > + * Please send a patch which updates the entire comment block to be C++ style so it looks consistent. > +#define BUCK_EN (1 << 7) > +#define MODE (1 << 6) > + Please also add prefixes to these to namespace them, especially MODE is likely to collide with something later.
Hi Mark, On Tue, 27 Aug 2019 20:44:37 +0100 Mark Brown wrote: > On Tue, Aug 27, 2019 at 08:45:33AM +0000, Jisheng Zhang wrote: > > This looks mostly good and I'll apply it, a couple of small > things though: > > > @@ -0,0 +1,192 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * SY8824C regulator driver > > + * > > Please send a patch which updates the entire comment block to be > C++ style so it looks consistent. Do you mean update the following style A: // SPDX-License-Identifier: GPL-2.0 /* * SY8824C regulator driver * ... as B: // SPDX-License-Identifier: GPL-2.0 // SY8824C regulator driver // ... I'm not sure which style is correct. But I see B is commonly used in lots .c source files in other dirs, such as kernel/ mm/ etc. Could you please clarify? Thanks > > > +#define BUCK_EN (1 << 7) > > +#define MODE (1 << 6) > > + > > Please also add prefixes to these to namespace them, especially > MODE is likely to collide with something later. good idea. Will do in newer version
On Wed, 28 Aug 2019 11:27:05 +0800 Jisheng Zhang wrote: > Hi Mark, > > On Tue, 27 Aug 2019 20:44:37 +0100 Mark Brown wrote: > > > On Tue, Aug 27, 2019 at 08:45:33AM +0000, Jisheng Zhang wrote: > > > > This looks mostly good and I'll apply it, a couple of small > > things though: > > > > > @@ -0,0 +1,192 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * SY8824C regulator driver > > > + * > > > > Please send a patch which updates the entire comment block to be > > C++ style so it looks consistent. > > Do you mean update the following style > > A: > > // SPDX-License-Identifier: GPL-2.0 > /* > * SY8824C regulator driver > * ... > > > as B: > > // SPDX-License-Identifier: GPL-2.0 > // SY8824C regulator driver > // ... > > I'm not sure which style is correct. But I see B is commonly used sorry, typo. I mean "I see A is commonly used ..." > in lots .c source files in other dirs, such as kernel/ mm/ etc. > > Could you please clarify? > > Thanks > > > > > > +#define BUCK_EN (1 << 7) > > > +#define MODE (1 << 6) > > > + > > > > Please also add prefixes to these to namespace them, especially > > MODE is likely to collide with something later. > > good idea. Will do in newer version
On Wed, Aug 28, 2019 at 03:38:29AM +0000, Jisheng Zhang wrote: > On Tue, 27 Aug 2019 20:44:37 +0100 Mark Brown wrote: > > > > Please send a patch which updates the entire comment block to be > > C++ style so it looks consistent. > Do you mean update the following style > A: > > // SPDX-License-Identifier: GPL-2.0 > /* > * SY8824C regulator driver > * ... > as B: > // SPDX-License-Identifier: GPL-2.0 > // SY8824C regulator driver > // ... > I'm not sure which style is correct. But I see B is commonly used > in lots .c source files in other dirs, such as kernel/ mm/ etc. Yes, please - update to style B.