| Message ID | 20181214151214.5391-1-pawel.mikolaj.chmiel@gmail.com |
|---|---|
| Headers | show |
| Series | Input: atmel_mxt_ts: Add support for optional regulators | expand |
On Fri, Dec 14, 2018 at 04:12:13PM +0100, Paweł Chmiel wrote: > According to documentation, device isn't ready for communication, > until firmware asserts the CHG line. Add missing wait for this. > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > --- > Changes from v1: > - Fix checkpatch issues > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c > index 55a107fc1b73..e8949c6ceafa 100644 > --- a/drivers/input/touchscreen/atmel_mxt_ts.c > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c > @@ -202,6 +202,7 @@ enum t100_type { > #define MXT_CRC_TIMEOUT 1000 /* msec */ > #define MXT_FW_RESET_TIME 3000 /* msec */ > #define MXT_FW_CHG_TIMEOUT 300 /* msec */ > +#define MXT_POWERON_DELAY 150 /* msec */ > > /* Command to unlock bootloader */ > #define MXT_UNLOCK_CMD_MSB 0xaa > @@ -3070,6 +3071,16 @@ static int mxt_regulator_enable(struct mxt_data *data) > msleep(MXT_REGULATOR_DELAY); > gpiod_set_value(data->reset_gpio, 1); > msleep(MXT_RESET_INVALID_CHG); > + > +retry_wait: > + reinit_completion(&data->bl_completion); > + data->in_bootloader = true; I think you would want to reinit the ocmpletion and set the flag before releasing reset line and sleeping, otherwise if interrupt fires too early you'll be spinning for extra time. I'd also really want to hear from Nick on this change. > + error = mxt_wait_for_completion(data, &data->bl_completion, > + MXT_POWERON_DELAY); > + if (error == -EINTR) > + goto retry_wait; > + > + data->in_bootloader = false; > } > > return 0; > -- > 2.17.1 > Thanks.
This patch series adds optional regulator support to atmel_mxt_ts. First patch adds regulators to driver. Second patch ensures that device is ready for communication. Third patch updates documentation. Changes from v4: - Add missing regulator_disable for vdd in case of error, when enabling avdd regulator Changes from v3: - Checkpatch fixes - Drop punctuation from subject of one of patches Changes from v2: - Add reviewed-by to one patch - Move code for enabling regulators into separate method, to make code more readable. - Add wait code, to ensure that device is ready for communication. Changes from v1: - Enable regulators only if reset_gpio is present. - Switch from devm_regulator_get_optional to devm_regulator_get. Paweł Chmiel (3): Input: atmel_mxt_ts: Add support for optional regulators Input: atmel_mxt_ts: Wait for device be ready for communication Input: atmel_mxt_ts: Document optional voltage regulators .../bindings/input/atmel,maxtouch.txt | 8 ++ drivers/input/touchscreen/atmel_mxt_ts.c | 78 +++++++++++++++++-- 2 files changed, 80 insertions(+), 6 deletions(-)