From patchwork Mon Dec 10 19:32:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evan Green X-Patchwork-Id: 1010647 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="a5g4oNTK"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43DCsB0jfqz9s8r for ; Tue, 11 Dec 2018 06:32:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728079AbeLJTcR (ORCPT ); Mon, 10 Dec 2018 14:32:17 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:46451 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726261AbeLJTcQ (ORCPT ); Mon, 10 Dec 2018 14:32:16 -0500 Received: by mail-pf1-f193.google.com with SMTP id c73so5857443pfe.13 for ; Mon, 10 Dec 2018 11:32:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=p4wMSd+clrTT1ldPmCIKnrVlB4dOOm6F0olIdaXplr4=; b=a5g4oNTKgj/TZC20b4joKzTzocaFQXT5Y02dzBfOoWSQ00HLp/8ZiYBI0V1GuNqzoT 7+fpEQJPA8ogfH6PucSzFYtSv0pouy+Ak+GG+0bNcOKzWUZjUKkqiZ/NHO8G4G80dX4l k5Qk3GhH29UafgvWIB7fF0YWFnsx7EgR9PsbI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=p4wMSd+clrTT1ldPmCIKnrVlB4dOOm6F0olIdaXplr4=; b=T0aH/99MZ0A+H3eb4ge/EMF1dK86z92xwtj6Y1kgcoKgU7EHJqn4FBCTrwWfOGbxHL QQVQEc4W0a40fSICv+PtPhDL1+0Us/Bhz0ewzLNyba/WzmXOnzgxVPjJXqXKh/Tszsdo P78nIF96TCAW8gAC9oJP1hLSqOlflf2nL6qTy+GTmnB6c2/93C/+gLtUzm2wdxbD0+aw 5icj2R90SPVdWBErHfYbLQOmzODIFkf1yRl13iDMwulALASWFxYohYZxD69PVKNPyznL UKQG9xTzdIHmR4u3u5I8MBqXgkXA5mVpTxsdmnxTYfSsH/4PGfPOGjTNRY7EVW4JbMzi cghw== X-Gm-Message-State: AA+aEWbatWyCDpDL4m/bBpCCm2Ci8jExjP8uvjTJGlZT0rWUBrtM8uIX o2qxMVe77xnH2kmAvCR8qXDkEw== X-Google-Smtp-Source: AFSGD/UxF+OzP8CKLbcJDpMiM9+1X0a/CnTdimjL+mxi6YM312nl98Xe2qqPYKS7OVECZG50a04J0Q== X-Received: by 2002:a63:1f4e:: with SMTP id q14mr11463516pgm.88.1544470336053; Mon, 10 Dec 2018 11:32:16 -0800 (PST) Received: from evgreen2.mtv.corp.google.com ([2620:15c:202:201:ffda:7716:9afc:1301]) by smtp.gmail.com with ESMTPSA id v5sm23737875pgn.5.2018.12.10.11.32.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 10 Dec 2018 11:32:15 -0800 (PST) From: Evan Green To: Kishon Vijay Abraham I , Andy Gross Cc: Douglas Anderson , Stephen Boyd , Evan Green , devicetree@vger.kernel.org, Grygorii Strashko , linux-arm-msm@vger.kernel.org, Can Guo , linux-kernel@vger.kernel.org, Vivek Gautam , Manu Gautam , Rob Herring , David Brown , Mark Rutland , linux-soc@vger.kernel.org Subject: [PATCH v2 0/4] phy: qcom-qmp: Fix clock-cells binding and provider Date: Mon, 10 Dec 2018 11:32:03 -0800 Message-Id: <20181210193207.242080-1-evgreen@chromium.org> X-Mailer: git-send-email 2.18.1 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This series fixes the QMP PHY bindings, which had specified #clock-cells in the parent node, and had set it to 1. Putting it in the parent node is wrong because the clock providers are the child nodes, so this change moves it there. Having it set to 1 is also wrong, since nothing is ever specified as to what should go in that cell. So this changes it to zero. Finally, this change completes a little bit of code to actually allow these exposed clocks to be pointed at in DT. I had no idea how to fix up ipq8074.dtsi. It seems to be completely wrong in that it doesn't specify #clock-cells at all, has no child nodes, and specifies clock-output-names in the parent node. As far as I can tell this doesn't work at all. But I can't add the child nodes myself because I don't know 1) how many there are, and 2) the registers in them. I also have no way to test it. Thanks to Vivek for testing msm8996. This patch sits atop the UFS device nodes series [1]. [1] https://lore.kernel.org/lkml/20181210192826.241350-1-evgreen@chromium.org/ Changes in v2: - Rebased onto phy/next Evan Green (4): dt-bindings: phy-qcom-qmp: Move #clock-cells to child arm64: dts: qcom: msm8996: Fix QMP PHY #clock-cells arm64: dts: qcom: sdm845: Fix QMP PHY #clock-cells phy: qcom-qmp: Expose provided clocks to DT .../devicetree/bindings/phy/qcom-qmp-phy.txt | 11 ++++----- arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 +++-- arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 ++-- drivers/phy/qualcomm/phy-qcom-qmp.c | 23 ++++++++++++++++++- 4 files changed, 33 insertions(+), 11 deletions(-)