| Message ID | 20180301152515.20940-1-enric.balletbo@collabora.com |
|---|---|
| Headers | show |
| Series | phy: rockchip-typec: fix boards that does not report cable-state. | expand |
> On 01.03.2018, at 16:25, Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > > Commit c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port > support for rk3399") caused a regression regarding the USB3. During boot, > the following message appears a few times: > > dwc3: failed to initialize core > > The driver is deferred waiting for the typec-phy, but this never happens > beause is disabled. So, enable it. > > Fixes: c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port support for rk3399") > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > Changes in v2: None > > arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi > index 1fc5060d7027..3a3b24383482 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi > @@ -505,6 +505,10 @@ > }; > }; > > +&tcphy1 { > + status = "okay"; > +}; > + > &u2phy1 { > status = "okay"; > > -- > 2.16.1 Tested-by: Klaus Goger <klaus.goger@theobroma-systems.com> Looks good. With your patch,the onboard USB hub on tcphy1 is found at bootup. # lsusb -t /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M |__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/4p, 5000M |__ Port 2: Dev 3, If 0, Class=Mass Storage, Driver=usb-storage, 5000M /: Bus 05.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 480M |__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/4p, 480M |__ Port 4: Dev 4, If 0, Class=, Driver=, 12M /: Bus 04.Port 1: Dev 1, Class=root_hub, Driver=ohci-platform/1p, 12M /: Bus 03.Port 1: Dev 1, Class=root_hub, Driver=ohci-platform/1p, 12M /: Bus 02.Port 1: Dev 1, Class=root_hub, Driver=ehci-platform/1p, 480M /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=ehci-platform/1p, 480M — Klaus -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> On 01.03.2018, at 16:25, Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > > Commit c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port > support for rk3399") caused a regression regarding the USB3. During > boot, the following message appears a few times: > > dwc3: failed to initialize core > > The driver is deferred waiting for the typec-phy, but this never > happens beause is disabled. So, enable it. > > Fixes: c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port support for rk3399") > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > Changes in v2: None > > arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts > index 9a7486058455..2c9c696d1383 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts > @@ -191,6 +191,10 @@ > status = "okay"; > }; > > +&tcphy0 { > + status = "okay"; > +}; > + > &u2phy0 { > status = "okay"; > }; > -- > 2.16.1 Tested-by: Klaus Goger <klaus.goger@theobroma-systems.com> With usbdrd_dwc3_0 changed to dr_mode = "host" [ 37.176540] usb 6-1: new SuperSpeed USB device number 2 using xhci-hcd [ 37.203962] usb-storage 6-1:1.0: USB Mass Storage device detected [ 37.211837] scsi host1: usb-storage 6-1:1.0 [ 38.249378] scsi 1:0:0:0: Direct-Access SanDisk Ultra 1.00 PQ: 0 ANSI: 6 [ 38.259097] sd 1:0:0:0: [sdb] 122421248 512-byte logical blocks: (62.7 GB/58.4 GiB) [ 38.268890] sd 1:0:0:0: [sdb] Write Protect is off [ 38.274269] sd 1:0:0:0: [sdb] Mode Sense: 43 00 00 00 [ 38.274582] sd 1:0:0:0: [sdb] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA [ 38.295967] sdb: sdb1 [ 38.300787] sd 1:0:0:0: [sdb] Attached SCSI removable disk < detaching> [ 45.192248] usb 6-1: USB disconnect, device number 2 — Klaus -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Mar 1, 2018 at 4:25 PM, Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > Commit c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port > support for rk3399") caused a regression regarding the USB3 type-A port. > During boot, the following message appears a few times: > > dwc3: failed to initialize core > > The driver is deferred waiting for the typec-phy, but this never happens > bceause is disabled. So, enable it. > > Fixes: c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port support for rk3399") > Reported-by: Vicente Bergas <vicencb@gmail.com> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > Changes in v2: None > > arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi > index ce592a4c0c4c..9c685eab4748 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi > @@ -557,6 +557,14 @@ > status = "okay"; > }; > > +&tcphy0 { > + status = "okay"; > +}; > + > +&tcphy1 { > + status = "okay"; > +}; > + > &u2phy0 { > status = "okay"; > > -- > 2.16.1 Tested-by: Vicente Bergas <vicencb@gmail.com> Thank you, Vicente. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am Donnerstag, 1. März 2018, 16:25:12 CET schrieb Enric Balletbo i Serra: > Commit c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port > support for rk3399") caused a regression regarding the USB3 type-A port. > During boot, the following message appears a few times: > > dwc3: failed to initialize core > > The driver is deferred waiting for the typec-phy, but this never happens > bceause is disabled. So, enable it. > > Fixes: c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port support for rk3399") > Reported-by: Vicente Bergas <vicencb@gmail.com> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> I've amended the message a bit to clarify that the offending commit has been reverted for now and this change is needed for reenabling it and also dropped the Fixes tag. I've also moved the node to a better place - if in doubt please sort the "&foo {" things alphabetically. I've applied the result in my 4.17 branch, but may move that to 4.18 depending on timing. The reenablement of the otg-port will be in 4.18 only anyway. Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am Donnerstag, 1. März 2018, 16:25:13 CET schrieb Enric Balletbo i Serra: > Commit c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port > support for rk3399") caused a regression regarding the USB3. During boot, > the following message appears a few times: > > dwc3: failed to initialize core > > The driver is deferred waiting for the typec-phy, but this never happens > beause is disabled. So, enable it. > > Fixes: c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port support for rk3399") > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> [Same blurb as in patch 3/6] I've amended the message a bit to clarify that the offending commit has been reverted for now and this change is needed for reenabling it and also dropped the Fixes tag. I've also moved the node to a better place - if in doubt please sort the "&foo {" things alphabetically. I've applied the result in my 4.17 branch, but may move that to 4.18 depending on timing. The reenablement of the otg-port will be in 4.18 only anyway. Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am Donnerstag, 1. März 2018, 16:25:14 CET schrieb Enric Balletbo i Serra: > Commit c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port > support for rk3399") caused a regression regarding the USB3. During boot, > the following message appears a few times: > > dwc3: failed to initialize core > > The driver is deferred waiting for the typec-phy, but this never happens > beause is disabled. So, enable it. > > Fixes: c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port support for rk3399") > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> [Same blurb as in patch 3/6] I've amended the message a bit to clarify that the offending commit has been reverted for now and this change is needed for reenabling it and also dropped the Fixes tag. I've also moved the node to a better place - if in doubt please sort the "&foo {" things alphabetically. I've applied the result in my 4.17 branch, but may move that to 4.18 depending on timing. The reenablement of the otg-port will be in 4.18 only anyway. Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am Donnerstag, 1. März 2018, 16:25:15 CET schrieb Enric Balletbo i Serra: > Commit c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port > support for rk3399") caused a regression regarding the USB3. During > boot, the following message appears a few times: > > dwc3: failed to initialize core > > The driver is deferred waiting for the typec-phy, but this never > happens beause is disabled. So, enable it. > > Fixes: c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port support for rk3399") > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> I've amended the message a bit to clarify that the offending commit has been reverted for now and this change is needed for reenabling it and also dropped the Fixes tag. I've applied the result in my 4.17 branch, but may move that to 4.18 depending on timing. The reenablement of the otg-port will be in 4.18 only anyway. Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Commit c301b327aea898af ("arm64: dts: rockchip: add usb3-phy otg-port support for rk3399") introduced a regression on some rk3399 boards, and break USB. While some boards have support to report cable-state via extcon interface, other boards does not support. This patch series tries to fix this. First and second patch makes extcon optional, the following patches enables the typec phyter for others rk3399 boards. It has been tested on Samsung Chromebook Plus and Sapphire but not on the other boards, so I'll appreciate if someone can test it. Best regards, Enric Changes in v2: - [1/6] Keep the error handling of extcon (Heiko Stubner) - [2/6] Rewrite the justification as suggested by Heiko Stuebner. Enric Balletbo i Serra (6): phy: rockchip-typec: fall back to working in host-mode if extcon is missing. dt-bindings: phy-rockchip-typec: move extcon property to be optional. arm64: dts: rockchip: enable typec-phy for rk3399-sapphire. arm64: dts: rockchip: enable typec-phy for rk3399-firefly. arm64: dts: rockchip: enable typec-phy1 for rk3399-puma. arm64: dts: rockchip: enable typec-phy0 for rk3399-puma-haikou. .../devicetree/bindings/phy/phy-rockchip-typec.txt | 2 ++ arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 8 ++++++++ arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts | 4 ++++ arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 4 ++++ arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi | 8 ++++++++ drivers/phy/rockchip/phy-rockchip-typec.c | 13 ++++++++++--- 6 files changed, 36 insertions(+), 3 deletions(-)