Message ID | 20180222061208.2031-1-rnayak@codeaurora.org |
---|---|
Headers | show |
Series | Add DTS for SDM845 SoC and MTP | expand |
On Wed 21 Feb 22:12 PST 2018, Rajendra Nayak wrote: > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi [..] > + qup_uart2: serial@a84000 { > + compatible = "qcom,geni-debug-uart"; > + reg = <0xa84000 0x4000>; > + reg-names = "se-phys"; > + clock-names = "se-clk"; This was changed to "se" in v3 of the GENI patchset, with that this boots nicely again. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/05/2018 01:29 AM, Bjorn Andersson wrote: > On Wed 21 Feb 22:12 PST 2018, Rajendra Nayak wrote: >> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > [..] >> + qup_uart2: serial@a84000 { >> + compatible = "qcom,geni-debug-uart"; >> + reg = <0xa84000 0x4000>; >> + reg-names = "se-phys"; >> + clock-names = "se-clk"; > > This was changed to "se" in v3 of the GENI patchset, with that this > boots nicely again. Thanks Bjorn for testing. Karthik, it would be good if you could include just this patch from this series as part of your GENI series for the next (and subsequent) repost, with updates as needed based on binding changes?
On 3/5/2018 3:43 AM, Rajendra Nayak wrote: > > > On 03/05/2018 01:29 AM, Bjorn Andersson wrote: >> On Wed 21 Feb 22:12 PST 2018, Rajendra Nayak wrote: >>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> [..] >>> + qup_uart2: serial@a84000 { >>> + compatible = "qcom,geni-debug-uart"; >>> + reg = <0xa84000 0x4000>; >>> + reg-names = "se-phys"; >>> + clock-names = "se-clk"; >> >> This was changed to "se" in v3 of the GENI patchset, with that this >> boots nicely again. > > Thanks Bjorn for testing. > > Karthik, it would be good if you could include just this patch from this series as part > of your GENI series for the next (and subsequent) repost, with updates as needed based on > binding changes? > I will include this patch in my next submission. Regards, Karthik.
Hi, On Wed, Feb 21, 2018 at 10:12 PM, Rajendra Nayak <rnayak@codeaurora.org> wrote: > + gcc: clock-controller@100000 { > + compatible = "qcom,gcc-sdm845"; > + reg = <0x100000 0x1f0000>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + }; Seems like we need "#power-domain-cells = <1>;" in the gcc node. It is true that the property is listed as "optional" in the bindings, but we certainly know that the "include/dt-bindings/clock/qcom,gcc-sdm845.h" that's posted [1] contains several defines ending in "_GDSC" and once we start referencing those we'll need "#power-domain-cells". Seems like we should just have it from the beginning. NOTE: IMHO adding "#power-domain-cells" could be done as a follow-on patch, but since (I think) this series still hasn't landed I guess we could just send up v6? [1] https://patchwork.kernel.org/patch/10267093/ -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/10/2018 02:30 AM, Doug Anderson wrote: > Hi, > > On Wed, Feb 21, 2018 at 10:12 PM, Rajendra Nayak <rnayak@codeaurora.org> wrote: >> + gcc: clock-controller@100000 { >> + compatible = "qcom,gcc-sdm845"; >> + reg = <0x100000 0x1f0000>; >> + #clock-cells = <1>; >> + #reset-cells = <1>; >> + }; > > Seems like we need "#power-domain-cells = <1>;" in the gcc node. > > It is true that the property is listed as "optional" in the bindings, > but we certainly know that the > "include/dt-bindings/clock/qcom,gcc-sdm845.h" that's posted [1] > contains several defines ending in "_GDSC" and once we start > referencing those we'll need "#power-domain-cells". Seems like we > should just have it from the beginning. > > NOTE: IMHO adding "#power-domain-cells" could be done as a follow-on > patch, but since (I think) this series still hasn't landed I guess we > could just send up v6? thanks for catching this, I'll send out v6 in a bit. > > [1] https://patchwork.kernel.org/patch/10267093/ > > > -Doug > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >