From patchwork Mon Nov 27 16:30:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Rosin X-Patchwork-Id: 841745 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=axentiatech.onmicrosoft.com header.i=@axentiatech.onmicrosoft.com header.b="emllq4o1"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ylskF1Kzmz9sPk for ; Tue, 28 Nov 2017 03:31:17 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753525AbdK0QbP (ORCPT ); Mon, 27 Nov 2017 11:31:15 -0500 Received: from mail-eopbgr20108.outbound.protection.outlook.com ([40.107.2.108]:19521 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753325AbdK0QbN (ORCPT ); Mon, 27 Nov 2017 11:31:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axentiatech.onmicrosoft.com; s=selector1-axentia-se; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jABaNuzjRRIFY47rn6t9WKtHrJW7zdHB6OdvPBid9Js=; b=emllq4o1jrt5WI/RVQ6j+cyvXeMoGBo/Cacm8f/+GLxGBdY3EgtsYcDrdUVLu0mDBUGEOoN5CIe/Ff/rNNv0jiY1LyU6uP/fgkTuF1GbbCICSjTP2HEgF4bimWpDHKo/LPp9EwrTNi3F73wpVFM8/9XZbGr/vlCoZ2iF6G/Vv3M= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Received: from orc.pedanet (85.226.244.23) by AM5PR0202MB2546.eurprd02.prod.outlook.com (2603:10a6:203:6d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Mon, 27 Nov 2017 16:31:09 +0000 From: Peter Rosin To: linux-kernel@vger.kernel.org Cc: Peter Rosin , Rob Herring , Mark Rutland , Nicolas Ferre , Alexandre Belloni , Russell King , Guenter Roeck , Jean Delvare , Ludovic Desroches , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org Subject: [PATCH v2 0/2] Sluggish AT91 I2C driver causes SMBus timeouts Date: Mon, 27 Nov 2017 17:30:59 +0100 Message-Id: <20171127163101.27859-1-peda@axentia.se> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-Originating-IP: [85.226.244.23] X-ClientProxiedBy: DB6P18901CA0019.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::29) To AM5PR0202MB2546.eurprd02.prod.outlook.com (2603:10a6:203:6d::7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ff7228db-4523-4b42-c1c3-08d535b444ae X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4603075)(4627115)(201702281549075)(5600026)(4604075)(2017052603199); SRVR:AM5PR0202MB2546; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0202MB2546; 3:9Vd8Rj3jJYOeyiLpRxpgkvFvvhXIAIHPWZGcz5a2GySubHSsQ6XpmNorPld1Um1wybdjxoVFY1d2kP8p+AR7ULdDycXITSrefDTQxuPEv8/h4ZWtnC8VlDKidD/4jBsaOA20yAcMNw3e+h8OH6f6ZhFR3u5XvsGG2G7HMmItNqZCEGYrfLM/4OfTZOHS1r52UYCNTtKDtfWpvBiYPv/8CT7y0IT/1EWfbs5oz1OqT3iqoDGYXm63fLSScDkrAEOe; 25:8DSwfl9qUIqHIq2Zh/m03lXeSmoXX9H93NgHL+FLYBuVMl1Ql4Q0U8Fzc2c3F2uzmX7L5gURqoPtxKXNcrQWNeHiSvtvuGjiW2bOT/sZtghNTvGqXfOrnOcGNybIHkaPhVq59bvVp7RhFbzroTUYwc6SIErXITzQd2sQrAOeoGFStw2VVRzZ3y3D+eeeRneHBg08Ghg2735j1ldROCwe1APtoywGZ7XyoETw01qisFD8GrGcpWa5KrQjR8rHUytewy91bdoj3nJjuc2InafIRqm8KnB1GXRK6x2JE3plDBftZXeZmKFGSkzIZdrK/iRA1LOsbDztWTZ0XEfziOmIeQ==; 31:LC7US2FAdrgw2mPV/Mo8Lg/cXQSaojJdaZ7oYRAGh/+x6jYGX9aMmGpmFoE0BKb90mzMt+diDdYIwg0+BT65Y151JFY+tKsvPTDXtQ2cAPd9kYNbSmPQ2eWETPT1qES9pJoTb/eHTSA2lQ6cSAPtklHfuAu2MO9OjHROyiAcfZOr0bU4HHhPQ4WzMU9dYH1lPUtSpTDZq9PTbjBh7v6YCb+7OYNPHeFcZiv2GWB3kjQ= X-MS-TrafficTypeDiagnostic: AM5PR0202MB2546: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(3231022)(10201501046)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123564025)(20161123562025)(20161123555025)(2016111802025)(6072148)(6043046)(201708071742011); SRVR:AM5PR0202MB2546; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM5PR0202MB2546; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0202MB2546; 4:aEk8XLHhpOytrKufcIFlajXTFXsI069h9AgtSwn432fSOHVlbdxAn3BsNzuVw9hqEDFSO/8TA28lrwSPOe3F2OQY5GV+tJOWJPY8AyY6aFo28znGUEIzIEIXfT2wKa+Igd0ao7mZNkOFK0sw+9PNbXjq5A4O7V1gou22QURz6UKFsoLqu9AOpc1I3T+eJbse2HAQL5WAdLfFuYSejeVvkEAS3Aqr72HaNh0Pt4E5xR4DgmqFZetbSJy6WSpT9X58SAoZoooPliwO5a7z2lfH6g== X-Forefront-PRVS: 0504F29D72 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(376002)(346002)(366004)(39830400002)(199003)(189002)(101416001)(50226002)(551934003)(8936002)(966005)(68736007)(97736004)(1076002)(6506006)(50986999)(16526018)(3846002)(81156014)(54906003)(53936002)(4326008)(52116002)(478600001)(7416002)(7736002)(189998001)(16586007)(81166006)(6116002)(8676002)(305945005)(6486002)(48376002)(47776003)(5660300001)(86362001)(25786009)(74482002)(51416003)(316002)(36756003)(2906002)(6306002)(2351001)(6916009)(2361001)(6512007)(6666003)(106356001)(33646002)(66066001)(105586002)(50466002)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:AM5PR0202MB2546; H:orc.pedanet; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: axentia.se does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0202MB2546; 23:k2yI4yxNQmhFfWo58I+2ZVk+uGnGuNvEZsg5yMd?= u6jWG4RRTV5N8luqGxH90Bwb1L32ERqt2rYH6Gm1sVWcWe5Vz8CoLAotK5jGOixRQ2WejwlXxrhQNGGgK4p7bMntRMfOHritGxN2uR67P0493oJWp9sKWf6QFIS10YQZZL4Jv0CLgO99w9QfwAuPVIPqDFX6YakbNnAFOl4alzDlt21gMikguLDUmnsi/h68Hrxqwt076hKdfdgJLvs1TpnpEvQrMdnVW9rZ6zi/KULml/05bBQ3RCtzxZOXiheGlfvfUQiXOs6g1HfPOAq9wKHrNMUhDGITAfvC9+P6roJUK0dI6vA3wRhosGEzwE+VNigbvBFZ9U5BNQepV8c9c4DdLn7gy2YlLnlqr4tlv/3o9BVW2Tq80+SHpt81FwGLHRPMPnw+VfLwmX/gP2urEBBzvO3HqwL0B+tqohHeFAJrLUEJEX6/+LacDuzgssWMJ0vFznc/Q/oUN3fC4iG0w1vxFcPWVz7gDQT6OcH9khb0tZLtCM90yzxuLkF7zWO8laB94W87foaNDEYQ9McL6spkNRr0bcXWOtho/WOQN1AiYgTkSlBP+SB+Q6GXEmk2szUkXzYd8z8vhMWpp0QLQub59kuq0VAF2pumadJHzTP2BSElY6UULEyvAqWbXw0Utg8ghLcUA7lBCei9RkTtIPRM98Xbg7m8bHeqprUbSHastNf3ZRCGQjDQr6UWjFBtpxbvsP8KYGgPxmKejTKB7i1WHunAu72RFhlIhGY67z2j1+rO+N4T2GcXa4gAGsTD6i+nM5UVjqtC4/H6b1b/SIWIfPpywWawwHObBZxYW4WpzsdGHAXdo/gD9Qkac4MDS9xKciRLvUDzqOw+AWb1Pp+w2AJWPbGo0QxJtOBbnTiyMWjs45ZUAlRHHx+gTJrVhHvkb3F2cODlcGfmkTjEzy1a4S6kbTtBlvqM7z0UUhFt8YREEQ50Eh0pwhWbp1xZFXMhyvlAJC4Vvznx8on87a0/3ctqwOL95vtG3t/FIaWWQG4ub2v8+pH09s8aNIDR15wVnbcDe+g2PE+cgcihWWpTnHnh36+US2OJlgfOI59W6spjgUBKqp31YK3luGXM4BOi0wto2wgzydlkxFcUdYOdu46cAj0rQy9X8HFTDaq0kqmCZEUGYKye3P7+JJ7tJ5wxnz7uqQnyruq2LIX0o/KbUZcyTvcaSZ4ercUfSR4SlCmcsU1SOg8d3utxPdwB4Fh+cfoS+aCKT/LUKYJqK6oTk X-Microsoft-Exchange-Diagnostics: 1; AM5PR0202MB2546; 6:lwkKEpodAImhC7GntPigNUZqqy2pgXNUpEulv3J9qZ1gJmDGS52+YZkKi2MAWFOJgFhQgh1mHlvahnaHHfOMl7vhNm3dMHDh6SzOgeId99BMlmQHbMz//5Bl8Mf87MHxkPTBriEZ1vZyIA7Jp0DU3Guwj6tFkkb5rwegzy11FYE69ng0MY1MXK4NGaJHkMkKNUw+0aC4qcCTbX7eh9T2NzIuus/8VMsqb7JZAWHUnGiV0i7YrSLNdQ+R2L7j9qm9G8aNwzpFuVfkljDTmg7RihaJHcGmuiFc7rjI5Npdjzy+OakSOBN2gEv58Z5lJr8FUun0UrRtkUurbonLkpzvR88sykI9P42GJ08w7Tvm8EM=; 5:ncQhIvBFinEkRXPgo7aek3475RZCFMKISnrVt29mtaobyBVL5Ak+5lthTmgW/F6QW3+hGP3IqarRGuNCWKz6Mw3/cVWSxjgZ38Mwp9t4kYfyGwDelPmmFnniLAMqdK4/6WdSdh9KG1wJyotrZiUNNSd6e69BcRQHg/crUaq0Fy8=; 24:prBwXvBgrv3eNbsCvmtiCtgF3JdqAD7rOvR4tyuMUhDRJ9wsAF+sXRLFqCZmR2HHpAnvJuTlvqYKBwUkzMEM9LTMJ697OklykBDdq6OQlKo=; 7:HAf88L/39nvgqLwLn4Jo1G1NpH9ffKWI9j1lo1pbBhSIZVYn6GjN6/zJUL6GjCLlTAXtKc73vXpeZ9SiE1ZR8QJUUymkWhodRZr9Fjz90JD0uIKpTqzAJ2Nf1Gv5JWQw9dAzgcq2WHsEYd68wzmgl+WVDFPktcqO0zNMJRC/HbI4JCg1zn9jQP1RkGrmiY7mtxtZzct0PQPH4NUQAQ/9nyAf8MbwZZRg8n+9Sshz8TCeg0Dmk7q7LJtcfqS9Mria SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2017 16:31:09.4232 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ff7228db-4523-4b42-c1c3-08d535b444ae X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0202MB2546 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi! [I was waiting for a comment from Rob for the initial submission, but that never came and I nearly forgot. Instead of pinging again, I'm resubmitting with the review comment from Guenter fixed, hoping that Rob will react this time.] This is a workaround for a problem in the AT91 I2C adapter driver (or perhaps the hardware?) when it drives the TWI peripheral on an Atmel sama5d3 chip as I2C. Apparently, that driver can delay in excess of 100 ms just after the transfer of the 7th bit of the last byte. When it does this the I2C bus, when viewed from SMBUS client devices, appears stuck with SCL low. Some SMBUS devices times out under these conditions, in particular temperature sensors. The I2C adapter driver does however not notice the timeout, and thinks the transfer completed successfully when it finally desides to finish the transaction. When this happens, the 8th bit of the last byte is always set, and thus quite possibly corrupted. The chip this was observed with (an nxp SE97) has a means to disable the SMBUS timeout detector, which "fixes" things. Do that. This should probably go to stable? Previous discussion: https://lkml.org/lkml/2017/10/12/227 Changes since v1: https://lkml.org/lkml/2017/10/13/184 - Added #include of bitops.h - Rebased to v4.15-rc1 Cheers, Peter Peter Rosin (2): hwmon: (jc42) optionally try to disable the SMBUS timeout ARM: dts: at91: disable the nxp,se97b SMBUS timeout on the TSE-850 Documentation/devicetree/bindings/hwmon/jc42.txt | 4 ++++ arch/arm/boot/dts/at91-tse850-3.dts | 1 + drivers/hwmon/jc42.c | 21 +++++++++++++++++++++ 3 files changed, 26 insertions(+) Acked-by: Guenter Roeck