From patchwork Thu Nov 2 03:53:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 833195 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kaNW1snh"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ySB650Sjlz9sP1 for ; Thu, 2 Nov 2017 14:54:04 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934099AbdKBDyD (ORCPT ); Wed, 1 Nov 2017 23:54:03 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:51388 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934073AbdKBDyC (ORCPT ); Wed, 1 Nov 2017 23:54:02 -0400 Received: by mail-pf0-f195.google.com with SMTP id n14so3588496pfh.8; Wed, 01 Nov 2017 20:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=LK2so7/2ZPecEWMb+oP1+JVUs+YF//8HiWZ7Gr/ANrk=; b=kaNW1snhIWXiqdPaMBQXCzFmcc+/HsQil8OwAfxn3gjMf/Amuvfnt7NMM5yF3fdsry 8dMBXXQ0C99OHGVa8mGIsMhfD5GQ/u5azuJNT7AKRcTLsDEPDZj/lPmrsYthOEIpYzaC hjXxk9BGJNsOpHvc1K1JaSxy6sDkCchwhQotd2XymJYommYylyGaKurCqyOVcR1WJyJP bcYXDmOsI7CDnYAweeHh0Psv/h/azbRvi/p5Pi0nGYDHkeV11osZGHVlF0Aj+7ziJRVB GPdO2/sGzSa5740Khr9l7C5zuLDFzcbnqAqCn/igMDmEQH2YGmCUFHdYv3Rx9YXd3NeI 2XhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=LK2so7/2ZPecEWMb+oP1+JVUs+YF//8HiWZ7Gr/ANrk=; b=X17r+o3ww5s0P4wW+1dYwmapvR/glf495lbuTFoyosrIwYjPLd2CpbaFzGb5Wbo8wO Q0204Vz1BxwLgb2MTl4wFWMKhbuFLkKxGJkAXaTcQH+f5aaJEfktBTMs7N6k7EVgU7U8 3TleLk53k1+MidV5sVWqF9aE0s1m8ZmOrP9v44rVCjFT8K7rillmZqg0l5jwb0GspHrk pMSGghj1yBD7/zuLrP/pB0PtBdqOWG3WZ6bkpHADNZfc8EwzHH+q7ooF4KhlAZAyq0PS +fpyoShrUDT3pCQzKNll8tn9f3R3aBx/NUN4LnIGX5J0qDQ4/DV+8+oTaoVEvp8W+PrO df1A== X-Gm-Message-State: AMCzsaUNiXDlCwuQAMkJNJWka+D/Ng2dvL0sziWIZ+PswSNO5rnU5y0S eYKMhFbv6+B3qnB/4S7gI0Q= X-Google-Smtp-Source: ABhQp+TdIqovt3+yhbR7qY5cpBOtEj+ZWyI42NXyQdKFyDZ1kASDwfFIKnkjV9g3x9G2+ygN54o4MA== X-Received: by 10.84.240.135 with SMTP id z7mr1819373plk.445.1509594841420; Wed, 01 Nov 2017 20:54:01 -0700 (PDT) Received: from aurora.jms.id.au ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id l5sm3984177pfi.165.2017.11.01.20.53.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Nov 2017 20:54:00 -0700 (PDT) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Thu, 02 Nov 2017 14:53:52 +1100 From: Joel Stanley To: Guenter Roeck , Rob Herring Cc: Philipp Zabel , Mykola Kostenok , Jaghathiswari Rankappagounder Natarajan , Patrick Venture , Andrew Jeffery , devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/3] hwmon: Add reset support to aspeed-pwm-tach Date: Thu, 2 Nov 2017 14:53:46 +1100 Message-Id: <20171102035349.1902-1-joel@jms.id.au> X-Mailer: git-send-email 2.14.1 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Gunter, This adds reset controller support to the ASPEED pwm/tach driver. The reset controller and clock driver is currently under review, so to test those patches must be merged in to fully test these changes[1]. To address your concerns from v1: This driver was not usable as-is upstream. I believe the developer(s) tested and deployed it in the OpenBMC kernel tree which has some hacks in mach-aspeed to release all of the resets. The other way they could have tested it is by booting an OpenBMC kernel, which releases the resets, and then testing the upstream kernel without performing a power cycle as the resets are not reasserted on reboot. I realise it is not ideal to be changing already merged bindings. I don't plan on it becoming a habit. There is no BIOS or other ROM that runs before Linux on a BMC to release the resets. We do have u-boot, but that does not modify the pwm reset. I haven't added a Kconfig dependency on the RESET_CONTROLLER as the driver can build without it, and when the ASPEED clk/reset driver is merged, the platform will always have that option selected. I've given this version a day of testing on hardware I have access to. [1] https://lwn.net/Articles/737697/ Joel Stanley (3): hwmon: (aspeed-pwm-tacho) Sort headers hwmon: (aspeed-pwm-tacho) Deassert reset in probe dt-bindings: hwmon: aspeed-pwm-tacho: Add reset node .../devicetree/bindings/hwmon/aspeed-pwm-tacho.txt | 14 ++++------- drivers/hwmon/aspeed-pwm-tacho.c | 27 +++++++++++++++++++--- 2 files changed, 29 insertions(+), 12 deletions(-)