From patchwork Fri Oct 13 09:27:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Rosin X-Patchwork-Id: 825347 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=axentiatech.onmicrosoft.com header.i=@axentiatech.onmicrosoft.com header.b="MQXIkDkl"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yD2Th5QR3z9sRm for ; Fri, 13 Oct 2017 20:28:56 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751611AbdJMJ2k (ORCPT ); Fri, 13 Oct 2017 05:28:40 -0400 Received: from mail-he1eur01on0139.outbound.protection.outlook.com ([104.47.0.139]:64377 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753720AbdJMJ1Y (ORCPT ); Fri, 13 Oct 2017 05:27:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axentiatech.onmicrosoft.com; s=selector1-axentia-se; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SkXGT0dgei4eci56jVwhFF2ynspdwjX4buahxbWBdgk=; b=MQXIkDkl7SnyL/4O3ZTZ1I5WxH6vMbmIKHkFMWyiL7uXqrF+B+QH44Z3VF2OLs87cLZjGRBasq1PzpQNlSyZKV9RNBl3hcpOX1iF063GzK697ra+lhO1uVwEkpP2UBw8tKyOlyQM3I+cdTvNQTVpjT7O0jB1I/bo+xOyc4hMDqA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Received: from orc.pedanet (213.112.203.125) by HE1PR0202MB2553.eurprd02.prod.outlook.com (2603:10a6:3:8f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 13 Oct 2017 09:27:16 +0000 From: Peter Rosin To: linux-kernel@vger.kernel.org Cc: Peter Rosin , Rob Herring , Mark Rutland , Nicolas Ferre , Alexandre Belloni , Russell King , Guenter Roeck , Jean Delvare , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org Subject: [PATCH 0/2] Sluggish AT91 I2C driver causes SMBus timeouts Date: Fri, 13 Oct 2017 11:27:03 +0200 Message-Id: <20171013092705.7038-1-peda@axentia.se> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-Originating-IP: [213.112.203.125] X-ClientProxiedBy: HE1PR05CA0156.eurprd05.prod.outlook.com (2603:10a6:7:28::43) To HE1PR0202MB2553.eurprd02.prod.outlook.com (2603:10a6:3:8f::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 458e2e27-8eba-4b7e-3ab1-08d5121c988f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017082002075)(2017052603199)(201703131423075)(201702281549075); SRVR:HE1PR0202MB2553; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0202MB2553; 3:Wt5omjzdftK71lrjNZ6RFDGPdqbGyHnlmEyhCXutE4Fs3yn/zgo85wb7gb6o6pHb844RCK3/4XxCNPn4f6p+/L1uCNPgqgrXQDuSdZ94kgWxM48FuhPzDJfxrHoJNEguv8pTas3meaefc3LfYfjJ/Wzo1DOWhCZnYVn39fYCygLIugATBLTqtxNzXbPQCIPUWTXu9TMVas6/NqfQPBJiiYsiSuDAEJ1wX8KPquNtaTENtHlpEuZzvJEAPp0UbMX9; 25:mcE+xJGM4ckApFbiiHUdb7xRwvibhmx4sRa0N3dUtSEZd1GLThPwgWjhJqbkpYcJYvbh/5kgWSIxNvEgHt/46yavX+ptjKRGDpxjdhl2R6+fkz2OmUuQvngIcWx3excl24OOlLYS4z7WSbmIYzOAoD1kjbwnGdWJXcpH5UULCOakMskx0elq+jDee7DooE+fk6++/fuMuYbmOdJo6yfQTDhp8BaOc+nJ9vhlOjotEXflvhUGPSIvJlBca7dzzbVEuPEUJY8xWbV94KRqNvGUg4Ktqpn/HVwg6BpYxyYmeZBCVu/3ELgNbdDTI3eaGCWQxNVVvL7URwdo27cOFLfIlg==; 31:x7suc+S+T+wTw82+R3Bbi8xLQ1jGP7VDc1XcSIqAkuPCQpqkgeJav5M6JnQNYVutPK+rsQCb/9wKkZYRH6iQu86cjpeY+6BcB0wtHYH+IgmIBtcrZ1/SsuMzAI5OQCUZEHOHEbAfakbcvcXrVAlZJh44Tdql9Lx97tC9fcgG27ecgzuJVBTYJjt7nHw+WwpoA/pjCXu7cOn9QwFdSAoL/fkRem0Jr/MYoLq9PT3epw4= X-MS-TrafficTypeDiagnostic: HE1PR0202MB2553: X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123560025)(2016111802025)(20161123558100)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6043046)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR0202MB2553; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR0202MB2553; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0202MB2553; 4:frD5U9D7kHdW3bGNvK3ts5ZpXCwCmYVdBXn3n5QBqEnI88GVosjSMYa0ribiIiKLuYDnBSaWTUBPsGCstapDdypCD3rYNXh7/W+72sSpeIgEixhcE7Y+n9h0eu60Ll7ROqyiVUlJlFI2pUWkrWTQ+vrOkpH9wajofijPE/Ai95/3tl9gOOhB4Sd7dIbjm+cizqxLJP4jfxLjwAbDMYeurEcOlk3RT1T7g1bhHkCk/T9ElBSSdwCywIl5HxLuMs5/ X-Forefront-PRVS: 04599F3534 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(39830400002)(346002)(376002)(199003)(189002)(97736004)(66066001)(25786009)(47776003)(36756003)(101416001)(68736007)(305945005)(189998001)(7736002)(50986999)(2906002)(5003940100001)(48376002)(50466002)(551934003)(53936002)(6916009)(4326008)(7416002)(5660300001)(1076002)(3846002)(8936002)(6116002)(6306002)(16586007)(316002)(16526018)(2361001)(6506006)(106356001)(2351001)(54906003)(105586002)(6666003)(6512007)(478600001)(86362001)(50226002)(33646002)(6486002)(966005)(81166006)(74482002)(81156014)(8676002)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:HE1PR0202MB2553; H:orc.pedanet; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: axentia.se does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0202MB2553; 23:YnBbm/cI7LtrCV2/rX9Q26BshRJYYgaj3vqt3+0?= OKz/5J6pcihaudXkyNTyUgPBvoev1v7b2mmpCBRCLtqg+vcim6OmZdduX49xrLITISNU/GIElpiTQ6ERJSPJW0Lk0b/JivWGcVDjDcwzvDRHFvnmnqSBp4vPDG/WJElD/d55NNyUu45ffcY57i/nxkbl+JqZoddwEvX342+nSxIXu5706QD6NOX7JI+2bH9jG5mh5Yc7tvRKcl/bE0CLACy7q/GapBq0B3i3DsuN2Sz5R11TBzuOVtqnr1KFUFJyYUkx/5BrHcwl6SYRFYyslKqV15Ue4KL9aYwVdhtaa23jZWERpspiqlM04CSBEPQyfxlhxaniGJSYLC93ftoo7t4vJfaKFYbPh2TJNwjhK7lX7C5CXScTTH+jsfv40ZjsBPv/czRARZphuAbq8VhYQwcYVsXn1GZc52vhchMR04uO3axkM2r89J1FLbQOoJX9zQ2QcpnijUadf17iUzjVkGqlUagk7+xpXrxmocuSf94I+sL918wn1+tOkgPEE+6XGCQD4Xwvn9Q5G/3dkBzFKRefNTE5vAgmmp+MdSGX+ZvXoNDVpfqePt1DaB1AJCio9OdMNruU5gpA1jU/dSyQV8HhzNZAg7BN0HAqd6inXeoAYdLfSgx5ZQyokpyL3prPIYnOLYlbHuBHhs6apjFfAAvfs6aWa6fe8hsHZ5CwSReZQ/QK0fLTFz4mm6gGpfKxxsCBzKFKdRaKyP/+OsdaTrypW8+a4ZLjCi14JYttN5YW5Bl7XJz5dabVJgB1YxUH0uP9Ek5nVkMJD6ruDbJstTh0EEiXOZgg8YMLLQ+gcBcxTuXDcbosYtgMVoWsW6dO6yPXYyD6gTfez4ShkvzwG9QWguSWPWKWc5XfbEHA+LcHqKVzI3Nveuu4lfEmeik9Yy18d1KY+Qrsm/u+6hMA0yRWyvp2ybAYZsT93SwubuGlCZt7xC90B6MDHCiKKc0FK74xBnkEETG3Dme+8/3En/+7zk6BGnJI+gwxAVPXi++Z7Hple3euJSwDUUuQJw3S09g0nEY9FhurZbswYoVxi7Jkh+NhMwnYCnmPzcotQNjKaTj9NnunM/oCLsbTjAyuYSTvkNRcJiJm2HDZ82eXRHgllf5EoYy7W3tj006rZVuSx23wVwqgOjauvUoWVyp0s3f5tkR5G/gAnxuzaoCOtD9eFL1OTYOQQQ4GgKh9IhSLnS9zY0X8u/HpgIfcXMQ0dNXs= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0202MB2553; 6:GwNYrxcuErSPdwHObNd2Q27zC1z2btQsdex2oviaU+XAIIsbpt8QEebuuGymFnOth1N1HnMCNKEXZ2+Fvflfvlt3GWA2xxJNLFtF2s97XkDQtRP6N9B9x1javsDXcU0wJ7yJL5wksYMoQBevkbQOKvMAFAkisnhcZT+at0j52sBTYP1+wl36o9EEUIavPwI3EFE9xUnxchdOv1EVE/rHjv5HGOe12J0ifRHzgk/C3CRE3eG4NjvZKRBS7RQDrOOdHE7vfceulN5+mqqNCdVP1ynxdqeMGQlrrx/7LTqRgAT5eRyRe40Z2v5Tflpg51utE8V97QlvOC+Q7LZjyATLtg==; 5:rf8UdVx+7GEEQ6WQqA22APfaLsOo0an/DJrf0AwrUOBn9Ulta2M3gv66N+0Y5YwnGgJyzlvhJ5kLuIOU7ef4UW1Ees6YSLEevNYsd+4JIVE17+Vhw7BB6O8/AITjakaesM1faGu/RSEkpxJhgJdRcA==; 24:D9ZlnllHtYGmfxgNxicmT/dtu6G6Ef0J2yOHxv8R+PwdAQT3+La5EfHHqB7IXJ3g0bBQMyvRxTjheVG5VphG/clzmFYTfLGAI8Wpyw5nWyY=; 7:BOEjVfefjUxF0GL73q7t1QtHWSpYu2w0nbMOevMPj87xMP5HGxpUQB4vhomxp22kBTfzR6eRaJ8UnUjjQ/6Ivg4MT0QOzABOijNJwU9HuEpFuvNcSBHIR0FKXxjQLozblTy12YteHAmTju1xQBqnhoeaNRPcVj1pwLhXShVUOZwxFFzpbDRQkPCF8rJFlxHy/8urB1rf0b31+AE1FbL860A2cMK7Yyy14d7kFG9l8Lo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 09:27:16.4450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0202MB2553 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi! This is a workaround for a problem in the AT91 I2C adapter driver (or perhaps the hardware?) when it drives the TWI peripheral on an Atmel sama5d3 chip as I2C. Apparently, that driver can delay in excess of 100 ms just after the transfer of the 7th bit of the last byte. When it does this the I2C bus, when viewed from SMBUS client devices, appears stuck with SCL low. Some SMBUS devices times out under these conditions, in particular temperature sensors. The I2C adapter driver does however not notice the timeout, and thinks the transfer completed successfully when it finally desides to finish the transaction. When this happens, the 8th bit of the last byte is always set, and thus quite possibly corrupted. The chip this was observed with (an nxp SE97) has a means to disable the SMBUS timeout detector, which "fixes" things. Do that. This should probably go to stable? Previous discussion: https://lkml.org/lkml/2017/10/12/227 Cheers, Peter Peter Rosin (2): hwmon: (jc42) optionally try to disable the SMBUS timeout ARM: dts: at91: disable the nxp,se97b SMBUS timeout on the TSE-850 Documentation/devicetree/bindings/hwmon/jc42.txt | 4 ++++ arch/arm/boot/dts/at91-tse850-3.dts | 1 + drivers/hwmon/jc42.c | 20 ++++++++++++++++++++ 3 files changed, 25 insertions(+)