mbox series

[v12,0/3] Add QCOM SNPS PHY overriding params support

Message ID 1662480729-10187-1-git-send-email-quic_kriskura@quicinc.com
Headers show
Series Add QCOM SNPS PHY overriding params support | expand

Message

Krishna Kurapati Sept. 6, 2022, 4:12 p.m. UTC
Added support for overriding tuning parameters in QCOM SNPS PHY
from device tree. This parameter tuning is required to tune the
hs signal on dp/dm lines for electrical compliance to be successful.

Changes in v12:
Fixed nitpicks in driver code.

Changes in v11:
Made changes to logs added in phy driver.
Fixed nitpicks in code.

Changes in v10:
Fixed patch headers.

changes in v9:
Fixed nitpick in driver code.

changes in v8:
Fixed nitpick in driver code.

changes in v7:
Fixed nitpick in driver code and dtsi file.

changes in v6:
Fixed errors in dt-bindings.
Fixed nitpick in driver code.

changes in v5:
Fixed nitpicks in code.
Added minimum and maximum for each parameter added in dt-bindings.
Added proper suffixes to each parameter as per dtschema.

changes in v4:
Fixed nitpicks in code.
Initial compliance test results showed overshoot in the middle of eye
diagram. The current dt values were put in place to correct it and fix
overshoot issue.

changes in v3:
Added support for phy tuning parameters to be represented in bps and
corresponding register values to be written are obtained by traversing
through data map declared in the driver.

changes in v2:
Reading the individual fields in each overriding register from
device tree.

Krishna Kurapati (2):
  phy: qcom-snps: Add support for overriding phy tuning parameters
  arm64: dts: qcom: sc7280: Update SNPS Phy params for SC7280 IDP device

Sandeep Maheswaram (1):
  dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params
    bindings

 .../bindings/phy/qcom,usb-snps-femto-v2.yaml       |  88 +++++++
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi           |   6 +
 drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c      | 252 ++++++++++++++++++++-
 3 files changed, 344 insertions(+), 2 deletions(-)

Comments

Krishna Kurapati Sept. 6, 2022, 4:14 p.m. UTC | #1
On 9/6/2022 9:42 PM, Krishna Kurapati wrote:
> Added support for overriding tuning parameters in QCOM SNPS PHY
> from device tree. This parameter tuning is required to tune the
> hs signal on dp/dm lines for electrical compliance to be successful.
> 
> Changes in v12:
> Fixed nitpicks in driver code.
> 
> Changes in v11:
> Made changes to logs added in phy driver.
> Fixed nitpicks in code.
> 
> Changes in v10:
> Fixed patch headers.
> 
> changes in v9:
> Fixed nitpick in driver code.
> 
> changes in v8:
> Fixed nitpick in driver code.
> 
> changes in v7:
> Fixed nitpick in driver code and dtsi file.
> 
> changes in v6:
> Fixed errors in dt-bindings.
> Fixed nitpick in driver code.
> 
> changes in v5:
> Fixed nitpicks in code.
> Added minimum and maximum for each parameter added in dt-bindings.
> Added proper suffixes to each parameter as per dtschema.
> 
> changes in v4:
> Fixed nitpicks in code.
> Initial compliance test results showed overshoot in the middle of eye
> diagram. The current dt values were put in place to correct it and fix
> overshoot issue.
> 
> changes in v3:
> Added support for phy tuning parameters to be represented in bps and
> corresponding register values to be written are obtained by traversing
> through data map declared in the driver.
> 
> changes in v2:
> Reading the individual fields in each overriding register from
> device tree.
> 
> Krishna Kurapati (2):
>    phy: qcom-snps: Add support for overriding phy tuning parameters
>    arm64: dts: qcom: sc7280: Update SNPS Phy params for SC7280 IDP device
> 
> Sandeep Maheswaram (1):
>    dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params
>      bindings
> 
>   .../bindings/phy/qcom,usb-snps-femto-v2.yaml       |  88 +++++++
>   arch/arm64/boot/dts/qcom/sc7280-idp.dtsi           |   6 +
>   drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c      | 252 ++++++++++++++++++++-
>   3 files changed, 344 insertions(+), 2 deletions(-)
> 
Hi All,

  Please ignore this series. Re-sent v12 instead of v13.
Sorry for the inconvenience.

Regards,
Krishna,