Message ID | 1609842147-8161-1-git-send-email-claudiu.beznea@microchip.com |
---|---|
Headers | show |
Series | cpufreq: sama7g5: add support for sama7g5 | expand |
On 05-01-21, 12:22, Claudiu Beznea wrote: > Microchip SAMA7G5 devices supports runtime changes of CPU frequency. > This is doable by changing CPUPLL frequency along with MCK0 frequency. > Along with this CPU's regulator must be changed to accommodate new > frequencies. > > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > drivers/cpufreq/Kconfig.arm | 9 + > drivers/cpufreq/Makefile | 1 + > drivers/cpufreq/cpufreq-dt-platdev.c | 2 + > drivers/cpufreq/sama7g5-cpufreq.c | 371 +++++++++++++++++++++++++++++++++++ > 4 files changed, 383 insertions(+) > create mode 100644 drivers/cpufreq/sama7g5-cpufreq.c Did you try to reuse cpufreq-dt driver? It already handles most of this stuff, the only thing you need to do is to make sure clk_set_rate() for a CPU needs to handle all the clk stuff behind the scene. We haven't been accepting new implementations of the drivers which can work just fine with cpufreq-dt, please try to adapt to it. Thanks.
On 05.01.2021 12:44, Viresh Kumar wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 05-01-21, 12:22, Claudiu Beznea wrote: >> Microchip SAMA7G5 devices supports runtime changes of CPU frequency. >> This is doable by changing CPUPLL frequency along with MCK0 frequency. >> Along with this CPU's regulator must be changed to accommodate new >> frequencies. >> >> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> >> --- >> drivers/cpufreq/Kconfig.arm | 9 + >> drivers/cpufreq/Makefile | 1 + >> drivers/cpufreq/cpufreq-dt-platdev.c | 2 + >> drivers/cpufreq/sama7g5-cpufreq.c | 371 +++++++++++++++++++++++++++++++++++ >> 4 files changed, 383 insertions(+) >> create mode 100644 drivers/cpufreq/sama7g5-cpufreq.c > > Did you try to reuse cpufreq-dt driver? It already handles most of > this stuff, the only thing you need to do is to make sure > clk_set_rate() for a CPU needs to handle all the clk stuff behind the > scene. No, I haven't tried it due to the fact that there are 2 clocks that needs to be handled and though isn't the proper way to do this behind the scene in clock drivers. > > We haven't been accepting new implementations of the drivers which can > work just fine with cpufreq-dt, please try to adapt to it. I'll try it. Thank you, Claudiu > > Thanks. > > -- > viresh >