| Message ID | CACgzC7B_uz-bLTh+1LV-YgeMCswFdX__uRZ7in9R+9cCUVU0Bw@mail.gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On Wednesday 19 September 2012 01:48:57 Zhenqiang Chen wrote: > --- a/scripts/build/internals.sh Sun Aug 12 07:45:42 2012 -0400 > +++ b/scripts/build/internals.sh Wed Sep 19 13:11:32 2012 +0800 > > # Strip gdbserver > if [ "${CT_GDB_GDBSERVER}" = "y" ]; then > - CT_DoExecLog ALL bin/${CT_TARGET}-strip ${strip_args} \ > - ${CT_TARGET}/debug-root/usr/bin/gdbserver > + # For Canadian build, we can not run the bin/${CT_TARGET}-strip > + # the build system. But ${CT_TARGET}-strip should be on PATH. > + if [ "${CT_CANADIAN}" = "y" ]; then > + CT_DoExecLog ALL ${CT_TARGET}-strip ${strip_args} \ > + ${CT_TARGET}/debug-root/usr/bin/gdbserver > + else > + CT_DoExecLog ALL bin/${CT_TARGET}-strip ${strip_args} \ > + ${CT_TARGET}/debug-root/usr/bin/gdbserver > + fi could you set a local variable so that you don't have to copy & paste the entire command twice ? local cross_strip="bin/${CT_TARGET}-strip" [[ ${CT_TARGET} == "y" ]] && cross_strip=${CT_TARGET}-strip CT_DoExecLog ALL ${cross_strip} ... -mike
diff -r 2858a24a5846 -r bb161ecc8ecb scripts/build/internals.sh --- a/scripts/build/internals.sh Sun Aug 12 07:45:42 2012 -0400 +++ b/scripts/build/internals.sh Wed Sep 19 13:11:32 2012 +0800 @@ -25,8 +25,15 @@ # Strip gdbserver if [ "${CT_GDB_GDBSERVER}" = "y" ]; then - CT_DoExecLog ALL bin/${CT_TARGET}-strip ${strip_args} \ - ${CT_TARGET}/debug-root/usr/bin/gdbserver + # For Canadian build, we can not run the bin/${CT_TARGET}-strip on + # the build system. But ${CT_TARGET}-strip should be on PATH. + if [ "${CT_CANADIAN}" = "y" ]; then + CT_DoExecLog ALL ${CT_TARGET}-strip ${strip_args} \ + ${CT_TARGET}/debug-root/usr/bin/gdbserver + else + CT_DoExecLog ALL bin/${CT_TARGET}-strip ${strip_args} \ + ${CT_TARGET}/debug-root/usr/bin/gdbserver + fi fi # We can not use the version in CT_CC_VERSION because # of the Linaro stuff. So, harvest the version string
exporting patch: # HG changeset patch # User Zhenqiang Chen <zhenqiang.chen@linaro.org> # Date 1348031492 -28800 # Node ID bb161ecc8ecb451225697ad0f6729376eb3e43f3 # Parent 2858a24a584642e263a920b4214c815c172ed547 scripts: Select the correct "strip" to strip gdbserver for Canadian build. For Canadian build, we can not run the bin/${CT_TARGET}-strip on the build system. But ${CT_TARGET}-strip should be on PATH. Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org> -- For unsubscribe information see http://sourceware.org/lists.html#faq