diff mbox series

package/picocom: bump to version 2024-07

Message ID bb3ab486ff7b0113e36b555f9fdbd850c4d132a8.1722516057.git.baruch@tkos.co.il
State Accepted
Headers show
Series package/picocom: bump to version 2024-07 | expand

Commit Message

Baruch Siach Aug. 1, 2024, 12:40 p.m. UTC
This release adds support for no-MMU build.

Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/picocom/picocom.hash | 2 +-
 package/picocom/picocom.mk   | 9 +++++++--
 2 files changed, 8 insertions(+), 3 deletions(-)

Comments

Thomas Petazzoni Aug. 1, 2024, 9:06 p.m. UTC | #1
On Thu,  1 Aug 2024 15:40:57 +0300
Baruch Siach via buildroot <buildroot@buildroot.org> wrote:

> This release adds support for no-MMU build.
> 
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/picocom/picocom.hash | 2 +-
>  package/picocom/picocom.mk   | 9 +++++++--
>  2 files changed, 8 insertions(+), 3 deletions(-)

I think you had forgotten the change in package/picocom/Config.in to
actually make the package available on !MMU platforms, so I did it when
applying.

>  define PICOCOM_BUILD_CMDS
> -	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
> +	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) \
> +		EXTRA_CPPFLAGS='$(PICOCOM_CPPFLAGS)' $(MAKE) -C $(@D)

Also I changed the single quotes here to double quotes, as we much more
commonly use double quotes.

Thanks a lot, patch applied!

Thomas
diff mbox series

Patch

diff --git a/package/picocom/picocom.hash b/package/picocom/picocom.hash
index 8107f5633a6c..170de09cf463 100644
--- a/package/picocom/picocom.hash
+++ b/package/picocom/picocom.hash
@@ -1,3 +1,3 @@ 
 # Locally calculated
-sha256  107d3e49e502ce63f826525f587826990451bcb39492efe2e0463dd62d64f3ea  picocom-2023-04.tar.gz
+sha256  4379de2ec591a5848123f37ccdbc7fbeee6dd3520ef1ce4119d84202fc268a17  picocom-2024-07.tar.gz
 sha256  9273c6b2c55be95f0f0df292d87e8900e5bfdf5b510a6ea09e80306cf45c10f6  LICENSE.txt
diff --git a/package/picocom/picocom.mk b/package/picocom/picocom.mk
index bb55c3c1d1d3..34c3bfb23069 100644
--- a/package/picocom/picocom.mk
+++ b/package/picocom/picocom.mk
@@ -4,14 +4,19 @@ 
 #
 ################################################################################
 
-PICOCOM_VERSION = 2023-04
+PICOCOM_VERSION = 2024-07
 PICOCOM_SITE = $(call gitlab,wsakernel,picocom,$(PICOCOM_VERSION))
 PICOCOM_LICENSE = GPL-2.0+
 PICOCOM_LICENSE_FILES = LICENSE.txt
 PICOCOM_CPE_ID_VALID = YES
 
+ifeq ($(BR2_USE_MMU),)
+PICOCOM_CPPFLAGS += -DNO_FORK
+endif
+
 define PICOCOM_BUILD_CMDS
-	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) \
+		EXTRA_CPPFLAGS='$(PICOCOM_CPPFLAGS)' $(MAKE) -C $(@D)
 endef
 
 define PICOCOM_INSTALL_TARGET_CMDS