From patchwork Wed Sep 11 02:03:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Barnett X-Patchwork-Id: 274096 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id CD49F2C0128 for ; Wed, 11 Sep 2013 12:04:10 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id AEDDD89727; Wed, 11 Sep 2013 02:05:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Sa1JPv-K4GA3; Wed, 11 Sep 2013 02:05:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id ADCFA89729; Wed, 11 Sep 2013 02:05:06 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id DD9001BF993 for ; Wed, 11 Sep 2013 02:04:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 2505630164 for ; Wed, 11 Sep 2013 02:03:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9IDI7AId-tUb for ; Wed, 11 Sep 2013 02:03:50 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from secvs01.rockwellcollins.com (secvs01.rockwellcollins.com [205.175.225.240]) by silver.osuosl.org (Postfix) with ESMTPS id A82E72FE27 for ; Wed, 11 Sep 2013 02:03:50 +0000 (UTC) Received: from nosuchhost.198.131.in-addr.arpa (HELO collinscrsmtp02.rockwellcollins.com) ([131.198.63.133]) by mail-virt.rockwellcollins.com with ESMTP; 10 Sep 2013 21:04:02 -0500 In-Reply-To: <1378646129-4167-3-git-send-email-thomas.petazzoni@free-electrons.com> References: <1378646129-4167-1-git-send-email-thomas.petazzoni@free-electrons.com> <1378646129-4167-3-git-send-email-thomas.petazzoni@free-electrons.com> X-Disclaimed: 7922 To: Thomas Petazzoni MIME-Version: 1.0 X-KeepSent: 916AAFB6:8E78891C-86257BE3:000A49F0; type=4; name=$KeepSent X-Mailer: Lotus Notes Release 8.5.2FP2 March 23, 2011 From: rjbarnet@rockwellcollins.com Message-ID: Date: Tue, 10 Sep 2013 21:03:57 -0500 X-MIMETrack: Serialize by Router on CollinsCRSMTP02/CedarRapids/RockwellCollins(Release 8.5.2FP2 HF162|May 16, 2011) at 09/10/2013 09:04:01 PM, Serialize complete at 09/10/2013 09:04:01 PM Cc: buildroot-bounces@busybox.net, buildroot@uclibc.org Subject: Re: [Buildroot] [PATCH 2/3] Add support for BR2_EXTERNAL X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Thomas Petazzoni wrote on 09/08/2013 08:15:28 AM: > > Signed-off-by: Thomas Petazzoni > --- > Config.in | 6 ++++-- > Makefile | 29 +++++++++++++++++++++++++---- > docs/manual/manual.mk | 2 +- One idea that I have, is for the make file that is genreated for the an external output directory, if we could preserve the the value of BR2_EXTERNAL as follows. I don't think my logic is fully there but there is more of a sudo implementation: Again this is only a suggestion but otherwise I'll ack the patchset. Thanks, -Ryan Ryan J Barnett / Software Engineer / Platform SW MS 137-157, 855 35th St NE, Cedar Rapids, IA, 52498-3161, US Phone: 319-263-3880 / VPN: 263-3880 rjbarnet@rockwellcollins.com www.rockwellcollins.com diff --git a/support/scripts/mkmakefile b/support/scripts/mkmakefile --- a/support/scripts/mkmakefile +++ b/support/scripts/mkmakefile @@ -27,6 +27,7 @@ makedir := \$(dir \$(call lastword,\$(MAKEFILE_LIST))) MAKEARGS := -C $1 MAKEARGS += O=\$(if \$(patsubst /%,,\$(makedir)),\$(CURDIR)/)\$(patsubst %/,%,\$(makedir)) +MAKEARGS += BR2_EXTERNAL=\$(realpath \$(BR2_EXTERNAL)) MAKEFLAGS += --no-print-directory