From patchwork Thu Jun 12 07:32:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Porcedda X-Patchwork-Id: 359027 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 059561400B0 for ; Thu, 12 Jun 2014 17:33:06 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 433118BD68; Thu, 12 Jun 2014 07:33:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OiUpIeovb4oW; Thu, 12 Jun 2014 07:33:05 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1FF538BD60; Thu, 12 Jun 2014 07:33:05 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 996E21BFA5D for ; Thu, 12 Jun 2014 07:33:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 8D10526CB1; Thu, 12 Jun 2014 07:33:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C+Iy29OgvPT3; Thu, 12 Jun 2014 07:33:00 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ob0-f173.google.com (mail-ob0-f173.google.com [209.85.214.173]) by silver.osuosl.org (Postfix) with ESMTPS id B89BD2745B; Thu, 12 Jun 2014 07:33:00 +0000 (UTC) Received: by mail-ob0-f173.google.com with SMTP id va2so910228obc.4 for ; Thu, 12 Jun 2014 00:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=YweweBjDG9p3iNxv3AuaZXtMhsbM4U+88BjyMYIMFfA=; b=S27fv9nupW02GF7Q4vZ1MVe48zweHI2CblzPDH5bVHLzSqAXC4aHxp1VBdr8Jb5mol sKisrcIlG/mUbbuvBSOTT/aGdjEGayWkKtP/wdI1HhYj1cJdhsRp6dvML3rVnMWLRECT EEVXoCHNfnhyLQfFs9DI9yKclHh7mtNN8Lr5/pF0tajmwmPuMEDYgjzKgmSTQZqwA+sw hl8hE46zUD4f0vsKEsmRKhgHHhJKijZQDi8OUZCW4J91ttrTsoQhITXjMW8HB23fxlzx TS/LRwVs7aCNDp38AsGzr8wkOABUp3013AHPlX+QNP4ay8n7EciYezJsls5tuyOJZ+wK xoUw== X-Received: by 10.60.33.102 with SMTP id q6mr9921406oei.59.1402558379964; Thu, 12 Jun 2014 00:32:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.76.176.39 with HTTP; Thu, 12 Jun 2014 00:32:39 -0700 (PDT) In-Reply-To: References: <1402390367-25418-1-git-send-email-fabio.porcedda@gmail.com> <20140610223358.69a70e6e@free-electrons.com> <539884A4.5060705@mind.be> From: Fabio Porcedda Date: Thu, 12 Jun 2014 09:32:39 +0200 Message-ID: To: Arnout Vandecappelle Cc: Thomas Petazzoni , "buildroot@uclibc.org" , Thomas De Schampheleire , Peter Korsgaard Subject: Re: [Buildroot] [PATCH] system: move system.mk recipes inside the "target-finalize" rule X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net On Thu, Jun 12, 2014 at 9:20 AM, Fabio Porcedda wrote: > My first patch will be like this: > > diff --git a/Makefile b/Makefile > index dc86060..f8e446d 100644 > --- a/Makefile > +++ b/Makefile > @@ -525,13 +525,14 @@ define TARGET_PURGE_LOCALES > done; \ > done > endef > +TARGET_FINALIZE_HOOKS += TARGET_PURGE_LOCALES > endif > > $(TARGETS_ROOTFS): target-finalize > > target-finalize: $(TARGETS) > @$(call MESSAGE,"Finalizing target directory") > - $(TARGET_PURGE_LOCALES) > + $(foreach hook,$(TARGET_FINALIZE_HOOKS),$($(hook))$(sep)) > rm -rf $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/share/aclocal \ > $(TARGET_DIR)/usr/lib/pkgconfig > $(TARGET_DIR)/usr/share/pkgconfig \ > $(TARGET_DIR)/usr/lib/cmake $(TARGET_DIR)/usr/share/cmake > > > I will send an updated patch set that will use hooks. I think it's best to use PURGE_LOCALES_HOOK instead of TARGET_PURGE_LOCALES. $(TARGET_DIR)/usr/lib/cmake $(TARGET_DIR)/usr/share/cmake Best regards diff --git a/Makefile b/Makefile index dc86060..bb51727 100644 --- a/Makefile +++ b/Makefile @@ -513,7 +513,7 @@ ifeq ($(BR2_ENABLE_LOCALE_PURGE),y) LOCALE_WHITELIST = $(BUILD_DIR)/locales.nopurge LOCALE_NOPURGE = $(call qstrip,$(BR2_ENABLE_LOCALE_WHITELIST)) -define TARGET_PURGE_LOCALES +define PURGE_LOCALES_HOOK rm -f $(LOCALE_WHITELIST) for i in $(LOCALE_NOPURGE); do echo $$i >> $(LOCALE_WHITELIST); done @@ -525,13 +525,14 @@ define TARGET_PURGE_LOCALES done; \ done endef +TARGET_FINALIZE_HOOKS += PURGE_LOCALES_HOOK endif $(TARGETS_ROOTFS): target-finalize target-finalize: $(TARGETS) @$(call MESSAGE,"Finalizing target directory") - $(TARGET_PURGE_LOCALES) + $(foreach hook,$(TARGET_FINALIZE_HOOKS),$($(hook))$(sep)) rm -rf $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/share/aclocal \ $(TARGET_DIR)/usr/lib/pkgconfig $(TARGET_DIR)/usr/share/pkgconfig \