From patchwork Mon Apr 20 02:36:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Porcedda X-Patchwork-Id: 462665 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id CD88A140082 for ; Mon, 20 Apr 2015 12:36:40 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=gmail.com header.i=@gmail.com header.b=bL110nnh; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 2176F334E3; Mon, 20 Apr 2015 02:36:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4g2iHsts1AeF; Mon, 20 Apr 2015 02:36:36 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id D72E9334DB; Mon, 20 Apr 2015 02:36:35 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id BEF821BFA20 for ; Mon, 20 Apr 2015 02:36:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id BA989A3520 for ; Mon, 20 Apr 2015 02:36:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5_0Z-arfKbU4 for ; Mon, 20 Apr 2015 02:36:33 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ob0-f180.google.com (mail-ob0-f180.google.com [209.85.214.180]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 22BC0A34F9 for ; Mon, 20 Apr 2015 02:36:33 +0000 (UTC) Received: by obfe9 with SMTP id e9so107764045obf.1 for ; Sun, 19 Apr 2015 19:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=F0USN8WrWhbfYpLw89dXGWUX0NnkZyG1UI6TsxRB+aE=; b=bL110nnhh/bdAD7af4dFqVkaNKxqkXSFN+xBPjQLKR4LQggDyuxb7GnuuIXPTajVuJ 2cPwH3ob1bPnC4fXYdJnggtMam+OdaMSmY5Gfvr8G1PmlE9awCyw4L8Zcn5bOVM5cVbd 4Mxf5cCXzm7evEA9zcQWTAwLoznFBn6FHzVpgtqktnSXkRrvNLfCmAkzqUOPjn/C3xa7 ulzrKUgNQMmi3GdFwSaXWFfPNGyzIm23OKVBWnPdyYheKcuYfxuDC3DTiS16dMzKAltk aoXZ+5uFvZQsHxoW0tWMNzQg1XnZTY1mtzfYSTzXWlGlQyi6wo4Tda4mhms2ODCgNAlc gWUw== X-Received: by 10.60.44.241 with SMTP id h17mr12435974oem.71.1429497392491; Sun, 19 Apr 2015 19:36:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.76.69.161 with HTTP; Sun, 19 Apr 2015 19:36:11 -0700 (PDT) In-Reply-To: <5533CD7D.1070605@mind.be> References: <1429376067-9228-1-git-send-email-fabio.porcedda@gmail.com> <1429376067-9228-3-git-send-email-fabio.porcedda@gmail.com> <20150419081028.GB4313@free.fr> <5533CD7D.1070605@mind.be> From: Fabio Porcedda Date: Mon, 20 Apr 2015 04:36:11 +0200 Message-ID: To: Arnout Vandecappelle Cc: Andrew Ruder , "buildroot@uclibc.org" , "Yann E. MORIN" Subject: Re: [Buildroot] [PATCH 2/3] manual: cvs: document that a date can be used instead of a tag X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" On Sun, Apr 19, 2015 at 5:45 PM, Arnout Vandecappelle wrote: > On 19/04/15 12:08, Fabio Porcedda wrote: >> On Sun, Apr 19, 2015 at 10:10 AM, Yann E. MORIN wrote: >>> Fabio, All, >>> >>> On 2015-04-18 18:54 +0200, Fabio Porcedda spake thusly: >>>> Also instead of using the generic word "timestamp" use the word "tag". >>>> >>>> Signed-off-by: Fabio Porcedda >>>> --- >>>> docs/manual/adding-packages-generic.txt | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt >>>> index 8cf6bb6..be754a2 100644 >>>> --- a/docs/manual/adding-packages-generic.txt >>>> +++ b/docs/manual/adding-packages-generic.txt >>>> @@ -280,7 +280,7 @@ information is (assuming the package name is +libfoo+) : >>>> Only anonymous pserver mode is supported. >>>> +LIBFOO_SITE+ 'must' contain the source URL as well as the remote >>>> repository directory. The module is the package name. >>>> - +LIBFOO_VERSION+ is 'mandatory' and 'must' be a timestamp. >>>> + +LIBFOO_VERSION+ is 'mandatory' and 'must' be a tag or a date. >>> >>> I'd like we document the format of the date we recognise. Because, IIRC, >>> cvs accepts 'yesterday' as a date format, and that would be interpreted >>> as a tag with the current code. >>> >>> So maybe, just state something like: >>> >>> ... or a date (YYYYMMDD:hhmmss) >> >> What about this: >> (--
[T[]] e.g 2015-12-20 or 2015-12-20T1010) > > Can a timezone be added to that? Playing with dates and times without timezone > is dangerous. This one works: (--
[T:[:][-] e.g 2015-12-20 or 2015-12-20T10:10-00) But to made it works I must replace the ":" with "_": index bdb26b8..2beb529 100644 BR --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -325,14 +325,14 @@ $(2)_RAWNAME = $$(patsubst host-%,%,$(1)) ifndef $(2)_VERSION ifdef $(3)_VERSION $(2)_DL_VERSION := $$(strip $$($(3)_VERSION)) - $(2)_VERSION := $$(subst /,_,$$(strip $$($(3)_VERSION))) + $(2)_VERSION := $$(subst :,_,$$(subst /,_,$$(strip $$($(3)_VERSION)))) else $(2)_VERSION = undefined $(2)_DL_VERSION = undefined endif else $(2)_DL_VERSION := $$(strip $$($(2)_VERSION)) - $(2)_VERSION := $$(strip $$(subst /,_,$$($(2)_VERSION))) + $(2)_VERSION := $$(strip $$(subst :,_,$$(subst /,_,$$($(2)_VERSION)))) endif