From patchwork Thu Jan 1 18:03:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Porcedda X-Patchwork-Id: 424898 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id CB84A14010F for ; Fri, 2 Jan 2015 05:04:01 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1023788040; Thu, 1 Jan 2015 18:04:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d2FFhDwWxp7y; Thu, 1 Jan 2015 18:04:00 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 7669587FD1; Thu, 1 Jan 2015 18:04:00 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id CC6621CEBA2 for ; Thu, 1 Jan 2015 18:03:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id C64FB26570 for ; Thu, 1 Jan 2015 18:03:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oTPjMJ+MjuiC for ; Thu, 1 Jan 2015 18:03:58 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oi0-f47.google.com (mail-oi0-f47.google.com [209.85.218.47]) by silver.osuosl.org (Postfix) with ESMTPS id 16DF0263A5 for ; Thu, 1 Jan 2015 18:03:58 +0000 (UTC) Received: by mail-oi0-f47.google.com with SMTP id v63so38662391oia.6 for ; Thu, 01 Jan 2015 10:03:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=Ka7F3A6PTvNq84dpEalOoYLX2T6aQieE1oZe3iyFIk0=; b=l/SpW3SmynpFRxR33MGFvydNBTYGAMgc4pPTlQNUcVRKpFz88BhhaODRD0rBiXoXFP ffnNbqnxUJLXo52fZAEg24sObMpsNbWNxZ8FqHiTNAp0NhFrgeF1YjN0RdvYdHNKmsKU gu9Sd7Haj7xGKQ04ImdXtPmgFl0HsMcT/gqOeVJeSAyDAFZ2SvYQwnjSVsR4Ni8ICEpf OpLbAK3m1L9h0kkKcFLfe34JWIzPW0xsYITV2XOYdZMCCUUTQLICbOMh7+N8YT2pyfTC xoVPZ9TcRNug57oHUJ3jnTrrwXhOSmtqjKRt9QpsHTVTLh7ooMobvRTm/y+MY+ZyDu0M 4lhg== X-Received: by 10.202.220.85 with SMTP id t82mr39897243oig.43.1420135437509; Thu, 01 Jan 2015 10:03:57 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.99.235 with HTTP; Thu, 1 Jan 2015 10:03:37 -0800 (PST) In-Reply-To: <20150101175819.GE4360@free.fr> References: <70490271dbf1774e87cc5dab1a5e907105afeb62.1420130984.git.yann.morin.1998@free.fr> <20150101175819.GE4360@free.fr> From: Fabio Porcedda Date: Thu, 1 Jan 2015 19:03:37 +0100 Message-ID: To: "Yann E. MORIN" Cc: "buildroot@buildroot.org" Subject: Re: [Buildroot] [PATCH 2/2 v8] pkg-download: silence downloads if make is silent X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" On Thu, Jan 1, 2015 at 6:58 PM, Yann E. MORIN wrote: > Fabio, All, > > On 2015-01-01 18:54 +0100, Fabio Porcedda spake thusly: >> On Thu, Jan 1, 2015 at 5:50 PM, Yann E. MORIN wrote: >> > From: Fabio Porcedda >> > >> > If it is a silent build (make -s -> QUIET=-q) silence all downloads, as >> > well as the check-hash. Only stdout is redirected, stderr is still >> > visible, for errors and warning. >> >> Hi Yann, >> nice idea, i tried this patch but even if it works for check-hash and >> svn it does not works for the git backend (e.g. libubox) and the wget >> bakend (try it without the QUIET flags in the WGET variable). >> >> I don't understand the reason for this behavior. >> Do you have an idea for this strange behavior? > > Damn, no. I'll have look. Thank, i think that it must works even when the QUIET variables is not added to the environment variables: diff --git a/package/pkg-download.mk b/package/pkg-download.mk index 9c782fe..5e74519 100644 BR --- a/package/pkg-download.mk +++ b/package/pkg-download.mk @@ -8,14 +8,14 @@ ################################################################################ # Download method commands -export WGET := $(call qstrip,$(BR2_WGET)) $(QUIET) +export WGET := $(call qstrip,$(BR2_WGET)) export SVN := $(call qstrip,$(BR2_SVN)) export CVS := $(call qstrip,$(BR2_CVS)) export BZR := $(call qstrip,$(BR2_BZR)) export GIT := $(call qstrip,$(BR2_GIT)) -export HG := $(call qstrip,$(BR2_HG)) $(QUIET) -export SCP := $(call qstrip,$(BR2_SCP)) $(QUIET) -SSH := $(call qstrip,$(BR2_SSH)) $(QUIET) +export HG := $(call qstrip,$(BR2_HG)) +export SCP := $(call qstrip,$(BR2_SCP)) +SSH := $(call qstrip,$(BR2_SSH)) export LOCALFILES := $(call qstrip,$(BR2_LOCALFILES)) DL_WRAPPER = support/download/dl-wrapper