From patchwork Wed Mar 12 12:44:00 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Fabio Porcedda X-Patchwork-Id: 329429 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ozlabs.org (Postfix) with ESMTP id 63B7D2C0098 for ; Wed, 12 Mar 2014 23:44:24 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id B783080C79; Wed, 12 Mar 2014 12:44:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xq128KNOApvR; Wed, 12 Mar 2014 12:44:22 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3FD5182130; Wed, 12 Mar 2014 12:44:22 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id E97EF1BF9F0 for ; Wed, 12 Mar 2014 12:44:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id E51B48C91A for ; Wed, 12 Mar 2014 12:44:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u-V5fclZ5ROY for ; Wed, 12 Mar 2014 12:44:21 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oa0-f51.google.com (mail-oa0-f51.google.com [209.85.219.51]) by whitealder.osuosl.org (Postfix) with ESMTPS id 119CA8C907 for ; Wed, 12 Mar 2014 12:44:20 +0000 (UTC) Received: by mail-oa0-f51.google.com with SMTP id i4so10046978oah.10 for ; Wed, 12 Mar 2014 05:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=4r2vRaqbGiRVNnmLlqTwwqr/YZ/Wh4pA03hmJBVz+HU=; b=jch6i/aBL2v4jG55xnqWeLQBQGoEXTCf22c93X+aEZIQRi0ShfKGQgUBi4nz2DLeQT FVv2r2Q/lNdlEXu9abkRjy3Rw9KYSmtuk/BrRB7Ivv0qwi3sv5QQmRetgRgvIRnd2u12 ZG1M9PiMoqimY0NjHyU4mZAko+aafID+rZczqckvRoDEs4/p17fiRr+S3IsriECqzbgu 9ozmoczOk86a+U9Tu+lGbxb7To9hS3Mh44NXrTFuHUYrblKRbfRmQb70ZTmhPKA7U6D8 cECEzFr7SVYZ0kkhijzF1I2EXd1vkcHT7xKd/6Rg9s6+gVYCFdVjfsBBafdVQEr9KawZ gn+A== X-Received: by 10.60.56.200 with SMTP id c8mr137461oeq.80.1394628260312; Wed, 12 Mar 2014 05:44:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.76.99.173 with HTTP; Wed, 12 Mar 2014 05:44:00 -0700 (PDT) In-Reply-To: References: <532033B2.9030903@freescale.com> From: Fabio Porcedda Date: Wed, 12 Mar 2014 13:44:00 +0100 Message-ID: To: Thomas De Schampheleire Cc: buildroot Subject: Re: [Buildroot] host-fakeroot archive not sourced any more? X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net On Wed, Mar 12, 2014 at 1:18 PM, Fabio Porcedda wrote: > On Wed, Mar 12, 2014 at 12:56 PM, Thomas De Schampheleire > wrote: >> On Wed, Mar 12, 2014 at 11:15 AM, Vincent Stehlé >> wrote: >>> Hi, >>> >>> FYI it seems buildroot will not source host-fakeroot archive correctly any >>> more when told to 'make source', with some configurations. >>> >>> This behavior can be seen for example on recent commit >>> 1ea6d850891bb4d936bcf1bddbf5432b819d5785, with the following commands: >>> >>> $ rm -fr ..config.tmp .config .config.old output dl/*fakeroot* >>> $ make qemu_arm_vexpress_defconfig >>> $ make source >>> >>> In this case, fakeroot_1.18.2.orig.tar.bz2 is not fetched. >>> >>> After bisect, it seems this behavior started with commit 'a248775 Makefile: >>> add support for top-level parallel make'. >>> >>> A quick fix for 1ea6d850891bb4d936bcf1bddbf5432b819d5785 is to revert, in >>> that order: >>> >>> cf53e15 Makefile: remove BASE_TARGETS variable >>> fbb3b86 Makefile: ensure system is built ... >>> d4c0c64 Makefile: fix target-finalize rule >>> a248775 Makefile: add support for top-level parallel make >>> >>> ...and fakeroot archive is downloaded again. >>> >> >> Vincent: thanks a lot for the report and the analysis! >> >> Fabio: what is your suggestion here? > > I will look at it, thanks for reporting it. Can you try this patch? # all the package names listed in the HOST__DEPENDENCIES for each Regards diff --git a/Makefile b/Makefile index 481f779..e8e41a4 100644 --- a/Makefile +++ b/Makefile @@ -418,7 +418,7 @@ TARGETS_DIRCLEAN := $(patsubst %,%-dirclean,$(TARGETS)) # variable for each enabled target. # Notice: this only works for newstyle gentargets/autotargets packages TARGETS_HOST_DEPS = $(sort $(filter host-%,$(foreach dep,\ - $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS))),\ + $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS) $(TARGETS_ROOTFS))),\ $($(dep))))) # Host packages can in turn have their own dependencies. Likewise find