From patchwork Mon Jun 30 08:55:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Fabio Porcedda X-Patchwork-Id: 365516 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 37A2B1400F3 for ; Mon, 30 Jun 2014 18:56:09 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3FCDD31B74; Mon, 30 Jun 2014 08:56:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iDIqhDrBFzhI; Mon, 30 Jun 2014 08:56:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 7CF06302E4; Mon, 30 Jun 2014 08:56:06 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 65C761BF855 for ; Mon, 30 Jun 2014 08:56:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id B89CB89B01 for ; Mon, 30 Jun 2014 08:56:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QX85a3RtoD9H for ; Mon, 30 Jun 2014 08:56:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oa0-f41.google.com (mail-oa0-f41.google.com [209.85.219.41]) by whitealder.osuosl.org (Postfix) with ESMTPS id 2378789AF5 for ; Mon, 30 Jun 2014 08:56:03 +0000 (UTC) Received: by mail-oa0-f41.google.com with SMTP id l6so8457173oag.14 for ; Mon, 30 Jun 2014 01:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=VA0gR//12uf1xaoPNlvmN8UJtNt6ncXXMcOjuCU+bAo=; b=UoutvcmITjVRlsZ6NWoEStVv83mFn4i67ga3imyemEC1m9uHmz3ZCIVCbkRGxKvIP8 xD0s77W3nf8BZ3Chxe9anEehIDBsH2Ob7fBtwwXGQ19VHJrW1gSo5zlwJBHI5tQZCF/3 0fWBjiP+wwpAVyBVfNbTDw7iGewiTWhFOM0V5ASq6I6FNdnTF3qEgARqo8GOG35vl0Lg F/t8Gz4F6SVCiJicOnO1RaekRZfWtipHe5Atx4HZSS7ntkbSFAXQH72d//DmIk4aM7va RAlEcv6u0/pdjxjLAgxxITqEpe3x7rjE6VDQZ/mCU8xeLygmgNRYgswnb4Svb0ggm7kQ G5BQ== X-Received: by 10.60.62.148 with SMTP id y20mr1090035oer.80.1404118562383; Mon, 30 Jun 2014 01:56:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.76.24.66 with HTTP; Mon, 30 Jun 2014 01:55:42 -0700 (PDT) In-Reply-To: References: <1f09233e5be11d75394054a20c4631cd@openmailbox.org> <20140613140908.532d1852@free-electrons.com> <5ad7ccb84a6c2b6d18526aeab1f9c65c@openmailbox.org> From: Fabio Porcedda Date: Mon, 30 Jun 2014 10:55:42 +0200 Message-ID: To: =?UTF-8?Q?C=C3=A9dric_Marie?= Cc: Thomas Petazzoni , "buildroot@busybox.net" Subject: Re: [Buildroot] rsync forces configure step X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net On Mon, Jun 30, 2014 at 10:04 AM, Fabio Porcedda wrote: > On Mon, Jun 30, 2014 at 10:02 AM, Cédric Marie > wrote: >> Le 2014-06-13 14:15, Fabio Porcedda a écrit : >>> >>> On Fri, Jun 13, 2014 at 2:09 PM, Thomas Petazzoni >>> wrote: >>>> >>>> This indeed seems correct. I've Cc'ed Fabio who is working on the >>>> top-level parallel build feature, I guess he'll have a look and give >>>> you more feedback and/or send a patch fixing this issue. >>>> >>>> Thanks a lot for the report! >>> >>> >>> Hi all, >>> thanks for reporting the issue, I will check it and send a patch to fix >>> it. >> >> >> >> Hi Fabio, >> >> Have you had the time to have a look at this? >> I'm currently using the patch I have proposed (with the pipe), but I would >> be more confident if it was confirmed by an official fix. > > Hi Cédric, > I'm going to check it now. > > BR > -- > Fabio Porcedda The problem is that the stamp file for rsync is being removed with the "-rebuild" command, so i think that the right fix is: The problem is not related to top-level parallel build, the problem was present even the previous release (2014.02), the problem was always existed sine the introduction of the "-rebuild" feature: http://git.buildroot.net/buildroot/commit/?id=4ed4e5016b741341059ed826416dad3291df0b2c Author: Thomas Petazzoni Date: Thu Sep 29 21:57:39 2011 +0200 package: add -rebuild and -reconfigure Thomas do you know why you removed the sync stamp file? BR diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index 54193d2..67821ec 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -569,9 +569,6 @@ $(1)-graph-depends: graph-depends-requirements $(1)-dirclean: $$($(2)_TARGET_DIRCLEAN) $(1)-clean-for-rebuild: -ifneq ($$($(2)_OVERRIDE_SRCDIR),) - rm -f $$($(2)_TARGET_RSYNC) -endif rm -f $$($(2)_TARGET_BUILD) rm -f $$($(2)_TARGET_INSTALL_STAGING) rm -f $$($(2)_TARGET_INSTALL_TARGET)