From patchwork Thu Dec 19 13:23:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Porcedda X-Patchwork-Id: 303552 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id B6FB02C0079 for ; Fri, 20 Dec 2013 00:24:15 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5D6F293E25; Thu, 19 Dec 2013 13:24:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bQVJgPd8hbY8; Thu, 19 Dec 2013 13:24:12 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id BD3F293E26; Thu, 19 Dec 2013 13:24:12 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 437D11BF9C1 for ; Thu, 19 Dec 2013 13:24:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3E89733202 for ; Thu, 19 Dec 2013 13:24:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nqKnVrPKDUZB for ; Thu, 19 Dec 2013 13:24:10 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pb0-f46.google.com (mail-pb0-f46.google.com [209.85.160.46]) by silver.osuosl.org (Postfix) with ESMTPS id 6AD1E33200 for ; Thu, 19 Dec 2013 13:24:10 +0000 (UTC) Received: by mail-pb0-f46.google.com with SMTP id md12so1142632pbc.5 for ; Thu, 19 Dec 2013 05:24:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=zPmN/NocqwScaiTn2J2cwtkZTmEFssTzqW1tdZLYr1A=; b=i6gGvJpdF9L58GuK1NyDbqKdLTabbM25xBfhaidSiCR+fu2MUWjYsT0Ak/tMvbmFY6 W0Vd5WqV64u4TYTFA2YjypfCFkvWLpE1U9V23QzmPjsEa289Hf6AhxeC++2sZZxwzlYZ fd9KYiI8hE6RxPJWktjmu9zFgQxnGl39UwlzvUc7koQnl+R+JeNwtwVgDVsxyJ7xIv2R WRApeQUm5MawdfXWNkG9m3Tftsvpg8XKezkBr1YmKovljo0fsq9CQZhZ5tHKEwEglrD/ JpMOQUL0GaCfuh8Vxu0kuqTJ8EQGx+Q4F3RDzrKDTpFbTRB4pSp7VB+bQ1APJZNjlQxg MV0Q== X-Received: by 10.68.233.33 with SMTP id tt1mr1728640pbc.64.1387459450103; Thu, 19 Dec 2013 05:24:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.70.44.77 with HTTP; Thu, 19 Dec 2013 05:23:50 -0800 (PST) In-Reply-To: <20131219114349.108e1147@skate> References: <1387263739-3831-1-git-send-email-fabio.porcedda@gmail.com> <20131217101137.5c8845a3@skate> <20131219114349.108e1147@skate> From: Fabio Porcedda Date: Thu, 19 Dec 2013 14:23:50 +0100 Message-ID: To: Thomas Petazzoni Cc: "buildroot@uclibc.org" Subject: Re: [Buildroot] [PATCH] lvm2: disable statical building because it fails X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net On Thu, Dec 19, 2013 at 11:43 AM, Thomas Petazzoni wrote: > Dear Fabio Porcedda, > > On Thu, 19 Dec 2013 11:36:51 +0100, Fabio Porcedda wrote: > >> > Thanks, but you forgot to propagate this new dependency to the reverse >> > dependencies of lvm2, and you forgot to add the corresponding comment. >> > See >> > http://buildroot.org/downloads/manual/manual.html#dependencies-target-toolchain-options. >> >> Ok, thanks, i will send an updated patch. > > Looking more at the problem, isn't it possible to fix the static build > of LVM2, rather than preventing LVM2 from being selected in this case? Yes, i've found a way to fix that. First is a fix to buildroot adding: +LVM2_CONF_OPT += --enable-static_link The second one is a bug within lvm2 when using static building. Best regards diff --git a/home/fabiopo/tmp/Makefile.in b/output/build/lvm2-2.02.103/libdm/Makefile.in index 7b40bde..bddb0a0 100644 --- a/home/fabiopo/tmp/Makefile.in +++ b/output/build/lvm2-2.02.103/libdm/Makefile.in @@ -40,7 +40,6 @@ endif ifeq ("@STATIC_LINK@", "yes") LIB_STATIC = $(interface)/libdevmapper.a -TARGETS += libdevmapper.a endif LIB_SHARED = $(interface)/libdevmapper.$(LIB_SUFFIX) @@ -65,9 +64,6 @@ device-mapper: all libdevmapper.$(LIB_SUFFIX) libdevmapper.$(LIB_SUFFIX).$(LIB_VERSION): $(LIB_SHARED) $(LN_S) -f $< $@ -libdevmapper.a: $(LIB_STATIC) - $(LN_S) -f $< $@ - I will prepare a patch to fix lvm2 static building.